https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-01-14T15:19:45ZRedmineRedmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=831032018-01-14T15:19:45ZToshi MARUYAMA
<ul><li><strong>Target version</strong> set to <i>3.4.5</i></li></ul><p>Hooman Valibeigi wrote:</p>
<blockquote>
<p>The fix at <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Allow overriding direction of part of text (Closed)" href="https://www.redmine.org/issues/8121">#8121</a> is broken as stated in my last comment there.</p>
<p>My environment: Redmine 3.4.2, Google Chrome 63</p>
<p>1. `p(rtl).` maps to `class="wiki-class-rtl"` in html, but there is no such class in application.css</p>
</blockquote>
<p>I think we can change like <a class="changeset" title="Rename @noborder@ CSS class to @wiki-class-noborder@ in order to be accessible from user-provided..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16503">r16503</a>.</p>
<blockquote>
<p>2. `unicode-bidi:bidi-override` must be removed or set to `normal`<br />See <a class="external" href="https://www.w3schools.com/cssref/pr_text_unicode-bidi.asp">https://www.w3schools.com/cssref/pr_text_unicode-bidi.asp</a></p>
</blockquote>
<p>Which do you think is better?</p> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=831932018-01-17T13:14:22ZHooman Valibeigi
<ul></ul><p>Toshi MARUYAMA wrote:</p>
<blockquote>
<p>Which do you think is better?</p>
</blockquote>
<p>Replacing the following lines in application.xml<br /><pre>.ltr {direction:ltr !important; unicode-bidi:bidi-override;}
.rtl {direction:rtl !important; unicode-bidi:bidi-override;}</pre><br />with these, will fix it<br /><pre>.wiki-class-ltr {direction:ltr !important;}
.wiki-class-rtl {direction:rtl !important;}</pre></p> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=831942018-01-17T13:19:50ZHooman Valibeigi
<ul></ul><p>It would be more appreciated if someone documents the syntax of `p(rtl).` on the wiki<br /><a class="external" href="https://www.redmine.org/projects/redmine/wiki/RedmineTextFormattingTextile">https://www.redmine.org/projects/redmine/wiki/RedmineTextFormattingTextile</a></p> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=831972018-01-17T13:53:38ZToshi MARUYAMA
<ul></ul><p>Hooman Valibeigi wrote:</p>
<blockquote>
<p>Toshi MARUYAMA wrote:</p>
<blockquote>
<p>Which do you think is better?</p>
</blockquote>
<p>Replacing the following lines in application.xml</p>
</blockquote>
<p>Do you mean application.css, not application.xml?</p> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=832002018-01-17T15:14:50ZHooman Valibeigi
<ul></ul><p>Toshi MARUYAMA wrote:</p>
<blockquote>
<p>Do you mean application.css, not application.xml?</p>
</blockquote>
<p>Yes, redmine/public/stylesheets/application.css</p> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=833172018-01-25T09:41:20ZHooman Valibeigi
<ul></ul><p>I've just noticed that HTML emails sent from Redmine will contain class="wiki-class-rtl" for RTL text, which is not supposed to work because email clients have no access to Redmine css.</p> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=843962018-04-07T07:08:07ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Support RTL Bidirection text</i> to <i>RTL wiki class broken in Redmine 3.2.6</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Target version</strong> changed from <i>3.4.5</i> to <i>3.3.7</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>The wiki class is fixed by <a class="changeset" title="Fix .rtl and .ltr css classes in formatted text broken by r16502 (#27884)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17260">r17260</a>.</p>
<blockquote>
<p>I've just noticed that HTML emails sent from Redmine will contain class="wiki-class-rtl" for RTL text, which is not supposed to work because email clients have no access to Redmine css.</p>
</blockquote>
<p>Please open a separate issue as this problem is not specific the .rtl class.</p> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=844012018-04-07T09:11:43ZHooman Valibeigi
<ul></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
<p>The wiki class is fixed by <a class="changeset" title="Fix .rtl and .ltr css classes in formatted text broken by r16502 (#27884)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17260">r17260</a>.</p>
</blockquote>
<p>You forgot to fix the unicode-bidi:bidi-override; value, must be unicode-bidi:normal; or left unset. bidi-override rotates the English words in a RTL context, therefore word "cat" will be seen as "tac".</p> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=844022018-04-07T09:18:40ZHooman Valibeigi
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=844032018-04-07T09:27:36ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/8121">Feature #8121</a>: Allow overriding direction of part of text</i> added</li></ul> Redmine - Defect #27884: RTL wiki class broken in Redmine 3.2.6https://www.redmine.org/issues/27884?journal_id=844052018-04-07T09:31:17ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>bidi-override removed in <a class="changeset" title="Removes bidi-override in rtl/ltr wiki classes (#27884)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17280">r17280</a>.</p>