https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-04-30T09:10:33ZRedmineRedmine - Patch #28662: Replace "Cancel" buttons from the modals with "Cancel" linkhttps://www.redmine.org/issues/28662?journal_id=847662018-04-30T09:10:33ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/20585">current.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20585/current.png">current.png</a> added</li><li><strong>File</strong> <a href="/attachments/20586">after.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20586/after.png">after.png</a> added</li></ul><p>Current UI:<br /><img src="https://www.redmine.org/attachments/download/20585/current.png" style="height: 300px;border:1px solid #ccc;" alt="" /></p>
<p>After applying this patch:<br /><img src="https://www.redmine.org/attachments/download/20586/after.png" style="height: 300px;border:1px solid #ccc;" alt="" /></p> Redmine - Patch #28662: Replace "Cancel" buttons from the modals with "Cancel" linkhttps://www.redmine.org/issues/28662?journal_id=849732018-05-13T00:09:23ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul> Redmine - Patch #28662: Replace "Cancel" buttons from the modals with "Cancel" linkhttps://www.redmine.org/issues/28662?journal_id=881852018-10-31T00:40:07ZGo MAEDA
<ul><li><strong>File</strong> <i>patch-29848-v2.patch</i> added</li></ul><p>Updated the patch for the current trunk (<a class="changeset" title="Use Project::STATUS_ACTIVE constant instead of harcoded 1 (#29449). Patch by Marius BALTEANU." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17612">r17612</a>).</p>
<pre>
$ patch -p1 < 0001-replace-Cancel-button-in-the-modals-with-a-Cancel-li.patch
patching file app/views/groups/_new_users_modal.html.erb
patching file app/views/issue_categories/_new_modal.html.erb
patching file app/views/issues/index.html.erb
Hunk #1 FAILED at 45.
1 out of 1 hunk FAILED -- saving rejects to file app/views/issues/index.html.erb.rej
patching file app/views/members/_new_modal.html.erb
patching file app/views/principal_memberships/_new_modal.html.erb
patching file app/views/sudo_mode/_new_modal.html.erb
patching file app/views/timelog/index.html.erb
Hunk #1 FAILED at 33.
1 out of 1 hunk FAILED -- saving rejects to file app/views/timelog/index.html.erb.rej
patching file app/views/versions/_new_modal.html.erb
patching file app/views/watchers/_new.html.erb
patching file app/views/wiki/_new_modal.html.erb
Hunk #1 succeeded at 24 (offset 8 lines).
</pre> Redmine - Patch #28662: Replace "Cancel" buttons from the modals with "Cancel" linkhttps://www.redmine.org/issues/28662?journal_id=881952018-10-31T09:11:30ZMarius BĂLTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Updated the patch for the current trunk (<a class="changeset" title="Use Project::STATUS_ACTIVE constant instead of harcoded 1 (#29449). Patch by Marius BALTEANU." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17612">r17612</a>).</p>
<p>[...]</p>
</blockquote>
<p>Please note that the updated patch includes some changes that are already committed. Please let me know if you want to update the patch for you.</p> Redmine - Patch #28662: Replace "Cancel" buttons from the modals with "Cancel" linkhttps://www.redmine.org/issues/28662?journal_id=883292018-11-10T07:42:08ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0001-replace-Cancel-button-in-the-modals-with-a-Cancel-li.patch</i></del>)</li></ul> Redmine - Patch #28662: Replace "Cancel" buttons from the modals with "Cancel" linkhttps://www.redmine.org/issues/28662?journal_id=883302018-11-10T07:42:14ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>patch-29848-v2.patch</i></del>)</li></ul> Redmine - Patch #28662: Replace "Cancel" buttons from the modals with "Cancel" linkhttps://www.redmine.org/issues/28662?journal_id=883312018-11-10T07:43:37ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/21785">0001-Replace-cancel-button-with-cancel-link-in-modals.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21785/0001-Replace-cancel-button-with-cancel-link-in-modals.patch">0001-Replace-cancel-button-with-cancel-link-in-modals.patch</a> added</li></ul><p>@Go Maeda, I've removed from your updated patch some unnecessary changes.</p> Redmine - Patch #28662: Replace "Cancel" buttons from the modals with "Cancel" linkhttps://www.redmine.org/issues/28662?journal_id=886942018-12-02T06:25:17ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>4.0.0</i></li></ul><p>Committed the patch. Thank you for your contribution.</p>