https://www.redmine.org/
https://www.redmine.org/favicon.ico?1679302129
2018-05-06T00:10:49Z
Redmine
Redmine - Defect #28689: csv 1.0.2 gem breaks ImportsControllerTest
https://www.redmine.org/issues/28689?journal_id=84861
2018-05-06T00:10:49Z
Go MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/27849">Feature #27849</a>: Ruby 2.5 support</i> added</li></ul>
Redmine - Defect #28689: csv 1.0.2 gem breaks ImportsControllerTest
https://www.redmine.org/issues/28689?journal_id=84863
2018-05-06T00:11:16Z
Go MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/28112">Patch #28112</a>: CsvTest fails due to a regression in Ruby 2.5</i> added</li></ul>
Redmine - Defect #28689: csv 1.0.2 gem breaks ImportsControllerTest
https://www.redmine.org/issues/28689?journal_id=84865
2018-05-06T01:10:41Z
Go MAEDA
<ul><li><strong>Category</strong> changed from <i>Ruby support</i> to <i>Gems support</i></li></ul><p>The cause of this issue is the changed behavior of csv gem. csv gem 1.0.2 throws MalformedCSVError instead of ArgumentError if the library find invalid byte sequences in a CSV file. As a result, Redmine displays the error :error_invalid_csv_file_or_settings instead of :error_invalid_file_encoding.</p>
<p>The behavior has changed by this commit.</p>
<p><a class="external" href="https://github.com/ruby/csv/commit/88a3471203a3bc83d58ab015e92182ae5d8e0ad0">https://github.com/ruby/csv/commit/88a3471203a3bc83d58ab015e92182ae5d8e0ad0</a></p>
<p>The current versions of Redmine expect ArgumentError if the parameter and file encoding does not much.</p>
<p><a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/tags/3.4.5/app/controllers/imports_controller.rb#L55">source:tags/3.4.5/app/controllers/imports_controller.rb#L55</a></p>
Redmine - Defect #28689: csv 1.0.2 gem breaks ImportsControllerTest
https://www.redmine.org/issues/28689?journal_id=84866
2018-05-06T02:45:31Z
Go MAEDA
<ul><li><strong>File</strong> <a href="/attachments/20619">28689.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20619/28689.diff">28689.diff</a> added</li><li><strong>Target version</strong> set to <i>4.0.0</i></li></ul><p>The attached patch should fix this issue.<br />Setting target version to 4.0.0.</p>
Redmine - Defect #28689: csv 1.0.2 gem breaks ImportsControllerTest
https://www.redmine.org/issues/28689?journal_id=84867
2018-05-06T03:54:28Z
Go MAEDA
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>The attached patch should fix this issue.</p>
</blockquote>
<p>No, csv gem does not support Ruby < 2.3. Redmine 4.0.0 will support Ruby 2.2.2 and later. (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Drop support for Ruby 2.2.1 and ealier, 2.2.2+ is now required (Closed)" href="https://www.redmine.org/issues/25538">#25538</a>).</p>
Redmine - Defect #28689: csv 1.0.2 gem breaks ImportsControllerTest
https://www.redmine.org/issues/28689?journal_id=84868
2018-05-06T05:32:42Z
Go MAEDA
<ul><li><strong>File</strong> <a href="/attachments/20620">28689-v2.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20620/28689-v2.diff">28689-v2.diff</a> added</li></ul><p>Here is an updated patch. Tested with Ruby 2.2, 2.3, 2.4, and 2.5.</p>
Redmine - Defect #28689: csv 1.0.2 gem breaks ImportsControllerTest
https://www.redmine.org/issues/28689?journal_id=84869
2018-05-06T07:51:04Z
Go MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> deleted (<del><i>4.0.0</i></del>)</li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed.</p>