https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-05-17T00:24:12ZRedmineRedmine - Feature #28796: Make sure that inline markups inserted by wiki toolbar are surrounded by whitespaceshttps://www.redmine.org/issues/28796?journal_id=850462018-05-17T00:24:12ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/20681">test.gif</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20681/test.gif">test.gif</a> added</li></ul><p>I wrote a patch to realize this feature.<br /><img src="https://www.redmine.org/attachments/download/20681/test.gif" alt="" /></p> Redmine - Feature #28796: Make sure that inline markups inserted by wiki toolbar are surrounded by whitespaceshttps://www.redmine.org/issues/28796?journal_id=850472018-05-17T00:25:31ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/20683">add-space.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20683/add-space.patch">add-space.patch</a> added</li></ul> Redmine - Feature #28796: Make sure that inline markups inserted by wiki toolbar are surrounded by whitespaceshttps://www.redmine.org/issues/28796?journal_id=850522018-05-17T12:46:45ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul><p>In some languages such as Japanese, Chinese and Thai, words in a sentence are not separated by space. This patch should improve UX for people who speak those languages.</p>
<p>Here is an example of Japanese sentence:</p>
<pre>
今日は良い天気です。
(It is fine weather today.)
</pre>
<p>If you make the word "天気" (weather) bold by using wiki toolbar, you will get the text as follows. However, the word "天気" will not be displayed in bold because there are no whitespaces around the word. The behavior has confused many users in Japan.</p>
<pre>
今日は良い*天気*です。
</pre>
<p>After appling the Mizuki's patch, you will get the following text. It inserts spaces if there are no whitespaces around the selection. As a result, the word "天気" will be displayed in bold as expected.</p>
<pre>
今日は良い *天気* です。
</pre>
<p>I think the patch can improve UX for some Asian people without any negative side effects for other people.</p> Redmine - Feature #28796: Make sure that inline markups inserted by wiki toolbar are surrounded by whitespaceshttps://www.redmine.org/issues/28796?journal_id=850772018-05-19T04:56:24ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/20699">unnecessary-space-1.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20699/unnecessary-space-1.png">unnecessary-space-1.png</a> added</li><li><strong>File</strong> <a href="/attachments/20700">unnecessary-space-2.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20700/unnecessary-space-2.png">unnecessary-space-2.png</a> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>Needs feedback</i></li><li><strong>Assignee</strong> set to <i>Mizuki ISHIKAWA</i></li></ul><p>The patch looks good except one small issue. An unnecessary space will be inserted before the markup if a user selects text at the beginning of the first line. Could you update your patch?</p>
<p><img src="https://www.redmine.org/attachments/download/20699/unnecessary-space-1.png" style="width: 200px;border: 1px solid #ccc;" alt="" /> → <img src="https://www.redmine.org/attachments/download/20700/unnecessary-space-2.png" style="width: 200px;border: 1px solid #ccc;" alt="" /></p> Redmine - Feature #28796: Make sure that inline markups inserted by wiki toolbar are surrounded by whitespaceshttps://www.redmine.org/issues/28796?journal_id=850932018-05-21T00:12:17ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/20718">add-space-2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20718/add-space-2.patch">add-space-2.patch</a> added</li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>The patch looks good except one small issue. An unnecessary space will be inserted before the markup if a user selects text at the beginning of the first line. Could you update your patch?</p>
</blockquote>
<p>I fixed the issue.<br />Thank you for your confirmation.</p> Redmine - Feature #28796: Make sure that inline markups inserted by wiki toolbar are surrounded by whitespaceshttps://www.redmine.org/issues/28796?journal_id=850952018-05-21T00:57:32ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Insert a space when adding a single tag by the button</i> to <i>Ensure that phrase modifier inserted by wiki toolbar is surrounded by whitespaces</i></li><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>New</i></li><li><strong>Assignee</strong> deleted (<del><i>Mizuki ISHIKAWA</i></del>)</li><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul><p>LGTM, setting target version to 4.1.0.</p> Redmine - Feature #28796: Make sure that inline markups inserted by wiki toolbar are surrounded by whitespaceshttps://www.redmine.org/issues/28796?journal_id=851132018-05-21T14:45:18ZGo MAEDA
<ul><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li></ul> Redmine - Feature #28796: Make sure that inline markups inserted by wiki toolbar are surrounded by whitespaceshttps://www.redmine.org/issues/28796?journal_id=851712018-05-23T01:28:52ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Ensure that phrase modifier inserted by wiki toolbar is surrounded by whitespaces</i> to <i>Make sure that inline markups inserted by wiki toolbar are surrounded by whitespaces</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>4.0.0</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed with a slight change. Thank you for improving Redmine.</p>