https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-10-04T15:46:42ZRedmineRedmine - Defect #29730: Previous/Next link on repository page disappear when switching to "View differences" tabhttps://www.redmine.org/issues/29730?journal_id=878342018-10-04T15:46:42ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/26576">Feature #26576</a>: Use tabs to switch between file changes and diff of a commit</i> added</li></ul> Redmine - Defect #29730: Previous/Next link on repository page disappear when switching to "View differences" tabhttps://www.redmine.org/issues/29730?journal_id=879912018-10-15T04:41:04ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/21630">fix-29730.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21630/fix-29730.patch">fix-29730.patch</a> added</li></ul><p>By applying this patch I think that the Previous/Next link will be displayed.</p> Redmine - Defect #29730: Previous/Next link on repository page disappear when switching to "View differences" tabhttps://www.redmine.org/issues/29730?journal_id=881322018-10-28T12:00:27ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed. Thank you for fixing this issue.</p> Redmine - Defect #29730: Previous/Next link on repository page disappear when switching to "View differences" tabhttps://www.redmine.org/issues/29730?journal_id=881332018-10-28T12:26:50ZMarius BÄ‚LTEANU
<ul><li><strong>Target version</strong> set to <i>4.0.0</i></li></ul> Redmine - Defect #29730: Previous/Next link on repository page disappear when switching to "View differences" tabhttps://www.redmine.org/issues/29730?journal_id=881542018-10-29T00:11:18ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li><li><strong>Target version</strong> changed from <i>4.0.0</i> to <i>Candidate for next major release</i></li><li><strong>Resolution</strong> deleted (<del><i>Fixed</i></del>)</li></ul><p>The patch breaks some tests. Reverted the change.</p>
<p><a href="#" onclick="$('#collapse-891a502f-show, #collapse-891a502f-hide').toggle(); $('#collapse-891a502f').fadeToggle(150);; return false;" id="collapse-891a502f-show" class="icon icon-collapsed collapsible">Show</a><a href="#" onclick="$('#collapse-891a502f-show, #collapse-891a502f-hide').toggle(); $('#collapse-891a502f').fadeToggle(150);; return false;" id="collapse-891a502f-hide" class="icon icon-expended collapsible" style="display:none;">Hide</a><div id="collapse-891a502f" class="collapsed-text" style="display:none;"><pre>
# Running:
..........................................................................................................................................................................F
Failure:
RepositoriesGitTest#test_diff_two_revs [/var/lib/jenkins/workspace/trunk/DATABASE_ADAPTER/sqlite3/RUBY_VER/ruby-2.5/test/integration/repositories_git_test.rb:47]:
Expected response to be a <2XX: success>, but was a <500: Internal Server Error>
bin/rails test test/integration/repositories_git_test.rb:45
...............................................................................................................................................................................................................................................................................................................................................................................................................SS...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................E
Error:
RepositoriesGitControllerTest#test_save_diff_type:
ActionView::Template::Error: undefined method `previous' for nil:NilClass
app/views/repositories/diff.html.erb:3:in `_app_views_repositories_diff_html_erb__749227865__1013454858'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'
test/functional/repositories_git_controller_test.rb:472:in `test_save_diff_type'
bin/rails test test/functional/repositories_git_controller_test.rb:464
...........E
Error:
RepositoriesGitControllerTest#test_diff_path_in_subrepo:
ActionView::Template::Error: undefined method `previous' for nil:NilClass
app/views/repositories/diff.html.erb:3:in `_app_views_repositories_diff_html_erb__749227865__1013454858'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'
test/functional/repositories_git_controller_test.rb:414:in `test_diff_path_in_subrepo'
bin/rails test test/functional/repositories_git_controller_test.rb:404
...E
Error:
RepositoriesGitControllerTest#test_diff_should_show_filenames:
ActionView::Template::Error: undefined method `previous' for nil:NilClass
app/views/repositories/diff.html.erb:3:in `_app_views_repositories_diff_html_erb__749227865__1013454858'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'
test/functional/repositories_git_controller_test.rb:451:in `test_diff_should_show_filenames'
bin/rails test test/functional/repositories_git_controller_test.rb:450
......E
Error:
RepositoriesGitControllerTest#test_diff_latin_1:
ActionView::Template::Error: undefined method `previous' for nil:NilClass
app/views/repositories/diff.html.erb:3:in `_app_views_repositories_diff_html_erb__749227865__1013454858'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'
test/functional/repositories_git_controller_test.rb:433:in `block (3 levels) in test_diff_latin_1'
test/functional/repositories_git_controller_test.rb:432:in `each'
test/functional/repositories_git_controller_test.rb:432:in `block (2 levels) in test_diff_latin_1'
test/functional/repositories_git_controller_test.rb:431:in `each'
test/functional/repositories_git_controller_test.rb:431:in `block in test_diff_latin_1'
test/test_helper.rb:93:in `with_settings'
test/functional/repositories_git_controller_test.rb:430:in `test_diff_latin_1'
bin/rails test test/functional/repositories_git_controller_test.rb:426
..........................................................................................................................................................................................................................................................................................E
Error:
RepositoriesMercurialControllerTest#test_diff_should_show_deleted_filenames:
ActionView::Template::Error: undefined method `previous' for nil:NilClass
app/views/repositories/diff.html.erb:3:in `_app_views_repositories_diff_html_erb__749227865__1013454858'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'
test/functional/repositories_mercurial_controller_test.rb:416:in `test_diff_should_show_deleted_filenames'
bin/rails test test/functional/repositories_mercurial_controller_test.rb:415
..E
Error:
RepositoriesMercurialControllerTest#test_diff_latin_1_path:
ActionView::Template::Error: undefined method `previous' for nil:NilClass
app/views/repositories/diff.html.erb:3:in `_app_views_repositories_diff_html_erb__749227865__1013454858'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'
test/functional/repositories_mercurial_controller_test.rb:388:in `block (3 levels) in test_diff_latin_1_path'
test/functional/repositories_mercurial_controller_test.rb:387:in `each'
test/functional/repositories_mercurial_controller_test.rb:387:in `block (2 levels) in test_diff_latin_1_path'
test/functional/repositories_mercurial_controller_test.rb:386:in `each'
test/functional/repositories_mercurial_controller_test.rb:386:in `block in test_diff_latin_1_path'
test/test_helper.rb:93:in `with_settings'
test/functional/repositories_mercurial_controller_test.rb:385:in `test_diff_latin_1_path'
bin/rails test test/functional/repositories_mercurial_controller_test.rb:384
E
Error:
RepositoriesMercurialControllerTest#test_diff_should_show_modified_filenames:
ActionView::Template::Error: undefined method `previous' for nil:NilClass
app/views/repositories/diff.html.erb:3:in `_app_views_repositories_diff_html_erb__749227865__1013454858'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'
test/functional/repositories_mercurial_controller_test.rb:405:in `test_diff_should_show_modified_filenames'
bin/rails test test/functional/repositories_mercurial_controller_test.rb:404
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................Deprecation warning: Net::LDAP::ConnectionRefused will be deprecated. Use Errno::ECONNREFUSED instead.
Deprecation warning: Net::LDAP::ConnectionRefused will be deprecated. Use Errno::ECONNREFUSED instead.
..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................S..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................E
Error:
RepositoriesBazaarControllerTest#test_diff:
ActionView::Template::Error: undefined method `previous' for nil:NilClass
app/views/repositories/diff.html.erb:3:in `_app_views_repositories_diff_html_erb__749227865__1013454858'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'
test/functional/repositories_bazaar_controller_test.rb:146:in `block in test_diff'
test/functional/repositories_bazaar_controller_test.rb:145:in `each'
test/functional/repositories_bazaar_controller_test.rb:145:in `test_diff'
bin/rails test test/functional/repositories_bazaar_controller_test.rb:143
.................
Finished in 428.714970s, 10.9140 runs/s, 49.5901 assertions/s.
4679 runs, 21260 assertions, 1 failures, 8 errors, 3 skips
You have skipped tests. Run with --verbose for details.
</pre></div></p> Redmine - Defect #29730: Previous/Next link on repository page disappear when switching to "View differences" tabhttps://www.redmine.org/issues/29730?journal_id=881552018-10-29T01:50:57ZMizuki ISHIKAWA
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>The patch breaks some tests. Reverted the change.</p>
</blockquote>
<p>I'm sorry, I missed the result of the test.<br />If you add the following code to the patch of <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Previous/Next link on repository page disappear when switching to "View differences" tab (Closed)" href="https://www.redmine.org/issues/29730#note-2">#29730#note-2</a> , the tests should succeed.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/app/views/repositories/diff.html.erb b/app/views/repositories/diff.html.erb
index 12875f21ee..3dcc0fdc79 100644
</span><span class="gd">--- a/app/views/repositories/diff.html.erb
</span><span class="gi">+++ b/app/views/repositories/diff.html.erb
</span><span class="p">@@ -1,3 +1,4 @@</span>
<span class="gi">+<% if @changeset && @changeset_to.nil? %>
</span> <div class="contextual">
&#171;
<% unless @changeset.previous.nil? -%>
<span class="p">@@ -25,7 +26,6 @@</span>
<%= submit_tag 'OK', :name => nil %>
<% end %>
</div>
<span class="gd">-<% if @changeset && @changeset_to.nil? %>
</span> <%= render :partial => 'changeset' %>
<% else %>
<h2><%= l(:label_revision) %> <%= @diff_format_revisions %> <%= @path %></h2>
<span class="gh">diff --git a/tmp/test/empty b/tmp/test/empty
</span><span class="p">deleted file mode 100644
</span><span class="gh">index e69de29bb2..0000000000
</span></code></pre> Redmine - Defect #29730: Previous/Next link on repository page disappear when switching to "View differences" tabhttps://www.redmine.org/issues/29730?journal_id=882482018-11-05T02:44:55ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li><li><strong>Target version</strong> deleted (<del><i>Candidate for next major release</i></del>)</li></ul><p>Committed the patch again. Thanks.</p>
<p>I don't set the target version of this issue because I think this is a fix for <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Use tabs to switch between file changes and diff of a commit (Closed)" href="https://www.redmine.org/issues/26576">#26576</a>, one of a new feature of Redmine 4.0.0 which is not released yet (no releases are affected by this issue).</p> Redmine - Defect #29730: Previous/Next link on repository page disappear when switching to "View differences" tabhttps://www.redmine.org/issues/29730?journal_id=897662019-02-03T11:29:40ZGo MAEDA
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/8254">Feature #8254</a>: Add previous/next functionality in diffs</i> added</li></ul>