Redmine

Starting to work on this in a GitHub branch: http://github.com/edavis10/redmine_branches/tree/sti-enumerations

Also a nice side benefit of this is that a plugin can add a subclass of Enumeration and automagically get all the methods and be added to the Enumeration Administration panel. This might open up the doors for some more integrated plugins.

I didn't test it but the patch looks good. A few things:

1. I would really prefer to split the migration: one that adds the column, ones that populates it. So that if an error is raised when updating for some reason, you'll still be able to rerun db:migrate without getting an error because the column to add already exists.
2. Since we now have dedicated models, we should better use the standard .human_name rails class method rather than Enumeration.option_name. Of course, translation files must be adjusted so that classes names are properly translated.
3. We have DocumentCategory, IssuePriority. Maybe we should have TimeEntryActivity ?
4. Maybe you could declare some has_many relations in subclasses to clean up the code, eg:

class IssuePriority < Enumeration
  has_many :issues, :foreign_key => 'priority_id'

  def objects_count
    issues.count
  end

  def transfer_relations(to)
    issues.update_all("priority_id = #{to.id}")
  end
end

Jean-Philippe Lang wrote:

1. I would really prefer to split the migration: one that adds the column, ones that populates it. So that if an error is raised when updating for some reason, you'll still be able to rerun db:migrate without getting an error because the column to add already exists.

Good idea.

1. Since we now have dedicated models, we should better use the standard .human_name rails class method rather than Enumeration.option_name. Of course, translation files must be adjusted so that classes names are properly translated.

I agree, with the split option_name really isn't needed except for two views.

1. We have DocumentCategory, IssuePriority. Maybe we should have TimeEntryActivity ?

Do you think Activities would ever be used for things other than a TimeEntry?

1. Maybe you could declare some has_many relations in subclasses to clean up the code, eg:

That's a good suggestion. I was trying to keep this patch so it's just rearranging the internals but I could see the relationships being useful.

FYI: I've pushed up some updates to GitHub for the EnumerationController. I had a few bugs where the type wasn't being set (can't be mass-assigned). I'll create a new patch for here soon.