https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-03-01T16:28:15ZRedmineRedmine - Defect #30949: Roadmap shows 100%, but one of its tasks is still set to 90%https://www.redmine.org/issues/30949?journal_id=905032019-03-01T16:28:15ZBernhard Rohloff
<ul><li><strong>File</strong> <a href="/attachments/22540">prevent_rounding_of_version_progress.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22540/prevent_rounding_of_version_progress.diff">prevent_rounding_of_version_progress.diff</a> added</li></ul><p>I can reproduce it and agree, that this is an odd behavior.<br />The issue is that the calculated done ratio gets rounded before displaying which in my opinion is wrong.<br />Attached you can find a patch to fix it. Feedback is highly appreciated. :)</p> Redmine - Defect #30949: Roadmap shows 100%, but one of its tasks is still set to 90%https://www.redmine.org/issues/30949?journal_id=905042019-03-01T16:39:14ZBernhard Rohloff
<ul></ul><p>By the way...<br />The issue is also related to <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: The progress exceeding 99.5% is displayed as 100% (Closed)" href="https://www.redmine.org/issues/27848">#27848</a> where a different approach was chosen to fix nearly the same problem, so it would be nice to have a bit of feedback from the Redmine veterans, too.</p> Redmine - Defect #30949: Roadmap shows 100%, but one of its tasks is still set to 90%https://www.redmine.org/issues/30949?journal_id=905052019-03-01T17:13:42ZBernhard Rohloff
<ul><li><strong>File</strong> <a href="/attachments/22541">fix_rounding_of_progress_bar.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22541/fix_rounding_of_progress_bar.diff">fix_rounding_of_progress_bar.diff</a> added</li><li><strong>File</strong> <a href="/attachments/22542">show_correct_progress_values.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22542/show_correct_progress_values.diff">show_correct_progress_values.diff</a> added</li></ul><p>Just split up my previous patch and made rounding similar to <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: The progress exceeding 99.5% is displayed as 100% (Closed)" href="https://www.redmine.org/issues/27848">#27848</a>.<br />I think that's the better way.</p> Redmine - Defect #30949: Roadmap shows 100%, but one of its tasks is still set to 90%https://www.redmine.org/issues/30949?journal_id=908362019-03-20T09:14:41ZBernhard Rohloff
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/27848">Defect #27848</a>: The progress exceeding 99.5% is displayed as 100%</i> added</li></ul> Redmine - Defect #30949: Roadmap shows 100%, but one of its tasks is still set to 90%https://www.redmine.org/issues/30949?journal_id=909052019-03-24T08:10:00ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul> Redmine - Defect #30949: Roadmap shows 100%, but one of its tasks is still set to 90%https://www.redmine.org/issues/30949?journal_id=909072019-03-24T09:22:40ZMarius BĂLTEANU
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/90907/diff?detail_id=73091">diff</a>)</li></ul> Redmine - Defect #30949: Roadmap shows 100%, but one of its tasks is still set to 90%https://www.redmine.org/issues/30949?journal_id=909092019-03-24T12:01:34ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul><p><a class="user active" href="https://www.redmine.org/users/12917">Bernhard Ganslmeier</a>, I've reviewed your patches from note-3 and your fixes look good to me.</p>
<p>I've created a test as well to be applied on top of your patches. The patch can be found <a href="https://gitlab.com/marius-balteanu/redmine/commit/5f521297a45a7890b4af653b9f4f876f774f34a4.diff" class="external">here</a>.<br />Tests pass: <a class="external" href="https://gitlab.com/marius-balteanu/redmine/-/jobs/183120442">https://gitlab.com/marius-balteanu/redmine/-/jobs/183120442</a></p> Redmine - Defect #30949: Roadmap shows 100%, but one of its tasks is still set to 90%https://www.redmine.org/issues/30949?journal_id=910402019-03-31T21:51:59ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li></ul> Redmine - Defect #30949: Roadmap shows 100%, but one of its tasks is still set to 90%https://www.redmine.org/issues/30949?journal_id=924382019-06-20T06:29:56ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Patch and test committed, thanks to both of you.</p>