https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-06-12T06:22:15ZRedmineRedmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=923332019-06-12T06:22:15ZMarius BĂLTEANU
<ul></ul><p>There is a failing test: <a class="external" href="https://gitlab.com/redmine-org/redmine/-/jobs/229555710">https://gitlab.com/redmine-org/redmine/-/jobs/229555710</a></p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=923412019-06-13T07:07:25ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/23296">0001-Update-rouge-to-3.4.1.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23296/0001-Update-rouge-to-3.4.1.patch">0001-Update-rouge-to-3.4.1.patch</a> added</li><li><strong>Subject</strong> changed from <i>Update Rouge to 3.4.0</i> to <i>Update Rouge to 3.4.1</i></li></ul><p>Same fail with 3.4.1: <a class="external" href="https://gitlab.com/redmine-org/redmine/-/jobs/230187783">https://gitlab.com/redmine-org/redmine/-/jobs/230187783</a></p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=923422019-06-13T07:20:22ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/23297">31556-update-test.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23297/31556-update-test.patch">31556-update-test.patch</a> added</li></ul><p>This is due to the change <a class="external" href="https://github.com/rouge-ruby/rouge/pull/1165/">https://github.com/rouge-ruby/rouge/pull/1165/</a>. Rouge changed the CSS class for quotation marks in 3.4.0, so we can simply update the test.</p>
<p>By the way, how about delivering this in 4.1.0 instead of 4.2.0?</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=923462019-06-13T08:02:58ZMarius BĂLTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>This is due to the change <a class="external" href="https://github.com/rouge-ruby/rouge/pull/1165/">https://github.com/rouge-ruby/rouge/pull/1165/</a>. Rouge changed the CSS class for quotation marks in 3.4.0, so we can simply update the test.</p>
<p>By the way, how about delivering this in 4.1.0 instead of 4.2.0?</p>
</blockquote>
<p>Now that 3.4.1 is out with a hot fix, I think it is safe.</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=923492019-06-13T08:22:20ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>4.2.0</i> to <i>4.1.0</i></li></ul><p>Setting the target version to 4.1.0.</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=923632019-06-16T10:47:06ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li></ul><p>Committed the patch. Thanks.</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=926012019-06-26T01:00:20ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update Rouge to 3.4.1</i> to <i>Update Rouge to 3.5.1</i></li><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>Rouge 3.5.1 has been released on July 25th.</p>
<p>It passed all the tests. I think we can update Rouge to 3.5.1.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/Gemfile b/Gemfile
index ecd3bd150..4b7350e40 100644
</span><span class="gd">--- a/Gemfile
</span><span class="gi">+++ b/Gemfile
</span><span class="p">@@ -3,7 +3,7 @@</span> source 'https://rubygems.org'
gem "bundler", ">= 1.5.0"
gem "rails", "5.2.3"
<span class="gd">-gem "rouge", "~> 3.4.1"
</span><span class="gi">+gem "rouge", "~> 3.5.1"
</span> gem "request_store", "1.0.5"
gem "mini_mime", "~> 1.0.1"
gem "actionpack-xml_parser"
</code></pre> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=926112019-06-26T08:19:52ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Updated Rouge to 3.5.1 in <a class="changeset" title="Update Rouge to 3.5.1 (#31556)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18319">r18319</a>.</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=929522019-08-04T19:53:00ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/23569">0001-Bump-rouge-to-3.7.0.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23569/0001-Bump-rouge-to-3.7.0.patch">0001-Bump-rouge-to-3.7.0.patch</a> added</li><li><strong>Subject</strong> changed from <i>Update Rouge to 3.5.1</i> to <i>Update Rouge to 3.7.0</i></li><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>Rouge 3.6.0 and 3.7.0 Changelog: <a class="external" href="https://github.com/rouge-ruby/rouge/blob/master/README.md">https://github.com/rouge-ruby/rouge/blob/master/README.md</a></p>
<p>Tests pass: <a class="external" href="https://gitlab.com/redmine-org/redmine/pipelines/74619202">https://gitlab.com/redmine-org/redmine/pipelines/74619202</a></p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=929552019-08-05T00:02:30ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Rouge 3.6.0 and 3.7.0 Changelog: <a class="external" href="https://github.com/rouge-ruby/rouge/blob/master/README.md">https://github.com/rouge-ruby/rouge/blob/master/README.md</a></p>
<p>Tests pass: <a class="external" href="https://gitlab.com/redmine-org/redmine/pipelines/74619202">https://gitlab.com/redmine-org/redmine/pipelines/74619202</a></p>
</blockquote>
<p>Committed the patch. Thanks.</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=931062019-08-14T05:05:27ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update Rouge to 3.7.0</i> to <i>Update Rouge to 3.8.0</i></li><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>Rouge 3.8.0 has been released on 2019-08-07.<br /><a class="external" href="https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md#version-380-2019-08-07">https://github.com/rouge-ruby/rouge/blob/master/CHANGELOG.md#version-380-2019-08-07</a></p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/Gemfile b/Gemfile
index 4dc35ee83..e7ba3f4ae 100644
</span><span class="gd">--- a/Gemfile
</span><span class="gi">+++ b/Gemfile
</span><span class="p">@@ -3,7 +3,7 @@</span> source 'https://rubygems.org'
gem "bundler", ">= 1.5.0"
gem "rails", "5.2.3"
<span class="gd">-gem "rouge", "~> 3.7.0"
</span><span class="gi">+gem "rouge", "~> 3.8.0"
</span> gem "request_store", "1.0.5"
gem "mini_mime", "~> 1.0.1"
gem "actionpack-xml_parser"
<span class="gh">diff --git a/test/unit/lib/redmine/syntax_highlighting/rouge_test.rb b/test/unit/lib/redmine/syntax_highlighting/rouge_test.rb
index 16387966c..7df35ca64 100644
</span><span class="gd">--- a/test/unit/lib/redmine/syntax_highlighting/rouge_test.rb
</span><span class="gi">+++ b/test/unit/lib/redmine/syntax_highlighting/rouge_test.rb
</span><span class="p">@@ -24,7 +24,7 @@</span> class Redmine::SyntaxHighlighting::RougeTest < ActiveSupport::TestCase
to_test = {
'application.js' => true,
'Gemfile' => true,
<span class="gd">- 'AUTOEXEC.BAT' => false, # Rouge does not support BAT files
</span><span class="gi">+ 'HELLO.CBL' => false, # Rouge does not support COBOL
</span> 'HELLO.C' => true
}
to_test.each do |filename, expected|
</code></pre> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=931072019-08-14T05:24:26ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Updated Rouge to 3.8.0 in <a class="changeset" title="Update Rouge to 3.8.0 (#31556). Patch by Go MAEDA." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18369">r18369</a>.</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=932602019-08-21T01:16:36ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update Rouge to 3.8.0</i> to <i>Update Rouge to 3.9.0</i></li></ul><p>Updated Rouge to 3.9.0 in <a class="changeset" title="Update Rouge to 3.9.0 (#31556)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18382">r18382</a>.</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=934792019-09-04T00:40:42ZGo MAEDA
<ul></ul><p>Updated Rouge to 3.10.0 in <a class="changeset" title="Update Rouge to 3.10.0 (#31556)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18424">r18424</a>.</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=934802019-09-04T00:41:36ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update Rouge to 3.9.0</i> to <i>Update Rouge to 3.10.0</i></li></ul> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=938152019-09-19T16:08:10ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update Rouge to 3.10.0</i> to <i>Update Rouge to 3.11.0</i></li></ul><p>Updated Rouge to 3.11.0 in <a class="changeset" title="Update Rouge to 3.11.0 (#31556)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18482">r18482</a>.</p> Redmine - Patch #31556: Update Rouge to 3.12.0https://www.redmine.org/issues/31556?journal_id=943742019-10-17T14:48:20ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update Rouge to 3.11.0</i> to <i>Update Rouge to 3.12.0</i></li></ul><p>Updated Rouge to 3.12.0 in <a class="changeset" title="Update Rouge to 3.12.0 (#31556)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18710">r18710</a>.</p>