https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-10-06T04:09:04ZRedmineRedmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=942102019-10-06T04:09:04ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/24073">32116-20191006@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24073/32116-20191006@2x.png">32116-20191006@2x.png</a> added</li><li><strong>File</strong> <a href="/attachments/24074">32116.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24074/32116.patch">32116.patch</a> added</li></ul><p>+1<br />The theme is important information to investigate UI issues. Here is a patch to add Setting.ui_theme to admin/info page.</p>
<p><img src="https://www.redmine.org/attachments/download/24073/32116-20191006@2x.png" srcset="https://www.redmine.org/attachments/download/24073/32116-20191006@2x.png 2x" style="width: 518px;border: 1px solid #ccc;" alt="" /></p> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=942522019-10-07T20:23:17ZAleksandar Pavic
<ul><li><strong>File</strong> <a href="/attachments/24086">331.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24086/331.patch">331.patch</a> added</li></ul><p>Thanks @Go MAEDA, I've followed your code, and delivered patch for 3.3.1 I guess it will work on other 3.x versions as well...</p> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=942532019-10-07T20:43:27ZMarius BĂLTEANU
<ul></ul><p>I'm not sure if it's a good idea to show the configured "Theme" in the information page because the setting is already available in "settings?tab=display". For me, Information page is more about the system, environment, framework and tools which are not configurable in the admin. Also, why display only "Theme" and no other settings as well?</p> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=942552019-10-07T21:11:46ZAleksandar Pavic
<ul></ul><p>Theme is important to investigate UI issues, there are also some commercially available themes, which use white text on white background for example, and people are posting "info" data on sites like stackoverflow, or forums, IRC chats, asking for help, and we can't reproduce their issues, since issues are theme related.</p> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=1035602021-08-05T05:33:01ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/35686">Feature #35686</a>: Add configured theme and whether it includes JavaScript to Redmine::Info.</i> added</li></ul> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=1035702021-08-05T23:55:23ZMarius BĂLTEANU
<ul></ul><p>Indeed, there were a lot of cases when this information would help us investigate more quickly the issues reported by the users. I think we should add this info.</p> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=1035712021-08-05T23:55:38ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=1035832021-08-06T21:08:17ZMischa The Evil
<ul><li><strong>File</strong> <a href="/attachments/27855">2021-08-05_01-36-12.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27855/2021-08-05_01-36-12.png">2021-08-05_01-36-12.png</a> added</li><li><strong>File</strong> <a href="/attachments/27856">0001-Add-current-theme-and-whether-it-includes-JavaScript.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27856/0001-Add-current-theme-and-whether-it-includes-JavaScript.patch">0001-Add-current-theme-and-whether-it-includes-JavaScript.patch</a> added</li><li><strong>Subject</strong> changed from <i>Display used theme on information page</i> to <i>Add configured theme to Redmine::Info</i></li></ul><p>A slightly alternative, more extensive, approach was posted by me as an up-to-date patch in another, duplicating issue:</p>
<p>Mischa The Evil wrote in <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add configured theme and whether it includes JavaScript to Redmine::Info. (Closed)" href="https://www.redmine.org/issues/35686">#35686</a>:</p>
<blockquote>
<p>Given that a fair amount of (UI) issues are caused by a third-party theme (see e.g. recently closed <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: mouse-over creates only empty bubbles covering other content, instead of giving additional inform... (Closed)" href="https://www.redmine.org/issues/35258">#35258</a> and <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: After updating from version 3.3.2 to 4.1.1 Gantt chart has broken (Closed)" href="https://www.redmine.org/issues/35534">#35534</a>), it would be really helpful if information about the configured theme and whether it includes JavaScript is added to <code>Redmine::Info</code>.</p>
<p>Example:</p>
<p><img src="https://www.redmine.org/attachments/download/27855/2021-08-05_01-36-12.png" alt="" /></p>
<p>I'll leave a patch against current trunk.</p>
</blockquote>
<p>I'll modify the subject of this issue because <code>Redmine::Info.enviroment</code> is also (supposed to be?) displayed as the output of the 'rake/rails about' command (see <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21131/entry/trunk/bin/about#L6">source:/trunk/bin/about@21131#L6</a>).</p> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=1035862021-08-06T21:12:55ZMischa The Evil
<ul><li><strong>Related to</strong> deleted (<i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/35686">Feature #35686</a>: Add configured theme and whether it includes JavaScript to Redmine::Info.</i>)</li></ul> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=1035882021-08-06T21:12:57ZMischa The Evil
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/35686">Feature #35686</a>: Add configured theme and whether it includes JavaScript to Redmine::Info.</i> added</li></ul> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=1036832021-08-12T04:38:15ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>5.0.0</i></li></ul><p>Setting the target version to 5.0.0.</p> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=1048232021-12-12T04:15:59ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch after fixing RuboCop offenses by running "rubocop -a". Thank you.</p>
<pre>
$ bundle exec rubocop -a lib/redmine/info.rb
Inspecting 1 file
W
Offenses:
lib/redmine/info.rb:24:9: C: [Corrected] Style/MultilineIfModifier: Favor a normal unless-statement over a modifier clause in a multiline statement.
theme_js = (Redmine::Themes.theme(Setting.ui_theme).javascripts.include?('theme') ? ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/redmine/info.rb:24:22: C: [Corrected] Style/MultilineTernaryOperator: Avoid multi-line ternary operators, use if or unless instead.
theme_js = (Redmine::Themes.theme(Setting.ui_theme).javascripts.include?('theme') ? ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/redmine/info.rb:25:24: C: [Corrected] Style/MultilineTernaryOperator: Avoid multi-line ternary operators, use if or unless instead.
theme_js = (Redmine::Themes.theme(Setting.ui_theme).javascripts.include?('theme') ? ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/redmine/info.rb:26:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -21) spaces for indentation.
' (includes JavaScript)'
^^^^^^^^^^^^^^^^^^^^^
lib/redmine/info.rb:27:1: C: [Corrected] Layout/ElseAlignment: Align else with if.
else
^^^^
lib/redmine/info.rb:28:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -21) spaces for indentation.
'' ...
^^
lib/redmine/info.rb:28:24: C: [Corrected] Style/RedundantInterpolation: Prefer to_s over string interpolation.
theme_string = "#{theme + theme_js.to_s}"
^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/redmine/info.rb:29:1: W: [Corrected] Layout/EndAlignment: end at 29, 0 is not aligned with if at 25, 23.
end
^^^
1 file inspected, 8 offenses detected, 8 offenses corrected
</pre> Redmine - Feature #32116: Add configured theme to Redmine::Infohttps://www.redmine.org/issues/32116?journal_id=1063542022-04-11T06:24:42ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/36932">Defect #36932</a>: Handle nil return of Redmine::Themes.theme(Setting.ui_theme) in Redmine::Info.environment</i> added</li></ul>