https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-10-11T05:33:12ZRedmineRedmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=943132019-10-11T05:33:12ZAnonymous
<ul></ul><p>+1 ofc ;-)</p> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=943222019-10-11T19:56:40ZMischa The Evil
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>[...] Currently, you need to click twice to download the file [...]</p>
</blockquote>
<p>I am not able to test this currently, but what about right-click -> save as? Doesn't that work in any way?</p> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=943232019-10-12T00:08:01ZGo MAEDA
<ul></ul><p>Mischa The Evil wrote:</p>
<blockquote>
<p>I am not able to test this currently, but what about right-click -> save as? Doesn't that work in any way?</p>
</blockquote>
<p>Unfortunately, it does not work. It saves the HTML content of the preview page (AttachmentsController#show).</p> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=948132019-11-07T05:07:55ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/24298">32240_add_download_button.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24298/32240_add_download_button.patch">32240_add_download_button.patch</a> added</li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>If the column has download buttons, you can reduce an extra one click.</p>
</blockquote>
<p>Added download buttons to "Files" column. I attached a patch.</p> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=948222019-11-07T20:53:01ZMarius BÄ‚LTEANU
<ul></ul><p>In my opinion, there are too many icons in the listing which make the "Files" column more obvious than the other columns (my first reaction is look on that column). If we really want to have the download links available in the listing, what about of showing the icon only on hover?</p> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=948232019-11-08T01:01:47ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/24302">32240_add_download_button_v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24302/32240_add_download_button_v2.patch">32240_add_download_button_v2.patch</a> added</li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>In my opinion, there are too many icons in the listing which make the "Files" column more obvious than the other columns (my first reaction is look on that column). If we really want to have the download links available in the listing, what about of showing the icon only on hover?</p>
</blockquote>
<p>Thank you for your feedback. Fixed to show the download icon only when hovering.</p> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=948342019-11-09T06:55:23ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=959692020-01-30T01:53:23ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.2.0</i></li></ul><p>LGTM. Setting the target version to 4.2.0.</p> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=960792020-02-04T06:30:05ZGo MAEDA
<ul></ul><p>The patch breaks a test.</p>
<pre>
F
Failure:
AttachmentFieldFormatTest#test_create_with_attachment [/Users/maeda/redmines/trunk/test/integration/lib/redmine/field_format/attachment_format_test.rb:85]:
Expected: 1
Actual: 2
bin/rails test test/integration/lib/redmine/field_format/attachment_format_test.rb:54
</pre> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=961072020-02-05T01:57:23ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/24767">32240_add_download_button_v3.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24767/32240_add_download_button_v3.patch">32240_add_download_button_v3.patch</a> added</li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>The patch breaks a test.</p>
<p>[...]</p>
</blockquote>
<p>Sorry, I fixed the test as follows.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/test/integration/lib/redmine/field_format/attachment_format_test.rb b/test/integration/lib/redmine/field_format/attachment_format_test.rb
index 61f439894..ccb33a9b6 100644
</span><span class="gd">--- a/test/integration/lib/redmine/field_format/attachment_format_test.rb
</span><span class="gi">+++ b/test/integration/lib/redmine/field_format/attachment_format_test.rb
</span><span class="p">@@ -81,7 +81,7 @@</span> class AttachmentFieldFormatTest < Redmine::IntegrationTest
assert_response :success
# link to the attachment
<span class="gd">- link = css_select(".cf_#{@field.id} .value a")
</span><span class="gi">+ link = css_select(".cf_#{@field.id} .value a:not(.icon-download)")
</span> assert_equal 1, link.size
assert_equal "testfile.txt", link.text
</code></pre> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=961112020-02-05T06:48:58ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/24769">32240_add_download_button_v4.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24769/32240_add_download_button_v4.patch">32240_add_download_button_v4.patch</a> added</li></ul><p>I have slightly updated the patch as follows:</p>
<ul>
<li>Fixed a "Layout/ArgumentAlignment" RuboCop warning in app/helpers/application_helper.rb</li>
<li>Changed the CSS to hide the icon from "<code>display: none;</code>" from "<code>visibility: hide;</code>" in order to prevent the table cell width from changing on mouse hover</li>
</ul> Redmine - Feature #32240: Add download buttons in Files columns of the issues listhttps://www.redmine.org/issues/32240?journal_id=961362020-02-06T14:25:14ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you for your contribution.</p>