https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-02-13T11:02:18ZRedmineRedmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=962492020-02-13T11:02:18ZSamuel Monsarrat
<ul></ul><p>We have the same problem with a GIT or SVN backend.</p>
<p>It looks like the page rendering crashes while building a DIFF of a Javascript file (something to do with syntax highlighting?).<br />All other file types seem ok:</p>
<p>Example : <br /><a class="external" href="https://source.scenari.software/projects/dev-core/repository/git/revisions/300fb80a966ae09c1ac7c8f7a8104a31dde93b72">https://source.scenari.software/projects/dev-core/repository/git/revisions/300fb80a966ae09c1ac7c8f7a8104a31dde93b72</a><br />The simple view of the Javascript file is ok : <br /><a class="external" href="https://source.scenari.software/projects/dev-core/repository/git/revisions/300fb80a966ae09c1ac7c8f7a8104a31dde93b72/entry/Wsp_Modeling/spaces/gen/modelBuilder/bs/_common/sm/webSiteGenerator/scDynUiMgr.js">https://source.scenari.software/projects/dev-core/repository/git/revisions/300fb80a966ae09c1ac7c8f7a8104a31dde93b72/entry/Wsp_Modeling/spaces/gen/modelBuilder/bs/_common/sm/webSiteGenerator/scDynUiMgr.js</a><br />But the diff view is not : <br /><a class="external" href="https://source.scenari.software/projects/dev-core/repository/git/revisions/300fb80a966ae09c1ac7c8f7a8104a31dde93b72/diff/Wsp_Modeling/spaces/gen/modelBuilder/bs/_common/sm/webSiteGenerator/scDynUiMgr.js">https://source.scenari.software/projects/dev-core/repository/git/revisions/300fb80a966ae09c1ac7c8f7a8104a31dde93b72/diff/Wsp_Modeling/spaces/gen/modelBuilder/bs/_common/sm/webSiteGenerator/scDynUiMgr.js</a></p> Redmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=963342020-02-19T08:57:42ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li></ul> Redmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=963362020-02-19T09:36:20ZGuillermo ML
<ul><li><strong>File</strong> <a href="/attachments/24859">defect.32449-redmine_3.4.4.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24859/defect.32449-redmine_3.4.4.png">defect.32449-redmine_3.4.4.png</a> added</li><li><strong>File</strong> <a href="/attachments/24860">defect.32449-redmine_4.0.4.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24860/defect.32449-redmine_4.0.4.png">defect.32449-redmine_4.0.4.png</a> added</li></ul><p>Same with our Mercurial SCM.</p>
<a name="version-344stable-gt-works-fine"></a>
<h2 >version 3.4.4.stable --> works fine<a href="#version-344stable-gt-works-fine" class="wiki-anchor">¶</a></h2>
<p><img src="https://www.redmine.org/attachments/download/24859/defect.32449-redmine_3.4.4.png" title="No error in 3.4.4" alt="No error in 3.4.4" style="width: 70%;" alt="" /></p>
<a name="version-404stable-gt-no-styles-and-the-menu-disappears"></a>
<h2 >version 4.0.4.stable --> no styles and the menu disappears<a href="#version-404stable-gt-no-styles-and-the-menu-disappears" class="wiki-anchor">¶</a></h2>
<p><img src="https://www.redmine.org/attachments/download/24860/defect.32449-redmine_4.0.4.png" title="Neither styles nor menu in 4.0.4" alt="Neither styles nor menu in 4.0.4" style="width: 70%;" alt="" /></p> Redmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=963762020-02-21T02:44:35ZMizuki ISHIKAWA
<ul></ul><p>When displaying the js file, base.html.erb was not used as the layout file.<br />Specifying an explicit layout file as shown below should solve the problem.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/app/controllers/repositories_controller.rb b/app/controllers/repositories_controller.rb
index 269bc70a0..8350b4d48 100644
</span><span class="gd">--- a/app/controllers/repositories_controller.rb
</span><span class="gi">+++ b/app/controllers/repositories_controller.rb
</span><span class="p">@@ -269,7 +269,7 @@</span> class RepositoriesController < ApplicationController
@changeset = @repository.find_changeset_by_name(@rev)
@changeset_to = @rev_to ? @repository.find_changeset_by_name(@rev_to) : nil
@diff_format_revisions = @repository.diff_format_revisions(@changeset, @changeset_to)
<span class="gd">- render :diff, :formats => :html
</span><span class="gi">+ render :diff, :formats => :html, :layout => 'base.html.erb'
</span> end
end
</code></pre> Redmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=963812020-02-21T05:08:18ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/30850">Defect #30850</a>: Unified diff link broken on specific file/revision diff view</i> added</li></ul> Redmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=963862020-02-21T08:11:25ZGuillermo ML
<ul></ul><p>After applying Mizuki ISHIKAWA's change and restarting Redmine, <em>View differences</em> page works flawlessly with .js files.</p> Redmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=963952020-02-21T13:43:47ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>4.0.7</i></li></ul><p>Setting the target version to 4.0.7.</p> Redmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=964062020-02-24T02:43:48ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>diff display issue for js files in git</i> to <i>Diff view for .js files in repositories is broken</i></li></ul> Redmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=964452020-02-27T01:22:38ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you all for reporting and fixing this issue.</p> Redmine - Defect #32449: Diff view for .js files in repositories is brokenhttps://www.redmine.org/issues/32449?journal_id=1077682022-09-01T06:53:58ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/37626">Defect #37626</a>: Diff of a javascript file in repository module is not displayed with layout </i> added</li></ul>