https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-01-28T03:25:46ZRedmineRedmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=959202020-01-28T03:25:46ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/22481">Feature #22481</a>: Show thumbnails for PDF attachments</i> added</li></ul> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=983762020-06-26T01:54:12ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/33283">Defect #33283</a>: Thumbnail support for PDF attachments may not be detected</i> added</li></ul> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=983782020-06-26T01:57:07ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>Redmine 4.1.2 will support a new setting <code>gs_command</code> in config/configuration.yml (<a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Thumbnail support for PDF attachments may not be detected (Closed)" href="https://www.redmine.org/issues/33283">#33283</a>). You can set the command name such as "gswin64c" and "gswin32c".</p> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1016972021-03-31T09:56:19ZSteve Zhou
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Redmine 4.1.2 will support a new setting <code>gs_command</code> in config/configuration.yml (<a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Thumbnail support for PDF attachments may not be detected (Closed)" href="https://www.redmine.org/issues/33283">#33283</a>). You can set the command name such as "gswin64c" and "gswin32c".</p>
</blockquote>
<p>I checked this new setting again, please find the result as below.</p>
<p>[Environment]<br />OS: Windows 10 x64<br />Redmine:4.2.0<br />Imagemagick: 6.9.8<br />Ghostscript: 9.21</p>
<p>[Case 1]<br />Set gs_command in config/configuration.yml<br />Result: ImageMagick PDF support available (optional) in Information page is not checked.</p>
<p>[Case 2]<br />No setting gs_command in config/configuration.yml<br />But change /lib/redmine/thumbnail.rb with the code "@gs_available = system("gswin64c -version > nul 2>&1") rescue false" <br />Result: ImageMagick PDF support available (optional) in Information page is checked and convert cmd is working in windows.</p>
<p>So, could you please change the code in /lib/redmine/thumbnail.rb, then the gs_command can also be worked in windows.<br />If gs_command is set, there is no need to judge operating system environment.</p>
<pre><code>begin<br /> `#{shell_quote GS_BIN} -version`<br /> @gs_available = $?.success?<br /> rescue<br /> @gs_available = false<br /> end</code></pre> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1016992021-03-31T13:41:17ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/27017">pdf-thumbnail-win.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27017/pdf-thumbnail-win.patch">pdf-thumbnail-win.patch</a> added</li><li><strong>Status</strong> changed from <i>Closed</i> to <i>New</i></li></ul><p>Steve Zhou, thank you for your feedback.</p>
<p>Could you try the attached patch <strong>without</strong> setting imagemagick_convert_command in configuration.yml? I think it should successfully show PDF thumbnails on Windows.</p>
<p>After applying the patch, Redmine will determine whether it should use gswin64c or gswin32c if you are running Redmine on Windows.</p> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1017052021-04-01T03:57:17ZSteve Zhou
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Steve Zhou, thank you for your feedback.</p>
<p>Could you try the attached patch <strong>without</strong> setting imagemagick_convert_command in configuration.yml? I think it should successfully show PDF thumbnails on Windows.</p>
<p>After applying the patch, Redmine will determine whether it should use gswin64c or gswin32c if you are running Redmine on Windows.</p>
</blockquote>
<p>MAEDA-san, I tested the patch, it can successfully show PDF thumbnails on Windows with setting imagemagick_convert_command and gs_command in configuration.yml.<br />But without the setting in configuration.yml, (instead, configuring path in environment variables), it cannot show PDF thumbnails.</p> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1017062021-04-01T04:14:45ZGo MAEDA
<ul></ul><p>Steve Zhou wrote:</p>
<blockquote>
<p>MAEDA-san, I tested the patch, it can successfully show PDF thumbnails on Windows with setting imagemagick_convert_command and gs_command in configuration.yml.<br />But without the setting in configuration.yml, (instead, configuring path in environment variables), it cannot show PDF thumbnails.</p>
</blockquote>
<p>Zhou先生, thank you for testing the patch.</p>
<p>As you wrote, now I understood that rejecting Windows is not necessary. I will try to make it possible to display PDF thumbnails on Windows in a near future release.</p> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1017102021-04-01T06:47:58ZSteve Zhou
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>Steve Zhou wrote:</p>
<blockquote>
<p>MAEDA-san, I tested the patch, it can successfully show PDF thumbnails on Windows with setting imagemagick_convert_command and gs_command in configuration.yml.<br />But without the setting in configuration.yml, (instead, configuring path in environment variables), it cannot show PDF thumbnails.</p>
</blockquote>
<p>Zhou先生, thank you for testing the patch.</p>
<p>As you wrote, now I understood that rejecting Windows is not necessary. I will try to make it possible to display PDF thumbnails on Windows in a near future release.</p>
</blockquote>
<p>Well noted with thanks.</p> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1023572021-05-07T06:38:35ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1024642021-05-16T02:41:32ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/27371">pdf-thumbnail-win-v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27371/pdf-thumbnail-win-v2.patch">pdf-thumbnail-win-v2.patch</a> added</li></ul> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1024652021-05-16T02:48:01ZGo MAEDA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Feature</i></li><li><strong>Subject</strong> changed from <i>Let's show PDF thumbnails on Windows.</i> to <i>PDF thumbnails support on Windows</i></li><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>5.0.0</i></li></ul><p>Setting the target version to 5.0.0.</p> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1025332021-05-23T06:40:32ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/27404">pdf-thumbnail-win-v3.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27404/pdf-thumbnail-win-v3.patch">pdf-thumbnail-win-v3.patch</a> added</li></ul><p>Removed the code for 32bit Windows from the patch.</p>
<p>I think there are very few people running Redmine on 32bit Windows now, so there is little need to add a method that checks for 32bit Windows to lib/redmine/platform.rb.</p>
<p>If you are using the 32bit version of gswin32c.exe, you can still generate PDF thumbnails by setting gs_command in configuration.yml.</p> Redmine - Feature #32898: PDF thumbnails support on Windowshttps://www.redmine.org/issues/32898?journal_id=1025592021-05-25T02:36:42ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you all for your contribution.</p>