https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-01-29T22:14:08ZRedmineRedmine - Defect #32921: Rails 6: add header=present to csv testshttps://www.redmine.org/issues/32921?journal_id=959672020-01-29T22:14:08ZPavel Rosický
<ul><li><strong>File</strong> <a href="/attachments/24720">csvheaders2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24720/csvheaders2.patch">csvheaders2.patch</a> added</li></ul> Redmine - Defect #32921: Rails 6: add header=present to csv testshttps://www.redmine.org/issues/32921?journal_id=959832020-01-30T07:21:07ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/29914">Feature #29914</a>: Migrate to Rails 6.1 with Zeitwerk autoloading</i> added</li></ul> Redmine - Defect #32921: Rails 6: add header=present to csv testshttps://www.redmine.org/issues/32921?journal_id=960092020-01-31T08:38:37ZMarius BĂLTEANU
<ul></ul><p>Pavel, maybe you have a clue because I can't find or understand why <code>media_type</code> returns "text/csv; header=present" and not only <code>text/csv</code> as is explained <a href="https://github.com/rails/rails/blob/master/guides/source/upgrading_ruby_on_rails.md#actiondispatchresponsecontent_type-now-returns-the-content-type-header-without-modification" class="external">here</a>.</p> Redmine - Defect #32921: Rails 6: add header=present to csv testshttps://www.redmine.org/issues/32921?journal_id=960132020-01-31T10:27:04ZPavel Rosický
<ul></ul><p>yeah, because the documentation is obsolete, it was changed here <a class="external" href="https://github.com/rails/rails/pull/37017">https://github.com/rails/rails/pull/37017</a></p> Redmine - Defect #32921: Rails 6: add header=present to csv testshttps://www.redmine.org/issues/32921?journal_id=960192020-01-31T13:54:58ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/24746">0001-Rails-6-add-header-present-to-csv-tests.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24746/0001-Rails-6-add-header-present-to-csv-tests.patch">0001-Rails-6-add-header-present-to-csv-tests.patch</a> added</li><li><strong>Target version</strong> set to <i>5.0.0</i></li></ul><p>Pavel Rosický wrote:</p>
<blockquote>
<p>yeah, because the documentation is obsolete, it was changed here <a class="external" href="https://github.com/rails/rails/pull/37017">https://github.com/rails/rails/pull/37017</a></p>
</blockquote>
<p>Thanks, it's clear now. Your patches look good to me and the failing tests because of this are passing now. I'm attaching a merged version of your patches.</p> Redmine - Defect #32921: Rails 6: add header=present to csv testshttps://www.redmine.org/issues/32921?journal_id=966812020-03-09T22:05:03ZGo MAEDA
<ul><li><strong>Category</strong> set to <i>Rails support</i></li></ul> Redmine - Defect #32921: Rails 6: add header=present to csv testshttps://www.redmine.org/issues/32921?journal_id=1016602021-03-30T16:31:53ZMarius BĂLTEANU
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li></ul> Redmine - Defect #32921: Rails 6: add header=present to csv testshttps://www.redmine.org/issues/32921?journal_id=1016802021-03-31T06:24:56ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> deleted (<del><i>5.0.0</i></del>)</li></ul> Redmine - Defect #32921: Rails 6: add header=present to csv testshttps://www.redmine.org/issues/32921?journal_id=1017172021-04-01T14:59:55ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch as a part of <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Migrate to Rails 6.1 with Zeitwerk autoloading (Closed)" href="https://www.redmine.org/issues/29914">#29914</a>.</p>