https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-02-06T10:14:23ZRedmineRedmine - Defect #32959: Fix selected user on log time edit page when user has permissions to log time for another userhttps://www.redmine.org/issues/32959?journal_id=961282020-02-06T10:14:23Z
<ul></ul><p>missed the selected version, this applies to <code>4.1-stable</code></p> Redmine - Defect #32959: Fix selected user on log time edit page when user has permissions to log time for another userhttps://www.redmine.org/issues/32959?journal_id=961302020-02-06T12:47:40ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/3848">Feature #3848</a>: Permission to log time for another user</i> added</li></ul> Redmine - Defect #32959: Fix selected user on log time edit page when user has permissions to log time for another userhttps://www.redmine.org/issues/32959?journal_id=961322020-02-06T12:48:36ZGo MAEDA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li><li><strong>Affected version</strong> set to <i>4.1.0</i></li></ul> Redmine - Defect #32959: Fix selected user on log time edit page when user has permissions to log time for another userhttps://www.redmine.org/issues/32959?journal_id=961532020-02-07T19:06:11ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>4.1.1</i></li></ul> Redmine - Defect #32959: Fix selected user on log time edit page when user has permissions to log time for another userhttps://www.redmine.org/issues/32959?journal_id=961592020-02-08T20:38:27ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/24783">0001-Fix-selected-user-on-timelog-edit.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24783/0001-Fix-selected-user-on-timelog-edit.patch">0001-Fix-selected-user-on-timelog-edit.patch</a> added</li></ul><p>Thanks easter egg for detecting the issue.</p>
<p>I have attached a patch that fixes the code added in <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Permission to log time for another user (Closed)" href="https://www.redmine.org/issues/3848">#3848</a> and adds a test for this case. Regarding your fix from <code>app/helpers/application_helper.rb</code>, maybe it's better to cast both values <code>to_s</code>.</p> Redmine - Defect #32959: Fix selected user on log time edit page when user has permissions to log time for another userhttps://www.redmine.org/issues/32959?journal_id=961602020-02-08T20:46:29ZMarius BĂLTEANU
<ul><li><strong>Subject</strong> changed from <i>fix for selected user on timelogentry edit</i> to <i>Fix selected user on log time edit page when user has permissions to log time for another user</i></li><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li></ul><p>All tests pass: <a class="external" href="https://gitlab.com/redmine-org/redmine/pipelines/116202079">https://gitlab.com/redmine-org/redmine/pipelines/116202079</a></p> Redmine - Defect #32959: Fix selected user on log time edit page when user has permissions to log time for another userhttps://www.redmine.org/issues/32959?journal_id=961672020-02-09T00:27:36ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you.</p>