https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-03-23T08:49:53ZRedmineRedmine - Defect #33183: Unable to edit user or group that has custom fields with text formatting enabledhttps://www.redmine.org/issues/33183?journal_id=968992020-03-23T08:49:53ZGo MAEDA
<ul></ul><p>This is due to <a class="changeset" title="Inline auto complete for issue (#) in wiki-edit fields (#31989). Patch by Marius BALTEANU." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/18444">r18444</a>.</p> Redmine - Defect #33183: Unable to edit user or group that has custom fields with text formatting enabledhttps://www.redmine.org/issues/33183?journal_id=969002020-03-23T08:50:17ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/31989">Feature #31989</a>: Inline issue auto complete (#) in fields with text-formatting enabled</i> added</li></ul> Redmine - Defect #33183: Unable to edit user or group that has custom fields with text formatting enabledhttps://www.redmine.org/issues/33183?journal_id=969022020-03-23T09:04:28ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul> Redmine - Defect #33183: Unable to edit user or group that has custom fields with text formatting enabledhttps://www.redmine.org/issues/33183?journal_id=969032020-03-23T09:09:49ZGo MAEDA
<ul></ul><p>The following code fixes the issue.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/app/helpers/custom_fields_helper.rb b/app/helpers/custom_fields_helper.rb
index a6fbff9bd..26023ae94 100644
</span><span class="gd">--- a/app/helpers/custom_fields_helper.rb
</span><span class="gi">+++ b/app/helpers/custom_fields_helper.rb
</span><span class="p">@@ -86,7 +86,7 @@</span> module CustomFieldsHelper
data = {
:auto_complete => true,
:issues_url => auto_complete_issues_path(:project_id => custom_value.customized.project, :q => '')
<span class="gd">- } if custom_value.customized && custom_value.customized.project
</span><span class="gi">+ } if custom_value.customized && custom_value.customized.try(:project)
</span> end
custom_value.custom_field.format.edit_tag(
self,
</code></pre> Redmine - Defect #33183: Unable to edit user or group that has custom fields with text formatting enabledhttps://www.redmine.org/issues/33183?journal_id=969072020-03-23T17:24:25ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/25072">test_for_33183.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25072/test_for_33183.patch">test_for_33183.patch</a> added</li><li><strong>Assignee</strong> changed from <i>Marius BĂLTEANU</i> to <i>Go MAEDA</i></li><li><strong>Target version</strong> set to <i>4.1.1</i></li></ul><p>The fix looks good to me and I have attached a test case.</p>
<p>Thanks Go Maeda for detecting this issue.</p> Redmine - Defect #33183: Unable to edit user or group that has custom fields with text formatting enabledhttps://www.redmine.org/issues/33183?journal_id=969222020-03-24T13:00:01ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Cannot edit user if it has UserCustomField with text_formatting enabled</i> to <i>Unable to edit user or group that has custom fields with text formatting enabled</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch.</p>