https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292021-02-27T08:51:56ZRedmineRedmine - Patch #33337: Clean-up workflows controllerhttps://www.redmine.org/issues/33337?journal_id=1011182021-02-27T08:51:56ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul> Redmine - Patch #33337: Clean-up workflows controllerhttps://www.redmine.org/issues/33337?journal_id=1011462021-02-28T17:26:23ZMarius BĂLTEANU
<ul><li><strong>File</strong> <i>0001-Clean-up-workflows-controller.patch</i> added</li><li><strong>File</strong> <i>0002-Fix-route-name.patch</i> added</li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul><p>Thanks Vincent for the patch, I tried it yesterday and it looks great from my point of view.</p>
<p>I'm attaching a rebased version of the initial patch and a second patch that fixes to route name (<code>workflows_permissions_path</code> should be <code>permissions_workflows_path</code>). All the tests pass (<a class="external" href="https://gitlab.com/redmine-org/redmine/-/commit/4ef4ea5047323756a3241eea660e11a383ea7711">https://gitlab.com/redmine-org/redmine/-/commit/4ef4ea5047323756a3241eea660e11a383ea7711</a>) with both patches.</p>
<p>I'm going to review the tests in the following days.</p> Redmine - Patch #33337: Clean-up workflows controllerhttps://www.redmine.org/issues/33337?journal_id=1018062021-04-04T11:14:02ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0001-Clean-up-workflows-controller.patch</i></del>)</li></ul> Redmine - Patch #33337: Clean-up workflows controllerhttps://www.redmine.org/issues/33337?journal_id=1018072021-04-04T11:14:05ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0002-Fix-route-name.patch</i></del>)</li></ul> Redmine - Patch #33337: Clean-up workflows controllerhttps://www.redmine.org/issues/33337?journal_id=1018082021-04-04T11:15:03ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/27039">0002-Fix-route-name.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27039/0002-Fix-route-name.patch">0002-Fix-route-name.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27040">0001-Clean-up-workflows-controller.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27040/0001-Clean-up-workflows-controller.patch">0001-Clean-up-workflows-controller.patch</a> added</li><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>5.0.0</i></li></ul><p>Update the patches for current trunk, the tests still pass.</p>
<p>Setting target to <a class="version" href="https://www.redmine.org/versions/155">5.0.0</a>, I think it's a nice refactoring.</p> Redmine - Patch #33337: Clean-up workflows controllerhttps://www.redmine.org/issues/33337?journal_id=1019762021-04-13T09:01:49ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li></ul><p>Committed the patch. Thank you for your contribution.</p> Redmine - Patch #33337: Clean-up workflows controllerhttps://www.redmine.org/issues/33337?journal_id=1019772021-04-13T09:02:54ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Clean-up Workflows Controller</i> to <i>Clean-up workflows controller</i></li></ul> Redmine - Patch #33337: Clean-up workflows controllerhttps://www.redmine.org/issues/33337?journal_id=1019832021-04-13T09:33:24ZVincent Robert
<ul></ul><p>Thank you for updating and committing this patch.</p>