https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-05-16T03:17:04ZRedmineRedmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=978342020-05-16T03:17:04ZGo MAEDA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li><li><strong>Category</strong> set to <i>Issues</i></li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=978352020-05-16T03:23:06ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li></ul> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1001562020-12-12T11:15:30ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1002642020-12-21T20:58:19ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/26452">0001-Take-into-account-the-setting-Setting.cross_project_.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26452/0001-Take-into-account-the-setting-Setting.cross_project_.patch">0001-Take-into-account-the-setting-Setting.cross_project_.patch</a> added</li><li><strong>Subject</strong> changed from <i>Subtasks' project on new issue form</i> to <i>Show only valid projects on issue form when the issue is a subtask</i></li><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li></ul><p>I made a patch (inspired from Dmitry's work) that implements this feature.</p>
<p>The patch also changes my initial implementation (<a class="changeset" title="Allow selecting subprojects on new issue form (#12704). Patch by Marius BALTEANU." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17217">r17217</a>) in order to move the logic from model to issue helper.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1003822020-12-30T04:14:23ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.2.0</i></li></ul><p>Setting the target version to 4.2.0.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1003932021-01-01T00:59:29ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1007072021-01-27T04:52:36ZYuichi HARADA
<ul></ul><p>When the new issue input form is displayed with "Projects(#top-menu) > Issues > New issue", the projects that can be selected are narrowed down even though the issue to be created is not a subtask. I think it's due to <a href="https://www.redmine.org/projects/redmine/repository/revisions/20701/diff/trunk/app/views/issues/_form.html.erb" class="external">app/views/issues/_form.html.erb@20701</a>, is this appropriate?</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1007192021-01-27T16:56:20ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li><li><strong>Assignee</strong> changed from <i>Go MAEDA</i> to <i>Marius BĂLTEANU</i></li></ul><p>Yuichi HARADA wrote:</p>
<blockquote>
<p>When the new issue input form is displayed with "Projects(#top-menu) > Issues > New issue", the projects that can be selected are narrowed down even though the issue to be created is not a subtask. I think it's due to <a href="https://www.redmine.org/projects/redmine/repository/revisions/20701/diff/trunk/app/views/issues/_form.html.erb" class="external">app/views/issues/_form.html.erb@20701</a>, is this appropriate?</p>
</blockquote>
<p>Let me take a look.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1007222021-01-28T06:51:46ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/26585">0001-Fix-project-selector-on-global-new-issue-page-not-sh.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26585/0001-Fix-project-selector-on-global-new-issue-page-not-sh.patch">0001-Fix-project-selector-on-global-new-issue-page-not-sh.patch</a> added</li></ul><p>Indeed, the project selector contains only descendant projects of the selected project. The attached patch should fix this, Yuichi, please test with it.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1007232021-01-28T07:10:48ZYuichi HARADA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Indeed, the project selector contains only descendant projects of the selected project. The attached patch should fix this, Yuichi, please test with it.</p>
</blockquote>
<p>Thanks for creating a patch. I will test it, so please wait for a while.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1007272021-01-29T00:54:45ZYuichi HARADA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Indeed, the project selector contains only descendant projects of the selected project. The attached patch should fix this, Yuichi, please test with it.</p>
</blockquote>
<p>Marius, I confirmed your patch and test. I think it's good.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1007492021-01-31T20:29:30ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> changed from <i>Marius BĂLTEANU</i> to <i>Go MAEDA</i></li></ul> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1007552021-02-01T04:22:55ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Committed the patch <a class="attachment" href="https://www.redmine.org/attachments/26585">0001-Fix-project-selector-on-global-new-issue-page-not-sh.patch</a> in <a class="changeset" title="Fix project selector on global new issue page not showing all visible projects (#33419). Patch b..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/20733">r20733</a>.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1010782021-02-24T19:12:33ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>I have found another issue with the current implementation, the project selector dissapears after you select a project without children.</p>
<p>To reproduce:<br />- Open the new issue page from a project with children<br />- Observe that the project selector shows the children as expected<br />- Select a project without children<br />- Observe that the project selector disappear.</p>
<p>The cause is that the issue project is used to look for children (which changes when you select another project in the dropdown) instead of context project (which remains the same).</p>
<p>To keep the code simple, I think it's better to just show the project tree instead of self and descendant. I had some cases when I wanted to create an issue on the parent project.</p>
<p>What do you think? I've opened a new issue for this to track the change (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Show project tree instead of subprojects in the project selector when you create a new issue (Closed)" href="https://www.redmine.org/issues/34798">#34798</a>).</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1011072021-02-26T06:58:06ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/26736">bug.gif</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26736/bug.gif">bug.gif</a> added</li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I have found another issue with the current implementation, the project selector dissapears after you select a project without children.</p>
</blockquote>
<p>I was just trying to make a issue to report this probrem.<br />I will attach the Gif image I made for that explanation.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1015112021-03-23T20:55:36ZMarius BĂLTEANU
<ul></ul><p>I've posted a patch to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Show project tree instead of subprojects in the project selector when you create a new issue (Closed)" href="https://www.redmine.org/issues/34798">#34798</a> which should fix the issue reported by me in my previous comment.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1015252021-03-25T02:17:28ZMizuki ISHIKAWA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I've posted a patch to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Show project tree instead of subprojects in the project selector when you create a new issue (Closed)" href="https://www.redmine.org/issues/34798">#34798</a> which should fix the issue reported by me in my previous comment.</p>
</blockquote>
<p>It looks like the patch was committed in <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Show project tree instead of subprojects in the project selector when you create a new issue (Closed)" href="https://www.redmine.org/issues/34798#note-7">#34798#note-7</a>.<br />I was able to confirm that the problem was solved in my environment as well.</p> Redmine - Defect #33419: Show only valid projects on issue form when the issue is a subtaskhttps://www.redmine.org/issues/33419?journal_id=1015262021-03-25T02:30:03ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I have found another issue with the current implementation, the project selector dissapears after you select a project without children.</p>
<p>To reproduce:<br />- Open the new issue page from a project with children<br />- Observe that the project selector shows the children as expected<br />- Select a project without children<br />- Observe that the project selector disappear.</p>
</blockquote>
<p>Fixed by <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Show project tree instead of subprojects in the project selector when you create a new issue (Closed)" href="https://www.redmine.org/issues/34798">#34798</a>.</p>