https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-06-05T01:40:36ZRedmineRedmine - Patch #33554: Fix by date weekly filter query to use Setting.start_of_weekhttps://www.redmine.org/issues/33554?journal_id=980642020-06-05T01:40:36ZMischa The Evil
<ul></ul><p>I like this change in general. I've seen cases where confusion about different query results arose in multilingual environments.<br />I don't think that coupling <code>Query</code> with <code>Redmine::Helpers::Calendar</code> in this way is a good idea, though. I think it would be better to extract both <code>Redmine::Helpers::Calendar#first_wday</code> and <code>Redmine::Helpers::Calendar#last_wday</code> into a new, encapsulated module (e.g. <code>Redmine::Utils::DayCalculation</code>) and use that where this logic is needed.</p>
<p>Note: this change will modify the results of existing custom queries for all users. While this is intentional, it might be something to take into account. Maybe it is best to mention it explicitly in the release announcement whenever this change is integrated and it gets released.</p> Redmine - Patch #33554: Fix by date weekly filter query to use Setting.start_of_weekhttps://www.redmine.org/issues/33554?journal_id=999042020-11-30T06:13:00ZKonstantin Borisov
<ul></ul><p>I'm new in Redmine community. What are the usual procedures here? You've made some proposal about the implementation. Should it be voted and concluded somehow within contrubutors, or should I just rework my patch to proposed way to include it to release plan? How it works here, @Mischa_The_Evil please advice.</p>