https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-06-06T06:56:15ZRedmineRedmine - Defect #33562: Some tests in ApplicationHelperTest are declared as privatehttps://www.redmine.org/issues/33562?journal_id=980832020-06-06T06:56:15ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Defect #33562: Some tests in ApplicationHelperTest are declared as privatehttps://www.redmine.org/issues/33562?journal_id=980902020-06-07T07:12:49ZMischa The Evil
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.2.0</i></li></ul><p>LGTM. I don't see why this has to be postponed until the next major release (5.x.x). I think it can safely go into the next minor (4.2.0) release (hence, it could even go into 4.1.2/4.0.8, but I don't think that the significance of this fix warrants such a back-port).</p>
FWIW: this is not the first case where this happened (see <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: MarkdownFormatterTest#test_should_support_underlined_text is declared as private (Closed)" href="https://www.redmine.org/issues/31929">#31929</a>), which brings two questions to my mind:
<ol>
<li>Are there currently more, undetected cases like this?</li>
<li>Is this something that, in the future, can be handled by (a custom) RuboCop (cop) now that's being used?</li>
</ol> Redmine - Defect #33562: Some tests in ApplicationHelperTest are declared as privatehttps://www.redmine.org/issues/33562?journal_id=980922020-06-07T07:13:34ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/31929">Defect #31929</a>: MarkdownFormatterTest#test_should_support_underlined_text is declared as private</i> added</li></ul> Redmine - Defect #33562: Some tests in ApplicationHelperTest are declared as privatehttps://www.redmine.org/issues/33562?journal_id=980982020-06-08T07:39:26ZGo MAEDA
<ul></ul><p>Mischa The Evil wrote:</p>
<blockquote>
<p>LGTM. I don't see why this has to be postponed until the next major release (5.x.x). I think it can safely go into the next minor (4.2.0) release (hence, it could even go into 4.1.2/4.0.8, but I don't think that the significance of this fix warrants such a back-port).</p>
</blockquote>
<p>Thank you for reviewing the patch. My understanding is that the next major release is 4.2.0, and the next minor release is 4.1.2.</p>
<blockquote>
<ol>
<li>Are there currently more, undetected cases like this?</li>
</ol>
</blockquote>
<p>I have just checked the following files and no other cases are found.</p>
<p><a href="#" onclick="$('#collapse-fa93dde7-show, #collapse-fa93dde7-hide').toggle(); $('#collapse-fa93dde7').fadeToggle(150);; return false;" id="collapse-fa93dde7-show" class="icon icon-collapsed collapsible">Files</a><a href="#" onclick="$('#collapse-fa93dde7-show, #collapse-fa93dde7-hide').toggle(); $('#collapse-fa93dde7').fadeToggle(150);; return false;" id="collapse-fa93dde7-hide" class="icon icon-expended collapsible" style="display:none;">Files</a><div id="collapse-fa93dde7" class="collapsed-text" style="display:none;"><pre>
$ grep -lr "^\s*private\s*$" test
test/mocks/open_id_authentication_mock.rb
test/unit/project_nested_set_test.rb
test/unit/mailer_localisation_test.rb
test/unit/mailer_test.rb
test/unit/version_test.rb
test/unit/search_test.rb
test/unit/mail_handler_test.rb
test/unit/repository_bazaar_test.rb
test/unit/activity_test.rb
test/unit/lib/redmine/configuration_test.rb
test/unit/lib/redmine/unified_diff_test.rb
test/unit/lib/redmine/scm/adapters/subversion_adapter_test.rb
test/unit/lib/redmine/scm/adapters/bazaar_adapter_test.rb
test/unit/lib/redmine/scm/adapters/cvs_adapter_test.rb
test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb
test/unit/lib/redmine/scm/adapters/git_adapter_test.rb
test/unit/lib/redmine/wiki_formatting/markdown_formatter_test.rb
test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb
test/unit/issue_nested_set_concurrency_test.rb
test/unit/repository_mercurial_test.rb
test/integration/attachments_test.rb
test/integration/sudo_mode_test.rb
test/system/sudo_mode_test.rb
test/helpers/application_helper_test.rb
test/helpers/sort_helper_test.rb
test/coverage/html_formatter.rb
test/functional/repositories_git_controller_test.rb
test/functional/admin_controller_test.rb
test/functional/timelog_custom_fields_visibility_test.rb
</pre></div></p> Redmine - Defect #33562: Some tests in ApplicationHelperTest are declared as privatehttps://www.redmine.org/issues/33562?journal_id=981082020-06-09T05:51:26ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Test methods that will never be executed in ApplicationHelperTest</i> to <i>Some tests in ApplicationHelperTest are declared as private</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch.</p> Redmine - Defect #33562: Some tests in ApplicationHelperTest are declared as privatehttps://www.redmine.org/issues/33562?journal_id=981402020-06-11T02:57:35ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul> Redmine - Defect #33562: Some tests in ApplicationHelperTest are declared as privatehttps://www.redmine.org/issues/33562?journal_id=981672020-06-12T02:57:53ZMischa The Evil
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>[...] My understanding is that the next major release is 4.2.0, and the next minor release is 4.1.2.</p>
</blockquote>
<p>That's why I mentioned it explicitly as there seems to be some confusion about this in the community.<br />FWIW: AFAIK Redmine follows the (semver) major.minor.patch scheme. So major releases are 3.x.x, 4.x.x, 5.x.x; minor releases are 4.1.x, 4.2.x, 4.3.x and 4.1.1, 4.1.2, 4.1.3 are patch releases.</p>
<p>This is documented in the (currently somewhat outdated) <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/ReleaseManagement">ReleaseManagement</a> wiki page.</p>