https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-08-06T02:04:23ZRedmineRedmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=987662020-08-06T02:04:23ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/25797">feature-33820.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25797/feature-33820.patch">feature-33820.patch</a> added</li></ul><p>I attach a patch that adds this feature.</p> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=988192020-08-12T08:06:36ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=993962020-10-11T22:18:25ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul><p>Nice feature, let me find a better way to pass the auto complete endpoint for each case (issues, wiki pages, etc).</p> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=994022020-10-13T05:38:11ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-1 priority-4 priority-default" href="/issues/33425">Feature #33425</a>: Auto complete wiki macros</i> added</li></ul> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=994052020-10-13T05:39:16ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/31989">Feature #31989</a>: Inline issue auto complete (#) in fields with text-formatting enabled</i> added</li></ul> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=994302020-10-16T06:30:34ZMarius BĂLTEANU
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Nice feature, let me find a better way to pass the auto complete endpoint for each case (issues, wiki pages, etc).</p>
</blockquote>
<p>I've posted an alternative solution in <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Store inline autocomplete data sources in a JS variable (Closed)" href="https://www.redmine.org/issues/34122">#34122</a>, please let me know what do you think about it.</p>
Beside this point, the patch needs at least two changes:
<ul>
<li>Use a collection for triggers (see my note from <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Auto complete wiki macros (New)" href="https://www.redmine.org/issues/33425">#33425</a>)</li>
<li>Explore the possibility to show the wiki pages in parent - child relation or at least the parent if any in order to avoid confusion when there are multiple pages with the same title, but under different parent pages.</li>
</ul> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=994312020-10-16T06:30:40ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li></ul> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=996862020-11-11T07:54:52ZGo MAEDA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
Beside this point, the patch needs at least two changes:
<ul>
<li>Use a collection for triggers (see my note from <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Auto complete wiki macros (New)" href="https://www.redmine.org/issues/33425">#33425</a>)</li>
<li>Explore the possibility to show the wiki pages in parent - child relation or at least the parent if any in order to avoid confusion when there are multiple pages with the same title, but under different parent pages.</li>
</ul>
</blockquote>
<p>I think the latter is not a problem. Wiki page names are unique in a project. You cannot create Wiki pages with the same name even if its parent pages are different.</p> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=997712020-11-18T00:14:04ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/26257">feature-33820-v2.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26257/feature-33820-v2.diff">feature-33820-v2.diff</a> added</li></ul><p>I fixed the patch by referring to the code of <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Store inline autocomplete data sources in a JS variable (Closed)" href="https://www.redmine.org/issues/34122">#34122</a>.</p> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=1008692021-02-08T14:02:55ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.2.0</i></li></ul><p>Setting the target version to 4.2.0 again.</p> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=1008952021-02-10T22:46:06ZMarius BĂLTEANU
<ul></ul><p>Mizuki, can you add a system tests for this? you should have enough examples.</p> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=1009792021-02-15T00:29:26ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/26687">feature-33820-v3-with-test.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26687/feature-33820-v3-with-test.patch">feature-33820-v3-with-test.patch</a> added</li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>Mizuki, can you add a system tests for this? you should have enough examples.</p>
</blockquote>
<p>I have attached a patch with system test added.<br />There are already tests to check that tributes work on other pages, so I'm only added testing that the issues/new page can autocomplete the wiki page link.</p> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=1010022021-02-17T14:20:29ZGo MAEDA
<ul></ul><p>I found a security issue.</p>
<p>Auto complete for wiki pages should not suggest pages that the current user cannot view. The current patch always shows wiki pages even if the current user does not have "View wiki".</p> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=1010832021-02-25T00:42:30ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/26733">feature-33820-v4.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26733/feature-33820-v4.patch">feature-33820-v4.patch</a> added</li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I found a security issue.</p>
<p>Auto complete for wiki pages should not suggest pages that the current user cannot view. The current patch always shows wiki pages even if the current user does not have "View wiki".</p>
</blockquote>
<p>Thank you for pointing that out. <br />I changed to return nothing when you do not have permission.</p> Redmine - Feature #33820: Auto complete wiki page linkshttps://www.redmine.org/issues/33820?journal_id=1010852021-02-25T04:08:09ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Auto Complete wiki page links</i> to <i>Auto complete wiki page links</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you for improving Redmine.</p>