https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292021-01-27T09:01:41ZRedmineRedmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1007092021-01-27T09:01:41ZMischa The Evil
<ul><li><strong>Follows</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/26579">Feature #26579</a>: Project settings : remove Wiki tab</i> added</li></ul> Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1007102021-01-27T09:02:07ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/34634">Defect #34634</a>: Deletion of project wiki leaves the project wiki inaccessible (404) until module reactivation</i> added</li></ul> Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1008092021-02-03T14:12:16ZGo MAEDA
<ul></ul><p>Thank you for posting the patch. I have tried out the patches and confirmed the first four patches fix existing issues.</p>
<p>However, I am afraid the change by attachment:0005-Changed-wiki-start_page-name-to-I18n-ed-field_start_.patch is sometimes confusing. Assume the following situation.</p>
<p>1. Create the first Wiki page on a project. The page title will be "Start page" <br />2. Create a new page with the title "Foo" <br />3. Set the page "Foo" as a start page</p>
<p>Even after changing the start page to "Foo", the first page's title is still "Start page" despite the page is no longer a start page. Despite a page with the name "Start page" exists, the link "Start page" in the sidebar points to "Foo" page instead of "Start page". I think it is confusing.</p> Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1008102021-02-03T14:21:33ZGo MAEDA
<ul></ul><p>How about committing the first four patches first, and discussing the fifth patch as a separate issue?</p> Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1019692021-04-13T05:17:44ZMischa The Evil
<ul><li><strong>Subject</strong> changed from <i>Cleanups, fixes and improvements after Wiki tab removal from project settings (#26579)</i> to <i>Cleanups and fixes after Wiki tab removal from project settings (#26579)</i></li></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>How about committing the first four patches first, and discussing the fifth patch as a separate issue?</p>
</blockquote>
<p>Sorry for the delayed response. I agree with you. I should have separated them in the first place as their changes are unrelated. FWIW: I'd also be ok with dropping the fifth patch altogether early at the gate, given the possible confusion and the severity of the "issue".</p> Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1021612021-04-21T08:43:27ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1024152021-05-12T14:52:21ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.2.2</i></li></ul><p>Setting the target version to 4.2.2.</p> Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1026142021-05-30T21:36:27ZMarius BĂLTEANU
<ul></ul><p>Should we add a message to the delete confirmation message to inform the user that deleting the root wiki will disable the module?</p> Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1033382021-07-26T21:23:22ZMarius BĂLTEANU
<ul><li><strong>Copied to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/35610">Patch #35610</a>: Cleanups after Wiki tab removal from project settings (#26579)</i> added</li></ul> Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)https://www.redmine.org/issues/34643?journal_id=1033442021-07-26T21:34:52ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> deleted (<del><i>4.2.2</i></del>)</li></ul><p>I've committed first 3 patches as part of <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Cleanups after Wiki tab removal from project settings (#26579) (Closed)" href="https://www.redmine.org/issues/35610">#35610</a> for Redmine <a class="version" href="https://www.redmine.org/versions/155">5.0.0</a>.</p>
<p>Regarding point 4, we can continue the discussions in <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Deletion of project wiki leaves the project wiki inaccessible (404) until module reactivation (Closed)" href="https://www.redmine.org/issues/34634">#34634</a> which is now assigned to <a class="version" href="https://www.redmine.org/versions/155">5.0.0</a>.</p>
<p>Thanks Mischa The Evil for providing the patches.</p>