https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292021-03-19T05:48:43ZRedmineRedmine - Defect #34933: Atom feed of the activity page does not contain items after the second pagehttps://www.redmine.org/issues/34933?journal_id=1014722021-03-19T05:48:43ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/26894">34933.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26894/34933.patch">34933.patch</a> added</li></ul><p>I created a patch.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/app/controllers/activities_controller.rb b/app/controllers/activities_controller.rb
index 745a40219..e1bba49f6 100644
</span><span class="gd">--- a/app/controllers/activities_controller.rb
</span><span class="gi">+++ b/app/controllers/activities_controller.rb
</span><span class="p">@@ -55,7 +55,12 @@</span> class ActivitiesController < ApplicationController
end
end
- events = @activity.events(@date_from, @date_to)
<span class="gi">+ events =
+ if params[:format] == 'atom'
+ @activity.events(nil, nil, :limit => Setting.feeds_limit.to_i)
+ else
+ @activity.events(@date_from, @date_to)
+ end
</span>
if events.empty? || stale?(:etag => [@activity.scope, @date_to, @date_from, @with_subprojects, @author, events.first, events.size, User.current, current_language])
respond_to do |format|
</code></pre> Redmine - Defect #34933: Atom feed of the activity page does not contain items after the second pagehttps://www.redmine.org/issues/34933?journal_id=1015852021-03-28T06:13:46ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul> Redmine - Defect #34933: Atom feed of the activity page does not contain items after the second pagehttps://www.redmine.org/issues/34933?journal_id=1019162021-04-09T05:34:01ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/27144">34933-v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27144/34933-v2.patch">34933-v2.patch</a> added</li><li><strong>Subject</strong> changed from <i>Received Atom feed entries only of the first page of Activity</i> to <i>Atom feed of the activity page does not contain items after the second page</i></li><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>4.1.3</i></li></ul><p>In <a class="attachment" href="https://www.redmine.org/attachments/27144">34933-v2.patch</a>, I have changed the test name.</p> Redmine - Defect #34933: Atom feed of the activity page does not contain items after the second pagehttps://www.redmine.org/issues/34933?journal_id=1019542021-04-12T09:10:53ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you.</p> Redmine - Defect #34933: Atom feed of the activity page does not contain items after the second pagehttps://www.redmine.org/issues/34933?journal_id=1019652021-04-13T02:42:05ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul> Redmine - Defect #34933: Atom feed of the activity page does not contain items after the second pagehttps://www.redmine.org/issues/34933?journal_id=1028842021-06-19T05:58:57ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/35413">Patch #35413</a>: Add missing fixtures to ActivitiesControllerTest</i> added</li></ul>