https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292021-08-11T05:46:13ZRedmineRedmine - Defect #35731: Password and Confirmation fields are marked as required when editing a user https://www.redmine.org/issues/35731?journal_id=1036562021-08-11T05:46:13ZGo MAEDA
<ul></ul><p>The following patch fixes the issue.</p>
<pre><code class="diff syntaxhl"><span class="gh">diff --git a/app/views/users/_form.html.erb b/app/views/users/_form.html.erb
index 4b030d920..0d50d3d56 100644
</span><span class="gd">--- a/app/views/users/_form.html.erb
</span><span class="gi">+++ b/app/views/users/_form.html.erb
</span><span class="p">@@ -32,13 +32,13 @@</span>
<% end %>
<div id="password_fields" style="<%= 'display:none;' if @user.auth_source %>">
<p>
<span class="gd">- <%= f.password_field :password, :required => true, :size => 25 %>
</span><span class="gi">+ <%= f.password_field :password, :required => @user.new_record?, :size => 25 %>
</span> <em class="info"><%= l(:text_caracters_minimum, :count => Setting.password_min_length) %></em>
<% if Setting.password_required_char_classes.any? %>
<em class="info"><%= l(:text_characters_must_contain, :character_classes => Setting.password_required_char_classes.collect{|c| l("label_password_char_class_#{c}")}.join(", ")) %></em>
<% end %>
</p>
<span class="gd">- <p><%= f.password_field :password_confirmation, :required => true, :size => 25 %></p>
</span><span class="gi">+ <p><%= f.password_field :password_confirmation, :required => @user.new_record?, :size => 25 %></p>
</span> <p><%= f.check_box :generate_password %></p>
<p><%= f.check_box :must_change_passwd %></p>
</div>
</code></pre> Redmine - Defect #35731: Password and Confirmation fields are marked as required when editing a user https://www.redmine.org/issues/35731?journal_id=1036592021-08-11T08:20:45ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/27865">35731.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27865/35731.patch">35731.patch</a> added</li><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul><p>Added test code.</p> Redmine - Defect #35731: Password and Confirmation fields are marked as required when editing a user https://www.redmine.org/issues/35731?journal_id=1036722021-08-11T19:53:43ZHolger Just
<ul></ul><p>Looks good to me. Thanks!</p> Redmine - Defect #35731: Password and Confirmation fields are marked as required when editing a user https://www.redmine.org/issues/35731?journal_id=1036822021-08-12T04:27:09ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>4.1.5</i></li></ul><p>Setting the target version to 4.1.5.</p> Redmine - Defect #35731: Password and Confirmation fields are marked as required when editing a user https://www.redmine.org/issues/35731?journal_id=1037092021-08-13T03:00:57ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch.</p>