https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292021-09-20T07:38:59ZRedmineRedmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1041392021-09-20T07:38:59ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/32424">Feature #32424</a>: CommonMark Markdown Text Formatting</i> added</li></ul> Redmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1041402021-09-20T07:44:55ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li><li><strong>Target version</strong> set to <i>5.0.0</i></li></ul> Redmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1041472021-09-20T18:36:10ZHolger Just
<ul></ul><p>This seems to be related to <a class="external" href="https://github.com/gjtorikian/commonmarker/pull/148">https://github.com/gjtorikian/commonmarker/pull/148</a> which updated cmark-gfm to <a href="https://github.com/github/cmark-gfm/releases/tag/0.29.0.gfm.2" class="external">0.29.0.gfm.2</a>. There, they did in fact changed the footnote handling.</p>
<ul>
<li>The format change of the footnote IDs was comitted in <a class="external" href="https://github.com/github/cmark-gfm/pull/230">https://github.com/github/cmark-gfm/pull/230</a></li>
<li>The missing <code>id</code> for the back references however looks strange... Maybe we have to do something different here?</li>
</ul> Redmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1041962021-09-25T15:51:19ZKo Nagase
<ul><li><strong>File</strong> <a href="/attachments/28079">fix_common-mark-test.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/28079/fix_common-mark-test.patch">fix_common-mark-test.patch</a> added</li></ul><p>How about to change the test code side by regexp match as a workaround ?<br />Attached patch supports both CommonMarker "== 0.23.2" and "<= 0.23.1" tests.</p> Redmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1042342021-10-02T15:51:52ZMarius BĂLTEANU
<ul></ul><p>I have locked <code>commonmarker</code> to <code>0.23.1</code> until we find a better way to handle the footnotes because the new format doesn't affect only the tests, it affects also the logic from <code>sanitization_filter</code> (<a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/lib/redmine/wiki_formatting/common_mark/sanitization_filter.rb#L70">source:trunk/lib/redmine/wiki_formatting/common_mark/sanitization_filter.rb#L70</a>) and we need to support both ways depending on the Ruby version.</p> Redmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1042372021-10-02T18:58:15ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> changed from <i>5.0.0</i> to <i>Candidate for next minor release</i></li></ul> Redmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1042402021-10-03T00:15:51ZKo Nagase
<ul></ul><p>Okay, thanks for the fix!</p> Redmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1068112022-05-28T09:29:48ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>5.0.2</i></li></ul> Redmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1068122022-05-28T09:44:24ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Proper fix committed in <a class="changeset" title="Update footnotes markup after commonmarker gem update (#35892)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21612">r21612</a>.</p> Redmine - Defect #35892: Redmine::WikiFormatting::CommonMark::FormatterTest#test_footnotes fails with CommonMarker 0.23.2 https://www.redmine.org/issues/35892?journal_id=1068302022-05-30T06:50:56ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>