https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292022-05-17T21:51:18ZRedmineRedmine - Feature #37119: Drop redcarpet dependency for common_mark formatterhttps://www.redmine.org/issues/37119?journal_id=1067292022-05-17T21:51:18ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul> Redmine - Feature #37119: Drop redcarpet dependency for common_mark formatterhttps://www.redmine.org/issues/37119?journal_id=1067302022-05-17T22:12:57ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/29216">0001-Move-methods-related-to-section-to-a-helper-file-and.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/29216/0001-Move-methods-related-to-section-to-a-helper-file-and.patch">0001-Move-methods-related-to-section-to-a-helper-file-and.patch</a> added</li><li><strong>File</strong> <a href="/attachments/29215">0002-Drop-redcarpet-dependency-from-common_mark-group.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/29215/0002-Drop-redcarpet-dependency-from-common_mark-group.patch">0002-Drop-redcarpet-dependency-from-common_mark-group.patch</a> added</li></ul><p><a class="user active" href="https://www.redmine.org/users/13581">holger mareck</a>, I made a patch that should fix this.</p>
What I did?
<ul>
<li>I've moved the methods <code>get_section</code>, <code>update_section</code> and <code>extract_sections</code> to a new helper file (<code>Redmine::WikiFormatting::SectionHelper</code>)</li>
<li>the new helper file is included by all three formatters</li>
<li>textile formatter overrides <code>extract_sections</code> method which his own implementation</li>
<li>I've removed the <code>redcarpet</code> dependency from <code>common_mark</code> group.</li>
</ul>
<p>What do you think?</p> Redmine - Feature #37119: Drop redcarpet dependency for common_mark formatterhttps://www.redmine.org/issues/37119?journal_id=1069572022-06-16T15:05:22ZHolger Just
<ul></ul><p>Looks good to me, tanks!</p> Redmine - Feature #37119: Drop redcarpet dependency for common_mark formatterhttps://www.redmine.org/issues/37119?journal_id=1069832022-06-16T21:40:33ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Thanks Holger for your review. I've committed both changes.</p> Redmine - Feature #37119: Drop redcarpet dependency for common_mark formatterhttps://www.redmine.org/issues/37119?journal_id=1101012023-05-22T15:28:29ZHolger Just
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/36892">Defect #36892</a>: Redmine does not start when installed --without markdown</i> added</li></ul>