https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292009-09-04T06:37:47ZRedmineRedmine - Defect #3715: Login page should not show projects link and search box if authentication is requiredhttps://www.redmine.org/issues/3715?journal_id=108262009-09-04T06:37:47ZLucas Panjer
<ul><li><strong>File</strong> <a href="/attachments/2495">3715-1.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2495/3715-1.diff">3715-1.diff</a> added</li></ul><p>simple approach attached in diff</p> Redmine - Defect #3715: Login page should not show projects link and search box if authentication is requiredhttps://www.redmine.org/issues/3715?journal_id=108392009-09-05T17:15:51ZEric Davis
<ul></ul><p>Nice simple implementation. It would be good to add a short integration test for this to make sure they stay hidden in the future.</p> Redmine - Defect #3715: Login page should not show projects link and search box if authentication is requiredhttps://www.redmine.org/issues/3715?journal_id=108722009-09-09T08:03:34ZLucas Panjer
<ul><li><strong>File</strong> <a href="/attachments/2514">3715-2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2514/3715-2.patch">3715-2.patch</a> added</li></ul><p>Added a test. The menu_manager test suite seemed like a roughly appropriate spot for it.<br />Adjusted change to remove the entire #quick-search. I don't see any point in leaving the div with no form.</p>
<p>The other approach to this issue is to ask each plugin to respect the login_required setting and adjust Redmine in the menu manager somewhere. This approach would preserve the ability to show menu items to unauthenticated users when login is required, which the approach in this patch does not allow.</p> Redmine - Defect #3715: Login page should not show projects link and search box if authentication is requiredhttps://www.redmine.org/issues/3715?journal_id=119732009-11-11T18:53:18ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Category</strong> set to <i>UI</i></li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Low</i></li></ul> Redmine - Defect #3715: Login page should not show projects link and search box if authentication is requiredhttps://www.redmine.org/issues/3715?journal_id=256652011-02-26T16:45:13ZEtienne Massip
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Defect #3715: Login page should not show projects link and search box if authentication is requiredhttps://www.redmine.org/issues/3715?journal_id=259252011-03-04T15:15:05ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>1.2.0</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Patch committed in <a class="changeset" title="Fixed: Login page should not show projects link and search box if authentication is required (#37..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/5007">r5007</a>. Test slightly edited and moved to <code>layout_test</code>.</p> Redmine - Defect #3715: Login page should not show projects link and search box if authentication is requiredhttps://www.redmine.org/issues/3715?journal_id=259462011-03-05T10:56:52ZDenis Tomashenko
<ul></ul><p><a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Hide search textbox if authorization required (Closed)" href="https://www.redmine.org/issues/2321">#2321</a> - this can be closed too</p> Redmine - Defect #3715: Login page should not show projects link and search box if authentication is requiredhttps://www.redmine.org/issues/3715?journal_id=259512011-03-05T11:48:31ZEtienne Massip
<ul></ul><p>Done, thanks.</p>