https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292020-03-08T12:59:03ZRedmineRedmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=966402020-03-08T12:59:03ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Duplicate</i></li></ul><p>Implemented in Redmine 4.1.0 (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Permission to log time for another user (Closed)" href="https://www.redmine.org/issues/3848">#3848</a>).</p> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=966412020-03-08T12:59:14ZGo MAEDA
<ul><li><strong>Is duplicate of</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/3848">Feature #3848</a>: Permission to log time for another user</i> added</li></ul> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=966432020-03-08T21:06:28ZMarius BĂLTEANU
<ul><li><strong>Is duplicate of</strong> deleted (<i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/3848">Feature #3848</a>: Permission to log time for another user</i>)</li></ul> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=966452020-03-08T21:06:34ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/3848">Feature #3848</a>: Permission to log time for another user</i> added</li></ul> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=966472020-03-08T21:12:37ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/24955">Screenshot 2020-03-08 at 23.07.39.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24955/Screenshot%202020-03-08%20at%2023.07.39.png">Screenshot 2020-03-08 at 23.07.39.png</a> added</li><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li><li><strong>Resolution</strong> deleted (<del><i>Duplicate</i></del>)</li></ul><p>It's implemented only for users with permission to log time for other users. I think we can add an read only field also for users without permissions.</p> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=966532020-03-09T06:53:27ZGo MAEDA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I think we can add an read only field also for users without permissions.</p>
</blockquote>
<p>+1</p> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=967112020-03-10T21:49:54ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/24973">time_entry_user.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24973/time_entry_user.png">time_entry_user.png</a> added</li></ul><p>We can show the user as link/string instead of a read only field, it's ok?<br /><img src="https://www.redmine.org/attachments/download/24973/time_entry_user.png" style="border: 1px solid grey;width: 50%;" alt="" /></p> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=967122020-03-10T21:57:57ZMarius BĂLTEANU
<ul><li><strong>Subject</strong> changed from <i>Edititng time entries should show the person involved</i> to <i>Editing time entries should show the person involved</i></li></ul> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=967602020-03-14T16:38:45ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/25004">0001-Show-time-entry-user-info-in-edit-page-also-for-user.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25004/0001-Show-time-entry-user-info-in-edit-page-also-for-user.patch">0001-Show-time-entry-user-info-in-edit-page-also-for-user.patch</a> added</li><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.1</i></li></ul><p>Here is the patch, I think it's safe to deliver this in <a class="version" href="https://www.redmine.org/versions/160">4.1.1</a></p>
<p>Tests result <a href="https://gitlab.com/redmine-org/redmine/pipelines/126319437" class="external">here</a></p> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=968922020-03-23T01:08:58ZKevin Fischer
<ul><li><strong>File</strong> <a href="/attachments/25067">0002-show-user-name-in-time-entry-batch-edit.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/25067/0002-show-user-name-in-time-entry-batch-edit.patch">0002-show-user-name-in-time-entry-batch-edit.patch</a> added</li></ul><p>Patch looks good to me!</p>
<p>By the way: When I looked at the current behaviour I was thinking:</p>
<p>Wouldn't it be convenient if the User of each time entry was also displayed in the link text of each time entry on the top? It would address the same problem as in the original post...</p>
<p>I added a potential patch for that...</p> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=971062020-04-05T08:36:55ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Both patches committed, thanks.<br />Just a slight change to Kevin's patch to prevent calling #name on nil.</p> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=971172020-04-05T09:49:04ZMarius BĂLTEANU
<ul></ul><p>Test fails:</p>
<pre>
Failure:
TimelogControllerTest#test_get_bulk_edit [/builds/redmine-org/redmine/test/functional/timelog_controller_test.rb:712]:
<03/23/2007 - eCookbook: 4.25 hours> expected but was
<03/23/2007 - eCookbook: 4.25 hours (John Smith)>..
Expected 0 to be >= 1.
bin/rails test test/functional/timelog_controller_test.rb:706
</pre> Redmine - Feature #3800: Editing time entries should show the person involvedhttps://www.redmine.org/issues/3800?journal_id=971342020-04-05T11:20:05ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged.</p>