Defect #4182: Links on locked users lead to 404 page - Redmine

Actions

Copy link

Defect #4182

closed

Links on locked users lead to 404 page

Added by Jean-Baptiste Barth about 15 years ago. Updated about 15 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Accounts / authentication

Target version:

0.9.0

Start date:

2009-11-08

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

When you lock a user account (for instance because person has left the team), there are still many links in every issues, wiki pages, comments left by this person. When you click on them, you are redirected to a 404 page, which is not very easy to understand for users imho.

I think this is because in UsersController#show, user is searched with the "active" scope, and there's a rescue ActiveRecord::RecordNotFound; render_404 at the end of the action. Maybe you could forget the "active" scope, and change the display after that with a specific error page ?

Any opinion on this ?

Actions

Copy link

Updated by Jean-Philippe Lang about 15 years ago

I think that locked users profiles should stay hidden, especially because of the lack of user deletion feature.

But you're right, we shouldn't link a page that gives a 404. A simple fix would be to display locked users as text in ApplicationHelper#link_to_user.

Actions

Copy link