Patch #4299
Add tabindex to login screen
| Status: | Closed | Start date: | 2009-11-27 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | UI | |||
| Target version: | 0.9.0 |
Description
When on the loginscreen there were no tabindex' defined.
I made it follow the login, password, open id, stay logged in and finally the login button (therefor skipping the "lost password" link.
However, the checkbox autologin is now set to true as default since check_box_tag could not set any options of not both value and checked status was defined. If it should be false as default I can ofcourse fix that to.
Note that this was mostly a test on how to make patches and therefor I did one for the thing that was an easy fix for not that big a problem. :)
Patched from r3092.
tabindex_loginpage.diff 
(1.55 KB)
tabindex_loginpage_fixed.diff
- Fixed diff to be created in the redmine directory (as it should be)
(1.6 KB)
Related issues
Associated revisions
Add tabindex to login screen (#4299).
History
#1
Updated by Henrik Ammer over 12 years ago
- File tabindex_loginpage_fixed.diff added
One rookie mistake: I didn't run the svn diff in the redmine directorybut in the app/views/account directory. I'm adding a new patch that fixes this.
#2
Updated by Jean-Philippe Lang over 12 years ago
- Category set to UI
- Status changed from New to Closed
- Target version set to 0.9.0
Patch committed in r3098 with slight change (autologin should definitely stay disabled by default).
Thanks.