https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292007-11-07T17:33:00ZRedmineRedmine - Feature #469: Code Review/Approve workflow?https://www.redmine.org/issues/469?journal_id=10112007-11-07T17:33:00ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Hi, it looks interesting.</p>
<p>In the near time, what can be done is:<br />- to create a tracker called "Review request" with<br />appropriate workflow which would be used to submit and comment<br />patches<br />- add a diff viewer for attachments (the code already exists<br />for repository diffs), so that attached patches can be easily<br />reviewed</p>
<p>Then the submitter create a "Review request" issue<br />and attach its patch to it. Reviewers would be able to view the<br />diff (just like you see diffs in the repository browser) and<br />enter their comments by adding notes to the issue.</p>
<p>What do you think ?</p> Redmine - Feature #469: Code Review/Approve workflow?https://www.redmine.org/issues/469?journal_id=269442011-03-24T04:38:32ZToshi MARUYAMA
<ul><li><strong>Category</strong> set to <i>Issues workflow</i></li></ul> Redmine - Feature #469: Code Review/Approve workflow?https://www.redmine.org/issues/469?journal_id=441182013-01-12T16:50:17ZDaniel Felix
<ul></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
<p>- add a diff viewer for attachments (the code already exists<br />for repository diffs), so that attached patches can be easily<br />reviewed</p>
</blockquote>
<p>This would be interessting!</p> Redmine - Feature #469: Code Review/Approve workflow?https://www.redmine.org/issues/469?journal_id=441322013-01-12T17:29:42ZDaniel Felix
<ul><li><strong>Subject</strong> changed from <i>Code Review/Approce workflow?</i> to <i>Code Review/Approve workflow?</i></li></ul> Redmine - Feature #469: Code Review/Approve workflow?https://www.redmine.org/issues/469?journal_id=469252013-03-18T13:31:29ZToshi MARUYAMA
<ul></ul><p>Is this issue close as duplicate <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Code Review Module (New)" href="https://www.redmine.org/issues/2048">#2048</a>?</p> Redmine - Feature #469: Code Review/Approve workflow?https://www.redmine.org/issues/469?journal_id=469282013-03-18T13:39:38ZDaniel Felix
<ul></ul><p>Well I would prefer to close the older one as the newer one has a better history and is more general in naming of the review tools. What do you think?</p>
<p>Both seem to be the same request.</p> Redmine - Feature #469: Code Review/Approve workflow?https://www.redmine.org/issues/469?journal_id=469362013-03-18T13:57:18ZToshi MARUYAMA
<ul></ul><p><a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Code Review Module (New)" href="https://www.redmine.org/issues/2048">#2048</a> has many watchers.<br />I think it is better to close this issue.</p> Redmine - Feature #469: Code Review/Approve workflow?https://www.redmine.org/issues/469?journal_id=469372013-03-18T14:09:12ZDaniel Felix
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Duplicate</i></li></ul><p>Closed as duplicate of <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Code Review Module (New)" href="https://www.redmine.org/issues/2048">#2048</a>.</p>