Defect #47

Error in journalizing an issue with longtext custom fields

Added by Amedeo Amedeo over 14 years ago. Updated over 14 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-
Resolution: Affected version:

Description

When an issue has custom fields defined as longtext, whenever you try to save a very long text description (more than
255 chars) the system fails saving on table journal. This is due to the size of 255 for oldValue and newValue fields.

I managed temporarily with the attached patch.

issue.patch Magnifier (1.57 KB) Amedeo Amedeo, 2008-02-03 10:49

History

#1 Updated by Amedeo Amedeo over 14 years ago

Thanks for the prompt action :)

#2 Updated by Jean-Philippe Lang over 14 years ago

This problem doesn't occur with mysql. But I could reproduce
it after swithing to Postgresql.

Fixed in rev 477.

#3 Updated by Amedeo Amedeo over 14 years ago

Rails 1.2.2 and PostgreSQL 8.1.4

The error I get is something like:

RuntimeError: ERROR C22001 Mvalue too long for type character
varying(255) Fvarchar.c L539 Rvarchar: INSERT INTO journal_details
("old_value", "property", "value",
"journal_id", "prop_key") VALUES('', 'cf',
'Lorem ipsum dolor sit amet

#4 Updated by Jean-Philippe Lang over 14 years ago

I've just tested this. I get no errors and text is automaticaly
truncated and correctly saved.

Could tell me what version of rails and database you're using ?

#5 Updated by Jean-Philippe Lang over 14 years ago

I agree with you. I'll fix this way.
Thanks.

#6 Updated by Amedeo Amedeo over 14 years ago

I would go for the truncation, don't think has a real value having
a very long
decription in the history and also depending on the database
implementation
having text field rather than varchar(255) could increase
drammatically the size
of the journal table.

Thanks,
Amedeo

#7 Updated by Jean-Philippe Lang over 14 years ago

I see 2 solutions:
- change the 2 database columns to 'text' (instead
of varchar255)
- truncate the values (as you did in your patch)

Do you need to have the full length value in the history ?

Also available in: Atom PDF