Project

General

Profile

Actions
Copy link

Defect #4998

closed

Global issue list's context menu has enabled options for parent menus but there are no valid selections

Added by Eric Davis over 14 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Low
Assignee:
Jean-Baptiste Barth
Category:
UI
Target version:
1.0.2
Start date:
2010-03-05
Due date:
% Done:

100%

Estimated time:
Resolution:
Fixed
Affected version:

Description

A client brought this bug to my attention. On the global issues list:

  • Select two issues on different projects
  • Right click to trigger the context menu
  • Some options with a submenu are enabled but the selections are not (Priority, % Done). e.g. It shows you can change Priority but doesn't present any values you can select.

Files

Download all files
issues_controller.rb.patch (1.99 KB) issues_controller.rb.patch Alain Alain091, 2010-05-01 19:58
issues_controller.rb.patch (1.96 KB) issues_controller.rb.patch Alain Alain091, 2010-05-02 10:44
Actions
Copy link
 #1

Updated by Jean-Philippe Lang over 14 years ago

  • Category changed from Issues to UI
  • Priority changed from Normal to Low
Actions
Copy link
 #2

Updated by Alain Alain091 over 14 years ago

find attached a patch which take into account rights of each project for evaluate the access to actions in menus.

The rule is an AND operation between the rights in each project. If one is false, the entire action is set to false.

Actions
Copy link
 #3

Updated by Alain Alain091 over 14 years ago

I was impatient to post my modifications

But, if the idea of correction was correct my code contained errors

Here a better patch.

Actions
Copy link
 #4

Updated by Alain Alain091 over 14 years ago

I think that the correct statment is :

edit = edit && expression

and not edit &= expression

Actions
Copy link
 #5

Updated by Jean-Baptiste Barth over 14 years ago

Same here at work on 1.0.0(RC), it's really annoying and should be fixed for 1.0.1 in my opinion. Alain: I'll take a look at your patch.

Actions
Copy link
 #6

Updated by Jean-Baptiste Barth about 14 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Baptiste Barth
  • Target version set to 1.0.2
  • % Done changed from 0 to 100
  • Resolution set to Fixed

Alain: your patch is a first step to handle cross-projects issues in context menu, which is a much larger issue (see #5332).

I prefer just hiding those items for the moment, which solves the exact issue Eric reported. It's committed in r4059. We may work on bulk edit later, in #5332.

Actions
Copy link
 #7

Updated by Eric Davis about 14 years ago

  • Status changed from Resolved to Closed

Merged into 1.0-stable for release in 1.0.2

Actions
Copy link

Also available in: Atom PDF