https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292010-03-25T20:39:23ZRedmineRedmine - Defect #5170: Done ratio can not revert to 0% if status is used for done ratio https://www.redmine.org/issues/5170?journal_id=154702010-03-25T20:39:23ZMischa The Evil
<ul><li><strong>Assignee</strong> set to <i>Eric Davis</i></li></ul><p>Eric,</p>
<p>Can you take a look at this issue? Isn't this tested yet?</p> Redmine - Defect #5170: Done ratio can not revert to 0% if status is used for done ratio https://www.redmine.org/issues/5170?journal_id=204622010-09-18T13:02:05ZFelix Schäfer
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>7</i></li><li><strong>Target version</strong> set to <i>1.0.2</i></li></ul><p>I completed the patch with some tests, thanks Yuki for finding this. The commit is here: <a class="external" href="http://github.com/thegcat/redmine/commit/fc58994174b2206da0ce25e0321dd96dda62a366">http://github.com/thegcat/redmine/commit/fc58994174b2206da0ce25e0321dd96dda62a366</a></p>
<p>I also slightly changed one of the tests to really test <code>Issue#update_done_ratio_from_issue_status</code>, for which the comment (<a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/app/models/issue.rb#L326">source:/trunk/app/models/issue.rb#L326</a>) states:</p>
<blockquote>
<p>Set the done_ratio using the status if that setting is set. This will keep the done_ratios even if the user turns off the setting later</p>
</blockquote> Redmine - Defect #5170: Done ratio can not revert to 0% if status is used for done ratio https://www.redmine.org/issues/5170?journal_id=207432010-09-26T18:09:35ZEric Davis
<ul><li><strong>Status</strong> changed from <i>7</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Applied in <a class="changeset" title="Fixes reverting an issue to a status with a done_ratio of 0%. #5170 Contributed by Felix Schäfer" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4186">r4186</a>. Thanks for the bug report and patch.</p> Redmine - Defect #5170: Done ratio can not revert to 0% if status is used for done ratio https://www.redmine.org/issues/5170?journal_id=207582010-09-26T22:21:20ZEric Davis
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged into 1.0-stable</p>