Patch #5441: Initialize TimeEntry attributes with params[:time_entry] - Redmine

Actions

Copy link

Patch #5441

closed

Initialize TimeEntry attributes with params[:time_entry]

Added by Jérémie Delaitre over 14 years ago. Updated about 14 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Time tracking

Target version:

1.1.0

Start date:

2010-05-04

Due date:

% Done:

Estimated time:

Description

I've made a one-liner patch to fill the new TimeEntry attributes created in IssuesController#update_issue_from_param with the params[:time_entry].

This allows to pre-fill the spent time field when accessing the issue editing page.

I want to use this feature for my time tracker plugin. When the user stops his time tracker, I want to redirect him to the issue editing page to let him change what he wants (%done ratio for example) and enter a time log comment. However, I need to be able to fill the spent time field for him with the time tracker value.

Files

Download all files

time_entry_init.diff (732 Bytes) time_entry_init.diff		Jérémie Delaitre, 2010-05-04 17:54
time_entry_init.diff (2.14 KB) time_entry_init.diff	Updated patch with functional test	Jérémie Delaitre, 2010-10-26 19:44
time_entry_init.diff (2.1 KB) time_entry_init.diff	With working functional test	Jérémie Delaitre, 2010-11-04 22:40

Actions

Copy link

Updated by Ludovic Gasc over 14 years ago

Assignee changed from Eric Davis to Jean-Philippe Lang

I valid this patch, it's useful with this plugin: http://github.com/delaitre/redmine_time_tracker
Moreover, some other plugins could use this feature to pre-populate the timesheet part in the edit form.

Somebody in the Redmine team could integrate this patch in the Redmine trunk ?
Thanks.

Actions

Copy link

Updated by Jérémie Delaitre about 14 years ago

I still need this patch (1 line!). Is there any chance to get it included?

Actions

Copy link

Updated by Jean-Philippe Lang about 14 years ago

Could you update the patch for current trunk and include a functional test ?

Actions

Copy link

Updated by Jérémie Delaitre about 14 years ago

File time_entry_init.diff time_entry_init.diff added

I've updated the patch according to current github master.
The 'test_get_edit_with_params' functional test has been updated too to check the time_entry params.

Actions

Copy link

Updated by Jérémie Delaitre about 14 years ago

I forgot to ask you to execute the updated test as I'm not confident in my redmine installation...

Actions

Copy link

Updated by Jérémie Delaitre about 14 years ago

File time_entry_init.diff time_entry_init.diff added

Ok, I finally have a working redmine install for testing purpose. It appears that my previous patch contains a bug in the functional test. I fixed it in this new patch (which should be the last one!).

Actions

Copy link