https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292010-08-01T12:29:03ZRedmineRedmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=188722010-08-01T12:29:03ZOrgad Shaneh
<ul><li><strong>File</strong> <a href="/attachments/4233">rtl-layout.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4233/rtl-layout.patch">rtl-layout.patch</a> added</li><li><strong>File</strong> <a href="/attachments/4234">he.yml</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4234/he.yml">he.yml</a> added</li></ul><p>This approach is similar to <a href="http://qt.gitorious.org/qt/qt/blobs/4.6/translations/qt_he.ts#line888" class="external">Qt translation</a>. It requires no changes to base.rhtml when adding a new RTL language. All the translator needs to do is define direction: RTL in the yml file.</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=191012010-08-07T22:38:15ZEbrahim Mohammadi
<ul><li><strong>File</strong> <a href="/attachments/4261">rtl.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4261/rtl.patch">rtl.patch</a> added</li><li><strong>Assignee</strong> set to <i>Holger Just</i></li></ul><p>Find a patch against trunk in attachment that implements RTL support, and adds direction string to all locale files. I've used rtl.css of Orgad Shaneh.</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=191022010-08-07T22:49:36ZHolger Just
<ul><li><strong>Category</strong> set to <i>Translations</i></li><li><strong>Assignee</strong> changed from <i>Holger Just</i> to <i>Azamat Hackimov</i></li></ul><p>The patch looks good to me. Looks like a clean approach. I haven't tried it though.</p>
<p>Could you please check and confirm that it works with all distributed themes? Once that's done, I vote for inclusion / replacement of the RTL theme.</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=191042010-08-08T05:56:57ZOrgad Shaneh
<ul><li><strong>File</strong> <a href="/attachments/4262">rtl.css</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4262/rtl.css">rtl.css</a> added</li><li><strong>File</strong> <a href="/attachments/4263">he.yml</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4263/he.yml">he.yml</a> added</li></ul><p>I wouldn't submit it without checking :)</p>
<p>I added another entry for <pre> in the css, and made a few changes in the translation file (can I have svn account for the translation, instead of posting it here with each change?)</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=191092010-08-08T09:18:21ZHolger Just
<ul></ul><p>Orgad,</p>
<ol>
<li>Please keep this ticket for the RTL changes only, for updated of the Hebrew translation, please use a new ticket.</li>
<li>Please post patches instead of whole files.</li>
</ol>
<p>The question for further checking was not meant to insult you. Sorry if that may have sounded so. I just want to make sure that the patches are of the known good quality. As I am unable to check it myself due to my lack of RTL language knowledge, I just ask the community :)</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=191112010-08-08T10:13:10ZOrgad Shaneh
<ul></ul><p>Regarding Mohammad's patch, the rtl stylesheet must be referenced after all other stylesheets (ses the difference between <a href="/attachments/4233/rtl-layout.patch">rtl-layout.patch</a> and <a class="attachment" href="https://www.redmine.org/attachments/4261">rtl.patch</a>)</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=191152010-08-08T14:36:27ZHolger Just
<ul></ul><p>This is a rather difficult question (with larger boundaries as only this patch).<br />The question is: which parts of the stylesheets should be evaluated last (and thus has the greatest power to overwrite stuff without having to resort to <code>!important</code>.</p>
In my opinion, the order should be:
<ol>
<li>application style</li>
<li>specific module and plugin styles</li>
<li>themes</li>
</ol>
<p>The RTL patch then should be inserted after the module styles.</p>
<p>Unfortunately the theme is currently loaded first which makes it very hard to overwrite default plugin styles. However, I think the RTL style provide defaults which should be easily overwritable by plugins. If this is a problem with current core styles, I think those should be changes instead. In this sense, I consider the rtl.css as a part of application.css which should be evaluated in the same context.</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=191242010-08-08T16:17:35ZOrgad Shaneh
<ul></ul><p>It should at least appear after context menu (which it overrides)</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=195552010-08-19T18:27:55ZAzamat Hackimov
<ul><li><strong>File</strong> <a href="/attachments/4333">context_menu_rtl.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4333/context_menu_rtl.patch">context_menu_rtl.patch</a> added</li></ul><p>I commited RTL layout. For context menu I think better create own rtl css file, see patch for my idea (patch not good, need more work from ruby-guru).</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=195872010-08-20T22:13:43ZEric Davis
<ul><li><strong>File</strong> <a href="/attachments/4338">rtl-error.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4338/rtl-error.png">rtl-error.png</a> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>7</i></li><li><strong>Assignee</strong> changed from <i>Azamat Hackimov</i> to <i>Eric Davis</i></li><li><strong>Target version</strong> set to <i>1.0.1</i></li></ul><p>Azamat sent me a style bug for me to look at with the context menu before the 1.0.1 release. The context menu arrows are on the right instead of the left.</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=196112010-08-22T06:58:11ZOrgad Shaneh
<ul></ul><p>See <a href="http://www.redmine.org/issues/6012#note-6" class="external">note 6</a> (Is there a normal way to reference a note?)</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=196162010-08-22T18:49:47ZEric Davis
<ul></ul><p>Holger Just and Orgad Shaneh:</p>
<p>I think it would be good to discuss the stylesheet load order in the forums. Based on Redmine's limited theme support, there are several edge cases that we would need to think about in order to support application, theme, rtl, and plugin styles.</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=196172010-08-22T19:11:18ZEric Davis
<ul><li><strong>Category</strong> changed from <i>Translations</i> to <i>UI</i></li><li><strong>Status</strong> changed from <i>7</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Updated the context menu to support RTL using Azamat's patch. I also fixed the icon's css, the context menu added it's own styles that override the rtl.css. (<a class="changeset" title="Add RTL support to the context menu. #6012" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4014">r4014</a>)</p> Redmine - Patch #6012: RTL layouthttps://www.redmine.org/issues/6012?journal_id=196182010-08-22T19:47:34ZEric Davis
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged to 1.0-stable.</p>