Project

General

Profile

Actions
Copy link

Patch #6498

closed

Make options parameter optional in User#allowed_to_globally?

Added by Jan from Planio www.plan.io almost 15 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Baptiste Barth
Category:
Permissions and roles
Target version:
2.6.0
Start date:
2010-09-26
Due date:
% Done:

0%

Estimated time:

Description

It's optional in allowed_to? so it would make sense to make it optional in allowed_to_globally?, too.

Patch is attached.

Files

user.rb.patch (476 Bytes) user.rb.patch Jan from Planio www.plan.io, 2010-09-26 20:13
Actions
Copy link
 #1

Updated by Victor Ilyukevich over 14 years ago

+1

Actions
Copy link
 #2

Updated by Jean-Baptiste Barth almost 11 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Baptiste Barth
  • Target version set to 2.6.0

Yes obviously. This method is not used anywhere in the Redmine code base anymore, but I find lots of usages in plugins on Github (https://github.com/search?o=desc&q=allowed_to_globally&s=indexed&type=Code)

On a side note Jan: I'm trying to spend some time reviewing/merging patches these days, and obviously 4 years old patches with not even a reply are ridiculous. If you want to drop me an email with things you think I can merge directly, let me know (or we can chat about that on freenode eventually, nick=salvor but my IRC client is at $WORK so I'm only behind on weekdays).

Actions
Copy link

Also available in: Atom PDF