Defect #7000: Project filter not applied on versions in Gantt chart - Redmine

Actions

Copy link

Defect #7000

closed

Project filter not applied on versions in Gantt chart

Added by Tom Turner over 13 years ago. Updated about 13 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Gantt

Target version:

1.2.0

Start date:

2010-11-29

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

1.0.4

Description

Redmine Version 1.0.4

I have versions which have Not shared set on them. This works correctly for things like adding new issues (I cannot add an issue to a version that is not shared with that project). However when I construct a view of an issue list which uses a project filter, the Gantt chart for that view includes all the versions across the entire install of Redmine regardless of the sharing settings.

For example:
Project 1 has Version 1 and Version 2
Project 2 has Version 3 and Version 4

If I construct a filter which says "All issues that are not in Project 2" I get all the issues filtered correctly but all four versions are shown in the Gantt chart.

I know that the Gantt rewrite for 1.1.0 is imminent but this issue seems like it should be fairly simple to correct (unfortunately I don't know Ruby well enough to understand how to do it myself). It looks like it just needs something added to the filter on line 32 of the gantt controller (http://www.redmine.org/projects/redmine/repository/entry/tags/1.0.4/app/controllers/gantts_controller.rb#L32)

Is there any chance of someone looking at whether this could be fixed with a simple fix to the version filter, please?

Files

Download all files

gantt_filter_not_filtering.png (65.3 KB) gantt_filter_not_filtering.png		Cyber Sprocket, 2011-01-10 20:50
hide_closed_versions_on_gantt.patch (503 Bytes) hide_closed_versions_on_gantt.patch		Cyber Sprocket, 2011-01-12 21:12

Related issues

Actions

Copy link

Updated by Cyber Sprocket over 13 years ago

File gantt_filter_not_filtering.png gantt_filter_not_filtering.png added

Using the latest 1.1 stable release, we see all versions on the build listed even though we set a filter to show just version 8.0.

Actions

Copy link

Updated by Cyber Sprocket over 13 years ago

File hide_closed_versions_on_gantt.patch hide_closed_versions_on_gantt.patch added

I have created this patch for the gantt charts to hide the closed versions on the gantt.

This is a hard-coded fix. I'd like to know more about Ruby so we could add an entry on the main administration settings panel (or project settings panel) to provide a checkbox that says [ ] Hide closed versions on gantt.

Anyway - here is the patch:

Index: lib/redmine/helpers/gantt.rb
===================================================================
--- lib/redmine/helpers/gantt.rb        (revision 4672)
+++ lib/redmine/helpers/gantt.rb        (working copy)
@@ -200,7 +200,9 @@

         # Third, Versions
         project.versions.sort.each do |version|
-          render_version(version, options)
+         if !version.closed?
+              render_version(version, options)
+         end
           return if abort?
         end