Project

General

Profile

Actions
Copy link

Defect #7794

closed

Internal server error on formatting an issue as a PDF in Japanese

Added by Yuki Sonoda over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toshi MARUYAMA
Category:
PDF export
Target version:
1.1.3
Start date:
2011-03-06
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
1.1.2

Description

IssuesController#show fails with internal server error when
  • params[:format] is pdf
  • AcceptLanguage: ja
  • @issue.description contains an ASCII control character.

This is because the map SJIS_widths does not have a mapping for control characters and it leads concatenation of a String and nil at vendor/plugins/rfpdf/lib/rfpdf/japanese.rb:182.

The attached patch fixes this problem.

Files

Download all files
ja-pdf.patch (1.67 KB) ja-pdf.patch Yuki Sonoda, 2011-03-06 13:23
test-1-org.pdf (5.48 KB) test-1-org.pdf Jun NAITOH, 2011-04-01 00:54
test-1-ja-pdf.patch.pdf (5.98 KB) test-1-ja-pdf.patch.pdf Jun NAITOH, 2011-04-01 00:54
test-1-ja-pdf_fix.patch.pdf (5.48 KB) test-1-ja-pdf_fix.patch.pdf Jun NAITOH, 2011-04-01 00:54
ja-pdf_fix.patch (627 Bytes) ja-pdf_fix.patch Jun NAITOH, 2011-04-01 00:54

Related issues

Related to Redmine - Defect #61: Broken character encoding in pdf exportClosedToshi MARUYAMA

Actions
Related to Redmine - Defect #6505: PDF export broken with Japanese (Gannt and Issue Tracking)Closed2010-09-27

Actions
Actions
Copy link
 #1

Updated by Toshi MARUYAMA over 13 years ago

  • Status changed from New to 7
  • Assignee set to Toshi MARUYAMA
Actions
Copy link
 #2

Updated by Toshi MARUYAMA over 13 years ago

  • Tracker changed from Patch to Defect
  • Subject changed from Fix for an internal server error on formatting an issue as a PDF in Japanese to Internal server error on formatting an issue as a PDF in Japanese
Actions
Copy link
 #3

Updated by Toshi MARUYAMA over 13 years ago

  • Target version set to 1.1.3
  • Affected version (unused) set to 1.1.2
  • Affected version set to 1.1.2

I confirmed Japanese locale has problem.
Korean, Simplified and Traditional Chinese don't have problem.

Actions
Copy link
 #4

Updated by Toshi MARUYAMA over 13 years ago

  • Status changed from 7 to Closed
  • Resolution set to Fixed

Fixed by r5183 in trunk and r5184 in 1.1-stable.
Thanks.

Actions
Copy link
 #5

Updated by Jun NAITOH over 13 years ago

When I tested #61 in trunk, now. I found ja-pdf.patch problem.

I retested in Redmine 1.1.2 + ja-pdf.patch.

Test string is "A B C D E F G H I J K L M N O P Q R S T U V W X Y Z a b c d e f g h i j k l m n o p q r s t u v w x y z 1 2 3 4 5 6 7 8 9 0"

  • Redmine 1.1.2 : test-1-org.pdf
  • Redmine 1.1.2 + ja-pdf.patch : test-1-ja-pdf.patch.pdf

The width of the ASCII character has changed by ja-pdf.patch.

I rewrite ja-pdf_fix.patch for Redmine 1.1.2.

  • Redmine 1.1.2 + ja-pdf_fix.patch : test-1-ja-pdf_fix.patch.pdf
Actions
Copy link
 #6

Updated by Toshi MARUYAMA over 13 years ago

  • Status changed from Reopened to Closed

I have committed r5271 in 1.1-stable.
Thanks.

Actions
Copy link
 #7

Updated by Toshi MARUYAMA over 13 years ago

  • Status changed from Closed to Reopened
Actions
Copy link
 #8

Updated by Toshi MARUYAMA over 13 years ago

  • Status changed from Reopened to Closed

Sorry, I could not understand note 5.
I committed r5281 in trunk and r5282 in stable-1.1.
Thanks.

Actions
Copy link

Also available in: Atom PDF