Defect #14658
closed
Wrong activity timezone on user page
0%
Description
http://www.redmine.org/users/11192
I use Japanese standard time (+0900) on redmine.org.
#14653#note-3 note-3 should be on 2013-08-10.
Files
Related issues
Updated by Toshi MARUYAMA over 11 years ago
CI server time is a head of 2 hours.
Now, It is 2013-08-09 23:50 UTC.
But CI server time is Sat Aug 10 03:50:03 +0200 2013.
http://www.redmine.org/builds/index.html
Updated by Etienne Massip over 11 years ago
- Category set to Website (redmine.org)
Updated by Matthew Peterson over 10 years ago
I'm fairly sure this is a duplicate of #1048
Updated by Toshi MARUYAMA about 10 years ago
- Category deleted (
Website (redmine.org))
Updated by Toshi MARUYAMA about 10 years ago
- Related to Defect #1048: Day grouping on Activity view ignores user's time zone added
Updated by Toshi MARUYAMA about 10 years ago
Matthew Peterson wrote:
I'm fairly sure this is a duplicate of #1048
No.
I mean this issue is on user page.
http://www.redmine.org/users/11192
Updated by Toshi MARUYAMA about 10 years ago
Activity page works correctly.
http://www.redmine.org/activity?from=2013-08-10&user_id=11192
Updated by Kit Grose almost 9 years ago
This issue is affecting our installation too. Interestingly, it seems to only affect one of our users (not all). That user has the same timezone set in their preferences as everyone else.
When other users visit that user's page it shows up incorrectly, and when that user visits any other user's page, the times are shown correctly.
We have v2.3.0.stable installed, though.
Updated by
Updated by Go MAEDA almost 8 years ago
- Category set to Activity view
- Target version set to 3.2.5
This issue can be fixed by the following patch.
ActivitiesController#show have been fixed in r9726 (diff) in order to handle time zones properly. This patch applies the same fix to UsersController#show.
Index: app/controllers/users_controller.rb
===================================================================
--- app/controllers/users_controller.rb (revision 16111)
+++ app/controllers/users_controller.rb (working copy)
@@ -74,7 +74,7 @@
respond_to do |format|
format.html {
events = Redmine::Activity::Fetcher.new(User.current, :author => @user).events(nil, nil, :limit => 10)
- @events_by_day = events.group_by(&:event_date)
+ @events_by_day = events.group_by {|event| User.current.time_to_date(event.event_datetime)}
render :layout => 'base'
}
format.api
Updated by Go MAEDA almost 8 years ago
- Related to Defect #10996: Time zones lost when upgrading from Redmine 1.4 to 2.0 added
Updated by Go MAEDA almost 8 years ago
- Has duplicate Defect #24707: Activity in User Profile shows incorrect date/time, dependent to Time zone added
Updated by Jean-Philippe Lang almost 8 years ago
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Fix committed, thanks.
Updated by kaz k almost 8 years ago
- File Defect_14658_Patch_Test_resultsScreenShots.zip Defect_14658_Patch_Test_resultsScreenShots.zip added
I tested the patch in note 10 (#14658#note-10).
Environment
- Redmine 3.1.1 (Windows) (not the target version :-) )
- Time Zone of the viewer: GMT+09:00(Tokyo).
Result
The patch worked well. Attached is the screen captures of 'Before' and 'After' patch with comments (Zipped).
Thank you.
Updated by Go MAEDA almost 8 years ago
kaz k, thanks for the screenshots.
This problem will be fixed in upcoming 3.2.5 / 3.3.2 / 3.4.0.
Your #24707 triggered me to investigate this issue. Thank you again.
Updated by Jean-Philippe Lang almost 8 years ago
- Status changed from Resolved to Closed