0001-Remove-blank-keys-from-sort-criterias.patch - Redmine

Defect #30009 » 0001-Remove-blank-keys-from-sort-criterias.patch

Marius BĂLTEANU, 2018-11-25 21:35

lib/redmine/sort_criteria.rb
87	87	private
88	88
89	89	def normalize!
	90	self.reject! {\|s\| s.first.blank? }
90	91	self.collect! {\|s\| s = Array(s); [s.first, (s.last == false \|\| s.last.to_s == 'desc') ? 'desc' : 'asc']}
91	92	self.replace self.first(3)
92	93	end

         assert_equal [['priority', 'desc'], ['tracker', 'asc'], ['priority', 'asc']], q.sort_criteria
       end
       def test_sort_criteria_should_remove_blank_keys
         q = IssueQuery.new
         q.sort_criteria = [['priority', 'desc'], [nil, 'desc'], ['', 'asc'], ['project', 'asc']]
         assert_equal [['priority', 'desc'], ['project', 'asc']], q.sort_criteria
       end
       def test_set_sort_criteria_with_hash
         q = IssueQuery.new
         q.sort_criteria = {'0' => ['priority', 'desc'], '2' => ['tracker']}

(2-2/2)