0001-Fix-sort-projects-table-by-custom-field.patch - Redmine

         return @available_columns if @available_columns
         @available_columns = self.class.available_columns.dup
         @available_columns += ProjectCustomField.visible.
                                 map {|cf| QueryAssociationCustomFieldColumn.new(:project, cf) }
                                 map {|cf| QueryCustomFieldColumn.new(cf) }
         @available_columns
       end

       def test_index_as_list_should_format_column_value
         get :index, :params => {
           :c => ['name', 'status', 'short_description', 'homepage', 'parent_id', 'identifier', 'is_public', 'created_on', 'project.cf_3'],
           :c => ['name', 'status', 'short_description', 'homepage', 'parent_id', 'identifier', 'is_public', 'created_on', 'cf_3'],
           :display_type => 'list'
+        }
         assert_response :success
-...
             assert_select 'td.identifier', :text => 'ecookbook'
             assert_select 'td.is_public', :text => 'Yes'
             assert_select 'td.created_on', :text => format_time(project.created_on)
             assert_select 'td.project_cf_3.list', :text => 'Stable'
             assert_select 'td.cf_3.list', :text => 'Stable'
           end
           assert_select 'tr[id=?]', 'project-4' do
             assert_select 'td.parent_id a[href=?]', '/projects/ecookbook', :text => 'eCookbook'
-...
         end
       end
       def test_index_sort_by_custom_field
         @request.session[:user_id] = 1
         cf = ProjectCustomField.find(3)
         CustomValue.create!(:custom_field => cf, :customized => Project.find(2), :value => 'Beta')
         get(
           :index,
           :params => {
             :display_type => 'list',
             :c => ['name', 'identifier', 'cf_3'],
             :set_filter => 1,
             :sort => "cf_#{cf.id}:asc"
+          }
+        )
         assert_response :success
         assert_equal(
           ['Beta', 'Stable'],
           columns_values_in_list('cf_3').reject {|p| p.empty?}
+        )
       end
       def test_autocomplete_js
         get(
           :autocomplete,

test/unit/project_query_test.rb
58	58
59	59	def test_available_columns_should_include_project_custom_fields
60	60	query = ProjectQuery.new
61		assert_include :"project.cf_3", query.available_columns.map(&:name)
	61	assert_include :cf_3, query.available_columns.map(&:name)
62	62	end
63	63	end

Project

General

Profile

Redmine

Defect #32769 » 0001-Fix-sort-projects-table-by-custom-field.patch