32240_add_download_button_v4.patch - Redmine

         when 'Issue'
           object.visible? && html ? link_to_issue(object) : "##{object.id}"
         when 'Attachment'
           html ? link_to_attachment(object) : object.filename
           if html
             content_tag(
               :span,
               link_to_attachment(object) +
               link_to_attachment(
                 object,
                 :class => ['icon-only', 'icon-download'],
                 :title => l(:button_download),
                 :download => true
+              )
+            )
           else
             object.filename
           end
         when 'CustomValue', 'CustomFieldValue'
           if object.custom_field
             f = object.custom_field.format.formatted_custom_value(self, object, html)

     table.list td.id { width: 2%; text-align: center;}
     table.list td.name, table.list td.description, table.list td.subject, table.list td.comments, table.list td.roles, table.list td.attachments, table.list td.text,  table.list td.short_description {text-align: left;}
     table.list td.attachments a {display:block;}
     table.list td.attachments span {display: block; height: 16px;}
     table.list td.attachments span a.icon-download {display: inline-block; visibility: hidden;}
     table.list td.attachments span:hover a.icon-download {visibility: visible;}
     table.list td.tick {width:15%}
     table.list td.checkbox { width: 15px; padding: 2px 0 0 0; }
     table.list .checkbox input {padding:0px; height: initial;}

         assert_select 'td.attachments'
         assert_select 'tr#issue-2' do
           assert_select 'td.attachments' do
             assert_select 'a', :text => 'source.rb'
             assert_select 'a', :text => 'picture.jpg'
             assert_select 'span:nth-of-type(1)' do
               assert_select 'a[href=?]', '/attachments/4', :text => 'source.rb'
               assert_select 'a[href=?].icon-download', '/attachments/download/4/source.rb'
             end
             assert_select 'span:nth-of-type(2)' do
               assert_select 'a[href=?]', '/attachments/10', :text => 'picture.jpg'
               assert_select 'a[href=?].icon-download', '/attachments/download/10/picture.jpg'
             end
           end
         end
       end

         assert_response :success
         # link to the attachment
         link = css_select(".cf_#{@field.id} .value a")
         link = css_select(".cf_#{@field.id} .value a:not(.icon-download)")
         assert_equal 1, link.size
         assert_equal "testfile.txt", link.text

Redmine