Project

General

Profile

Patch #30919 » 0001-Add-Group-Issue-Custom-Fields-functionality.patch

For Redmine 4.2.1 - Frederico Camara, 2021-07-28 16:12

View differences:

app/controllers/projects_controller.rb
201 201
    @issue_category ||= IssueCategory.new
202 202
    @member ||= @project.members.new
203 203
    @trackers = Tracker.sorted.to_a
204
    @cfs=AttributeGroup.joins(:custom_fields).joins(:tracker).
205
      where(project_id: @project, tracker_id: @trackers, :custom_fields => {id: @project.all_issue_custom_fields.pluck(:id)}).
206
      pluck("trackers.id", "id", "name", "position","attribute_group_fields.id", "attribute_group_fields.position",
207
        "custom_fields.id", "custom_fields.name", "custom_fields.position").sort_by{|x| [x[3], x[5]]}
204 208

  
205 209
    @version_status = params[:version_status] || 'open'
206 210
    @version_name = params[:version_name]
......
231 235
    end
232 236
  end
233 237

  
238
  def groupissuescustomfields
239
    # clean invalid values: invalid cfs, empty cf lists, empty groups
240
    group_issues_custom_fields = (JSON.parse params[:group_issues_custom_fields]).
241
      each{|tid,v| v.replace(v.select{|k,v| v["cfs"] ? v["cfs"].delete_if{|k,v| @project.all_issue_custom_fields.pluck(:id).include?(v)} : v})}.
242
      each{|tid,v| v.delete_if{|k,v| v["cfs"].blank?}}.
243
      delete_if{|k,v| v.blank?}
244

  
245
    groups = AttributeGroup.where(project_id: @project.id).collect(&:id)
246
    fields = AttributeGroupField.where(attribute_group_id: groups).collect(&:id)
247
    group_issues_custom_fields.each do |tid,v|
248
      v.each do |gp, g|
249
        gid = groups.shift
250
        if gid.nil?
251
          gid=AttributeGroup.create(project_id: @project.id, tracker_id: tid, name: g["name"].nil? ? nil : g["name"], position: gp).id
252
        else
253
          AttributeGroup.update(gid, project_id: @project.id, tracker_id: tid, name: g["name"].nil? ? nil : g["name"], position: gp)
254
        end
255
        g['cfs'].each do |cfp, cf|
256
          cfid = fields.shift
257
          if cfid.nil?
258
            AttributeGroupField.create(attribute_group_id: gid, custom_field_id: cf, position: cfp)
259
          else
260
            AttributeGroupField.update(cfid, attribute_group_id: gid, custom_field_id: cf, position: cfp)
261
          end
262
        end
263
      end
264
    end
265
    AttributeGroupField.where(id: fields).delete_all
266
    AttributeGroup.where(id: groups).destroy_all
267
    flash[:notice] = l(:notice_successful_update)
268
    redirect_to settings_project_path(@project, :tab => 'groupissuescustomfields')
269
  end
270

  
234 271
  def archive
235 272
    unless @project.archive
236 273
      flash[:error] = l(:error_can_not_archive_project)
app/helpers/issues_helper.rb
353 353
    r.to_html
354 354
  end
355 355

  
356
  def render_half_width_custom_fields_rows(issue)
357
    values = issue.visible_custom_field_values.reject {|value| value.custom_field.full_width_layout?}
358
    return if values.empty?
359

  
360
    half = (values.size / 2.0).ceil
361
    issue_fields_rows do |rows|
362
      values.each_with_index do |value, i|
363
        m = (i < half ? :left : :right)
364
        rows.send m, custom_field_name_tag(value.custom_field), custom_field_value_tag(value), :class => value.custom_field.css_classes
365
      end
366
    end
367
  end
368

  
369
  def render_full_width_custom_fields_rows(issue)
370
    values = issue.visible_custom_field_values.select {|value| value.custom_field.full_width_layout?}
371
    return if values.empty?
372

  
356
  def group_by_keys(project_id, tracker_id, custom_field_values)
357
    keys_grouped = AttributeGroupField.joins(:attribute_group).
358
      where(:attribute_groups => {project_id: project_id, tracker_id: tracker_id}).
359
      order("attribute_groups.position", :position).pluck(:name, :custom_field_id).group_by(&:shift)
360
    custom_fields_grouped = { nil => (keys_grouped[nil].nil? ? [] :
361
      keys_grouped[nil].map{|n| custom_field_values.select{|x| x.custom_field[:id] == n[0]}}.flatten) |
362
      custom_field_values.select{|y| ! keys_grouped.values.flatten.include?(y.custom_field[:id])}}
363
    keys_grouped.reject{|k,v| k == nil}.each{|k,v| custom_fields_grouped[k] =
364
      v.map{|n| custom_field_values.select{|x| x.custom_field[:id] == n[0]}}.flatten}
365
    custom_fields_grouped
366
  end
367

  
368
  def render_custom_fields_rows(issue)
373 369
    s = ''.html_safe
374
    values.each_with_index do |value, i|
375
      attr_value_tag = custom_field_value_tag(value)
376
      next if attr_value_tag.blank?
377

  
378
      content =
379
        content_tag('hr') +
380
        content_tag('p', content_tag('strong', custom_field_name_tag(value.custom_field) )) +
381
        content_tag('div', attr_value_tag, class: 'value')
382
      s << content_tag('div', content, class: "#{value.custom_field.css_classes} attribute")
370
    group_by_keys(issue.project_id, issue.tracker_id, issue.visible_custom_field_values).
371
      each do |title, values|
372
      if values.present?
373
        s << content_tag('h4', title, :style => 'background: #0001; padding: 0.3em;') unless title.nil?
374
        while values.present?
375
          unless values[0].custom_field.full_width_layout?
376
            lr_values = []
377
            while values.present? && ! values[0].custom_field.full_width_layout?
378
              lr_values += [ values.shift ]
379
            end
380
            half = (lr_values.size / 2.0).ceil
381
            s << issue_fields_rows do |rows|
382
              lr_values.each_with_index do |value, i|
383
                m = (i < half ? :left : :right)
384
                rows.send m, custom_field_name_tag(value.custom_field), custom_field_value_tag(value), :class => value.custom_field.css_classes
385
              end
386
            end
387
          else
388
            while values.present? && values[0].custom_field.full_width_layout?
389
              value=values.shift
390
              content = content_tag('div', custom_field_name_tag(value.custom_field) + ":", :class => 'label') +
391
                        content_tag('div', custom_field_value_tag(value), :class => 'value')
392
              content = content_tag('div', content, :class => "#{value.custom_field.css_classes} attribute")
393
              s << content_tag('div', content, :class => 'splitcontent')
394
            end
395
          end
396
        end
397
      end
383 398
    end
384 399
    s
385 400
  end
......
442 457
        end
443 458
      end
444 459
    end
445
    issue.visible_custom_field_values(user).each do |value|
446
      cf_value = show_value(value, false)
447
      next if cf_value.blank?
448

  
449
      if html
450
        items << content_tag('strong', "#{value.custom_field.name}: ") + cf_value
451
      else
452
        items << "#{value.custom_field.name}: #{cf_value}"
460
    group_by_keys(issue.project_id, issue.tracker_id, issue.visible_custom_field_values(user)).each do |title, values|
461
      if values.present?
462
        unless title.nil?
463
          if html
464
            items << content_tag('strong', "#{title}")
465
          else
466
            items << "#{title}"
467
          end
468
        end
469
        values.each do |value|
470
          cf_value = show_value(value, false)
471
          if html
472
            items << content_tag('strong', "#{value.custom_field.name}: ") + cf_value
473
          else
474
            items << "#{value.custom_field.name}: #{cf_value}"
475
          end
476
        end
453 477
      end
454 478
    end
455 479
    items
......
458 482
  def render_email_issue_attributes(issue, user, html=false)
459 483
    items = email_issue_attributes(issue, user, html)
460 484
    if html
461
      content_tag('ul', items.map{|s| content_tag('li', s)}.join("\n").html_safe, :class => "details")
485
      content_tag('ul', items.select{|s| s.is_a? String}.map{|s| content_tag('li', s)}.join("\n").html_safe, :class => "details") + "\n" +
486
        items.select{|s| !s.is_a? String}.map{|item| content_tag('div', item.shift) + "\n" +
487
        content_tag('ul', item.map{|s| content_tag('li', s)}.join("\n").html_safe, :class => "details")}.join("\n").html_safe
462 488
    else
463
      items.map{|s| "* #{s}"}.join("\n")
489
      items.select{|s| s.is_a? String}.map{|s| "* #{s}"}.join("\n") + "\n" +
490
        items.select{|s| !s.is_a? String}.map{|item| "#{item.shift}\n" + item.map{|s| "* #{s}"}.join("\n")}.join("\n")
464 491
    end
465 492
  end
466 493

  
app/helpers/projects_helper.rb
39 39
        {:name => 'boards', :action => :manage_boards,
40 40
         :partial => 'projects/settings/boards', :label => :label_board_plural},
41 41
        {:name => 'activities', :action => :manage_project_activities,
42
         :partial => 'projects/settings/activities', :label => :label_time_tracking}
42
         :partial => 'projects/settings/activities', :label => :label_time_tracking},
43
        {:name => 'groupissuescustomfields', :action => :edit_project,
44
         :partial => 'projects/settings/groupissuescustomfields', :label => :grouped_cf}
43 45
      ]
44 46
    tabs.
45 47
      select {|tab| User.current.allowed_to?(tab[:action], @project)}.
app/models/attribute_group.rb
1
class AttributeGroup < ActiveRecord::Base
2
  belongs_to :project
3
  belongs_to :tracker
4
  has_many :attribute_group_fields, :dependent => :delete_all
5
  has_many :custom_fields, :through => :attribute_group_fields
6
  acts_as_positioned
7

  
8
  scope :sorted, lambda { order(:position) }
9
end
app/models/attribute_group_field.rb
1
class AttributeGroupField < ActiveRecord::Base
2
  belongs_to :attribute_group
3
  belongs_to :custom_field
4
  acts_as_positioned
5

  
6
  scope :sorted, lambda { order(:position) }
7
end
app/models/custom_field.rb
26 26
           :class_name => 'CustomFieldEnumeration',
27 27
           :dependent => :delete_all
28 28
  has_many :custom_values, :dependent => :delete_all
29
  has_many :attribute_group_fields, :dependent => :delete_all
29 30
  has_and_belongs_to_many :roles,
30 31
                          :join_table => "#{table_name_prefix}custom_fields_roles#{table_name_suffix}",
31 32
                          :foreign_key => "custom_field_id"
app/models/project.rb
53 53
  has_many :changesets, :through => :repository
54 54
  has_one :wiki, :dependent => :destroy
55 55
  # Custom field for the project issues
56
  has_many :attribute_groups, :dependent => :destroy
57
  has_many :attribute_group_fields, :through => :attribute_groups
56 58
  has_and_belongs_to_many :issue_custom_fields,
57 59
                          lambda {order(:position)},
58 60
                          :class_name => 'IssueCustomField',
app/models/tracker.rb
36 36
  has_and_belongs_to_many :custom_fields, :class_name => 'IssueCustomField',
37 37
                          :join_table => "#{table_name_prefix}custom_fields_trackers#{table_name_suffix}",
38 38
                          :association_foreign_key => 'custom_field_id'
39
  has_many :attribute_groups, :dependent => :destroy
40
  has_many :attribute_group_fields, :through => :attribute_groups
39 41
  acts_as_positioned
40 42

  
41 43
  validates_presence_of :default_status
app/views/issues/_form_custom_fields.html.erb
1
<% custom_field_values = @issue.editable_custom_field_values %>
2
<% custom_field_values_full_width = custom_field_values.select { |value| value.custom_field.full_width_layout? } %>
3
<% custom_field_values -= custom_field_values_full_width %>
4

  
5
<% if custom_field_values.present? %>
6
<div class="splitcontent">
7
<div class="splitcontentleft">
8
<% i = 0 %>
9
<% split_on = (custom_field_values.size / 2.0).ceil - 1 %>
10
<% custom_field_values.each do |value| %>
11
  <p><%= custom_field_tag_with_label :issue, value, :required => @issue.required_attribute?(value.custom_field_id) %></p>
12
<% if i == split_on -%>
13
</div><div class="splitcontentright">
14
<% end -%>
15
<% i += 1 -%>
16
<% end -%>
17
</div>
18
</div>
19
<% end %>
20

  
21
<% custom_field_values_full_width.each do |value| %>
22
  <p><%= custom_field_tag_with_label :issue, value, :required => @issue.required_attribute?(value.custom_field_id) %></p>
23
  <%= wikitoolbar_for "issue_custom_field_values_#{value.custom_field_id}", preview_issue_path(:project_id => @issue.project, :issue_id => @issue.id) if value.custom_field.full_text_formatting? %>
1
<% group_by_keys(@issue.project_id, @issue.tracker_id, @issue.editable_custom_field_values).each do |title,values| %>
2
  <% if values.present? %>
3
    <%= content_tag('h4', title, :style => 'background: #0001; padding: 0.3em;') unless title.nil? %>
4
    <% while values.present? %>
5
      <% if values[0].custom_field.full_width_layout? %>
6
        <% while values.present? && values[0].custom_field.full_width_layout? %>
7
          <% value = values.shift %>
8
          <p><%= custom_field_tag_with_label :issue, value, :required => @issue.required_attribute?(value.custom_field_id) %></p>
9
          <%= wikitoolbar_for "issue_custom_field_values_#{value.custom_field_id}", preview_issue_path(:project_id => @issue.project, :issue_id => @issue.id) if value.custom_field.full_text_formatting? %>
10
        <% end %>
11
      <% else %>
12
        <div class="splitcontent">
13
          <% lr_values = [] %>
14
          <% while values.present? && ! values[0].custom_field.full_width_layout? %>
15
            <% lr_values += [ values.shift ] %>
16
          <% end %>
17
          <div class="splitcontentleft">
18
            <% i = 0 %>
19
            <% split_on = (lr_values.size / 2.0).ceil - 1 %>
20
            <% lr_values.each do |value| %>
21
              <p><%= custom_field_tag_with_label :issue, value, :required => @issue.required_attribute?(value.custom_field_id) %></p>
22
              <%= wikitoolbar_for "issue_custom_field_values_#{value.custom_field_id}", preview_issue_path(:project_id => @issue.project, :issue_id => @issue.id) if value.custom_field.full_text_formatting? %>
23
              <% if i == split_on %>
24
                </div><div class="splitcontentright">
25
              <% end %>
26
              <% i += 1 %>
27
            <% end %>
28
          </div>
29
        </div>
30
      <% end %>
31
    <% end %>
32
  <% end %>
24 33
<% end %>
app/views/issues/show.html.erb
75 75
    rows.right l(:label_spent_time), issue_spent_hours_details(@issue), :class => 'spent-time'
76 76
  end
77 77
end %>
78
<%= render_half_width_custom_fields_rows(@issue) %>
78
<%= render_custom_fields_rows(@issue) %>
79 79
<%= call_hook(:view_issues_show_details_bottom, :issue => @issue) %>
80 80
</div>
81 81

  
......
98 98
  <%= link_to_attachments @issue, :thumbnails => true %>
99 99
<% end %>
100 100

  
101
<%= render_full_width_custom_fields_rows(@issue) %>
102

  
103 101
<%= call_hook(:view_issues_show_description_bottom, :issue => @issue) %>
104 102

  
105 103
<% if !@issue.leaf? || User.current.allowed_to?(:manage_subtasks, @project) %>
app/views/projects/settings/_groupissuescustomfields.html.erb
1
<p><%= select_tag "tracker_id", options_from_collection_for_select(@project.trackers.collect, "id", "name"), {:required => true, :onchange => "refresh_trackers(this);"} %><p>
2

  
3
<div id='custom_fields_form'>
4
  <% @project.trackers.each do |t| %>
5
  <div id='tracker_<%= t.id %>' class='tracker'>
6
    <span style="color: #888;"><%= l(:changed_cf_position) %></span>
7
    <ul class='sortable_items sortable_tracker-<%= t.id %> nil not_a_group'>
8
      <% @cfs.select{|x| x[0]==t.id && x[2]==nil}.each do |x| %>
9
      <li id="<%= x[6] %>" pos="<%= x[8] %>"><%= x[7] %></li>
10
      <% end %>
11
    </ul>
12
    <span style="color: #888;"><%= l(:global_cf_position) %></span>
13
    <ul class="sortable_items sortable_tracker-<%= t.id %> unsorted not_a_group">
14
      <% Issue.new(project_id: @project.id, tracker_id: t.id).custom_field_values.
15
           select{|x| ! @cfs.select{|c| c[0]==t.id}.map{|c| c[6]}.include?(x.custom_field_id)}.
16
           collect{|x| [x.custom_field.id, x.custom_field.name, x.custom_field.position]}.each do |x| %>
17
      <li id="<%= x[0] %>" pos="<%= x[2] %>"><%= x[1] %></li>
18
      <% end %>
19
    </ul>
20
    <span style="color: #888;"><%= l(:grouped_cf) %></span>
21
    <div class='sortable_groups groups_tracker-<%= t.id %>'>
22
      <% @cfs.select{|x| x[0]==t.id && x[2]!=nil}.map{|x| x[2]}.uniq.each do |g| %>
23
      <div class="sortable_group">
24
        <input type="text" value="<%= g %>" style="background: #ddf; padding: 5px; width: 360px"/>
25
        <img src="/images/delete.png" onclick="remove_label(this, 'tracker-<%= t.id %>');"/>
26
        <ul class='sortable_items sortable_tracker-<%= t.id %>'>
27
          <% @cfs.select{|x| x[0]==t.id && x[2]==g}.each do |x| %>
28
          <li id="<%= x[6] %>" pos="<%= x[8] %>"><%= x[7] %></li>
29
          <% end %>
30
        </ul>
31
      </div>
32
      <% end %>
33
      <div>
34
        <input type="text" value="" style="background: #ddf; padding: 5px; width: 370px"/>
35
        <img src="/images/add.png" style="" onclick="add_label(this, 'tracker-<%= t.id %>');"/>
36
      </div>
37
    </div>
38
  </div>
39
  <% end %>
40
<%= form_for @project, :url => { :action => 'groupissuescustomfields', :id => @project },
41
            :html => {:id => 'groupissuescustomfields-form',
42
                      :method => :post} do |f| %>
43

  
44
<%= hidden_field :group_issues_custom_fields, '', :id => 'group_issues_custom_fields', :name => 'group_issues_custom_fields' %>
45
<p><%= submit_tag l(:button_save), :onclick => "fill_json_data();" %></p>
46
<% end %>
47
</div>
48

  
49
<script>
50
function init_sortables(labelclass) {
51
  $( '.groups_' + labelclass ).sortable({
52
    items: 'div.sortable_group',
53
    connectWith: '.groups_' + labelclass,
54
    start: function(event, ui) {
55
      ui.placeholder.height(ui.item.height());
56
    },
57
    axis: 'y'
58
  });
59
  $( '.sortable_' + labelclass ).sortable({
60
    connectWith: '.sortable_' + labelclass,
61
    update: function(event, ui) {
62
      if (ui.item.parent().hasClass('unsorted')) {
63
        ui.item.parent().prepend(ui.item);
64
        ui.item.parent().children('li').each(function () {
65
          if (parseInt($(this).attr('pos')) < parseInt(ui.item.attr('pos'))) {
66
            ui.item.insertAfter(this);
67
          }
68
        });
69
      }
70
    },
71
    axis: 'y'
72
  }).disableSelection();
73
}
74
function refresh_trackers(tracker) {
75
  $('.tracker').hide();
76
  $('#tracker_' + tracker.value).show();
77
}
78
function add_label(label, labelclass) {
79
  var old_label = $(label), new_label = $(label).parent().clone();
80
  new_label.children().first().val('').trigger('change');
81
  old_label.attr('src','/images/delete.png').attr('onclick','remove_label(this, "' + labelclass + '");');
82
  old_label.prev().width('360px');
83
  old_label.parent().addClass('ui-sortable-handle sortable_group');
84
  old_label.parent().sortable({
85
    connectWith: '.groups_' + labelclass
86
  }).disableSelection();
87
  old_label.parent().append('<ul id="' + labelclass + '_" class="sortable_items sortable_' + labelclass + '"/>');
88
  old_label.next().sortable({
89
    connectWith: '.sortable_' + labelclass
90
  }).disableSelection();
91
  old_label.parent().parent().append(new_label);
92
}
93
function remove_label(label, labelclass) {
94
  $(label).next().children().each(function () {
95
    var item = this;
96
    $('.unsorted.sortable_' + labelclass).prepend(this);
97
    $('.unsorted.sortable_' + labelclass).children('li').each(function () {
98
      if (parseInt($(this).attr('pos')) < parseInt($(item).attr('pos'))) {
99
        $(item).insertAfter(this);
100
      }
101
    });
102
  });
103
  $(label).parent().hide();
104
}
105
function fill_json_data() {
106
  var r = {}, gp = 0, cp = 0;
107
  $('#custom_fields_form').children('div').each(function () {
108
    var tracker_id = this.id.split('_').pop();
109
    gp = 0, cp = 0;
110

  
111
    // Group 'nil'
112
    r[tracker_id] = {};
113
    r[tracker_id][++gp] = {'cfs': {}};
114
    $(this).children('.nil').children().each(function () {
115
      cp++;
116
      r[tracker_id][gp]['cfs'][cp] = this.id;
117
    });
118
    if (! r[tracker_id][gp]['cfs'][1]) { delete r[tracker_id][gp]; }
119
    $(this).children('.sortable_groups').children().each(function () {
120
      if ($(this).children('ul').length) {
121
        r[tracker_id][++gp] = {
122
          'name': $(this).children('input').val(),
123
          'cfs': {}
124
        };
125
        cp = 0;
126
        $(this).children('ul').children().each(function () {
127
          r[tracker_id][gp]['cfs'][++cp] = this.id;
128
        });
129
        if (! r[tracker_id][gp]['cfs'][1]) { r[tracker_id][gp] = ''; }
130
      }
131
    });
132
    if ( ! r[tracker_id] ) { r[tracker_id] = ''; }
133
  });
134
  console.log(r);
135
  $('#group_issues_custom_fields').val(JSON.stringify(r)); }
136
$('#tracker_id').change();
137
<% @project.trackers.each do |t| %>
138
init_sortables('tracker-<%= t.id %>');
139
<% end %>
140
</script>
config/locales/en.yml
1313 1313
  description_issue_category_reassign: Choose issue category
1314 1314
  description_wiki_subpages_reassign: Choose new parent page
1315 1315
  text_repository_identifier_info: 'Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.'
1316
  grouped_cf: Grouped Custom Fields
1317
  global_cf_position: Global Custom Fields Position
1318
  changed_cf_position: Changed Custom Fields Position
1316 1319
  text_login_required_html: When not requiring authentication, public projects and their contents are openly available on the network. You can <a href="%{anonymous_role_path}">edit the applicable permissions</a>.
1317 1320
  label_login_required_yes: "Yes"
1318 1321
  label_login_required_no: "No, allow anonymous access to public projects"
config/locales/pt-BR.yml
1236 1236
  permission_view_news: Ver notícias
1237 1237
  label_no_preview_alternative_html: Visualização não disponível. Faça o %{link} do arquivo.
1238 1238
  label_no_preview_download: download
1239
  grouped_cf: Agrupar campos personalizados
1240
  global_cf_position: Posição global de campos personalizados
1241
  changed_cf_position: Alterar posição de campos personalizados
1239 1242
  setting_close_duplicate_issues: Fechar tarefas duplicadas automaticamente
1240 1243
  error_exceeds_maximum_hours_per_day: Não é possível registrar mais de %{max_hours} horas no mesmo dia (%{logged_hours} horas já foram registradas)
1241 1244
  setting_time_entry_list_defaults: Registro de horas padrão
config/routes.rb
131 131

  
132 132
    member do
133 133
      get 'settings(/:tab)', :action => 'settings', :as => 'settings'
134
      post 'groupissuescustomfields'
134 135
      post 'archive'
135 136
      post 'unarchive'
136 137
      post 'close'
db/migrate/20180913211420_create_attribute_groups.rb
1
class CreateAttributeGroups < ActiveRecord::Migration[4.2]
2
  def change
3
    create_table :attribute_groups do |t|
4
      t.references :project, index: true, foreign_key: true
5
      t.references :tracker, index: true, foreign_key: true
6
      t.string :name
7
      t.integer :position, :default => nil, :null => true
8

  
9
      t.timestamps null: false
10
    end
11
  end
12
end
db/migrate/20180913212008_create_attribute_group_fields.rb
1
class CreateAttributeGroupFields < ActiveRecord::Migration[4.2]
2
  def change
3
    create_table :attribute_group_fields do |t|
4
      t.references :attribute_group, index: true, foreign_key: true
5
      t.references :custom_field, index: true, foreign_key: true
6
      t.integer :position
7

  
8
      t.timestamps null: false
9
    end
10
  end
11
end
lib/redmine.rb
82 82
  map.permission :view_project, {:projects => [:show, :bookmark], :activities => [:index]}, :public => true, :read => true
83 83
  map.permission :search_project, {:search => :index}, :public => true, :read => true
84 84
  map.permission :add_project, {:projects => [:new, :create]}, :require => :loggedin
85
  map.permission :edit_project, {:projects => [:settings, :edit, :update]}, :require => :member
85
  map.permission :edit_project, {:projects => [:settings, :edit, :update, :groupissuescustomfields]}, :require => :member
86 86
  map.permission :close_project, {:projects => [:close, :reopen]}, :require => :member, :read => true
87 87
  map.permission :delete_project, {:projects => :destroy}, :require => :member
88 88
  map.permission :select_project_modules, {:projects => :modules}, :require => :member
lib/redmine/export/pdf/issues_pdf_helper.rb
64 64
          left  << nil while left.size  < rows
65 65
          right << nil while right.size < rows
66 66

  
67
          custom_field_values = issue.visible_custom_field_values.reject {|value| value.custom_field.full_width_layout?}
68
          half = (custom_field_values.size / 2.0).ceil
69
          custom_field_values.each_with_index do |custom_value, i|
70
            (i < half ? left : right) << [custom_value.custom_field.name, show_value(custom_value, false)]
71
          end
72

  
73 67
          if pdf.get_rtl
74 68
            border_first_top = 'RT'
75 69
            border_last_top  = 'LT'
......
81 75
            border_first = 'L'
82 76
            border_last  = 'R'
83 77
          end
78
          border_middle_top  = 'T'
84 79

  
85 80
          rows = left.size > right.size ? left.size : right.size
86 81
          rows.times do |i|
......
103 98
                             (i == 0 ? border_first_top : border_first), '', 0, 0)
104 99
            pdf.SetFontStyle('', 9)
105 100
            pdf.RDMMultiCell(60, height, item ? item.last.to_s : "",
106
                             (i == 0 ? border_last_top : border_last), '', 0, 0)
101
                             (i == 0 ? border_middle_top : ""), '', 0, 0)
107 102

  
108 103
            item = right[i]
109 104
            pdf.SetFontStyle('B', 9)
110 105
            pdf.RDMMultiCell(35, height, item ? "#{item.first}:" : "",
111
                             (i == 0 ? border_first_top : border_first), '', 0, 0)
106
                             (i == 0 ? border_middle_top : ""), '', 0, 0)
112 107
            pdf.SetFontStyle('', 9)
113 108
            pdf.RDMMultiCell(60, height, item ? item.last.to_s : "",
114 109
                             (i == 0 ? border_last_top : border_last), '', 0, 2)
......
116 111
            pdf.set_x(base_x)
117 112
          end
118 113

  
114
          group_by_keys(issue.project_id, issue.tracker_id, issue.visible_custom_field_values).each do |title, values|
115
            if values.present?
116
              unless title.nil?
117
                pdf.RDMCell(35 + 155, 5, title, "LRT", 1)
118
              end
119

  
120
              while values.present?
121
                if values[0].custom_field.full_width_layout?
122
                  while values.present? && values[0].custom_field.full_width_layout?
123
                    value = values.shift
124
                    pdf.SetFontStyle('B', 9)
125
                    pdf.RDMCell(35, 5, "#{value.custom_field.name}:", 'L', 0)
126
                    pdf.SetFontStyle('', 9)
127
                    pdf.RDMCell(155, 5, show_value(value, false).to_s, 'R', 1)
128
                  end
129
                else
130
                  lr_values = []
131
                  while values.present? && ! values[0].custom_field.full_width_layout?
132
                    lr_values += [ values.shift ]
133
                  end
134

  
135
                  half = (lr_values.size / 2.0).ceil
136
                  left = []
137
                  right = []
138
                  lr_values.each_with_index do |custom_value, i|
139
                    (i < half ? left : right) << [custom_value.custom_field.name, show_value(custom_value, false)]
140
                  end
141

  
142
                  rows = left.size > right.size ? left.size : right.size
143
                  rows.times do |i|
144
                    heights = []
145
                    pdf.SetFontStyle('B', 9)
146
                    item = left[i]
147
                    heights << pdf.get_string_height(35, item ? "#{item.first}:" : "")
148
                    item = right[i]
149
                    heights << pdf.get_string_height(35, item ? "#{item.first}:" : "")
150
                    pdf.SetFontStyle('', 9)
151
                    item = left[i]
152
                    heights << pdf.get_string_height(60, item ? item.last.to_s  : "")
153
                    item = right[i]
154
                    heights << pdf.get_string_height(60, item ? item.last.to_s  : "")
155
                    height = heights.max
156

  
157
                    item = left[i]
158
                    pdf.SetFontStyle('B', 9)
159
                    pdf.RDMMultiCell(35, height, item ? "#{item.first}:" : "", border_first, '', 0, 0)
160
                    pdf.SetFontStyle('', 9)
161
                    pdf.RDMMultiCell(60, height, item ? item.last.to_s : "", "", '', 0, 0)
162

  
163
                    item = right[i]
164
                    pdf.SetFontStyle('B', 9)
165
                    pdf.RDMMultiCell(35, height, item ? "#{item.first}:" : "",  "", '', 0, 0)
166
                    pdf.SetFontStyle('', 9)
167
                    pdf.RDMMultiCell(60, height, item ? item.last.to_s : "", border_last, '', 0, 2)
168

  
169
                    pdf.set_x(base_x)
170
                  end
171
                end
172
              end
173
            end
174
          end
175

  
119 176
          pdf.SetFontStyle('B', 9)
120 177
          pdf.RDMCell(35 + 155, 5, l(:field_description), "LRT", 1)
121 178
          pdf.SetFontStyle('', 9)
......
130 187
              :headings => false,
131 188
              :inline_attachments => false
132 189
            )
133
          pdf.RDMwriteFormattedCell(35+155, 5, '', '', text, issue.attachments, "LRB")
134

  
135
          custom_field_values = issue.visible_custom_field_values.select {|value| value.custom_field.full_width_layout?}
136
          custom_field_values.each do |value|
137
            text = show_value(value, false)
138
            next if text.blank?
139

  
140
            pdf.SetFontStyle('B', 9)
141
            pdf.RDMCell(35+155, 5, value.custom_field.name, "LRT", 1)
142
            pdf.SetFontStyle('', 9)
143
            pdf.RDMwriteHTMLCell(35+155, 5, '', '', text, issue.attachments, "LRB")
144
          end
190
          pdf.RDMwriteFormattedCell(35 + 155, 5, '', '', text, issue.attachments, "LRB")
145 191

  
146 192
          unless issue.leaf?
147 193
            truncate_length = (!is_cjk? ? 90 : 65)
148 194
            pdf.SetFontStyle('B', 9)
149
            pdf.RDMCell(35+155, 5, l(:label_subtask_plural) + ":", "LTR")
195
            pdf.RDMCell(35 + 155, 5, l(:label_subtask_plural) + ":", "LTR")
150 196
            pdf.ln
151 197
            issue_list(issue.descendants.visible.sort_by(&:lft)) do |child, level|
152 198
              buf = "#{child.tracker} # #{child.id}: #{child.subject}".
......
177 223
              end
178 224
              buf = buf.truncate(truncate_length)
179 225
              pdf.SetFontStyle('', 8)
180
              pdf.RDMCell(35+155-60, 5, buf, border_first)
226
              pdf.RDMCell(35 + 155 - 60, 5, buf, border_first)
181 227
              pdf.SetFontStyle('B', 8)
182 228
              pdf.RDMCell(20, 5, relation.other_issue(issue).status.to_s, "")
183 229
              pdf.RDMCell(20, 5, format_date(relation.other_issue(issue).start_date), "")
public/stylesheets/application.css
536 536
div.issue span.private, div.journal span.private {font-size: 60%;}
537 537
div.issue .next-prev-links {color:#999;}
538 538
div.issue .attributes {margin-top: 2em;}
539
div.issue .attributes .attribute {padding-left:180px; clear:left; min-height: 1.8em;}
540
div.issue .attributes .attribute .label {width: 170px; margin-left:-180px; font-weight:bold; float:left;  overflow:hidden; text-overflow: ellipsis;}
539
div.issue .attributes .attribute {padding-left: 225px; clear:left; min-height: 1.8em;}
540
div.issue .attributes .attribute .label {width: 215px; margin-left:-225px; font-weight:bold; float:left; overflow:hidden; text-overflow: ellipsis;}
541 541
div.issue .attribute .value {overflow:auto; text-overflow: ellipsis;}
542
div.issue .attribute .value p {margin: 0 0 0.8em 0;}
542 543
div.issue.overdue .due-date .value { color: #c22; }
543 544
body.controller-issues h2.inline-flex {padding-right: 0}
544 545

  
......
1853 1854
	display: inline;
1854 1855
	opacity: 1;
1855 1856
}
1857

  
1858
/* Custom Field Groups */
1859
.sortable_groups {
1860
  background: #eee;
1861
  border: 1px solid #888;
1862
  width: 445px;
1863
  min-height: 30px;
1864
  margin: 5px;
1865
  padding: 5px;
1866
}
1867
.sortable_groups div {
1868
  background: #ddf;
1869
  border: 1px solid #888;
1870
  min-height: 30px;
1871
  margin: 5px;
1872
  padding: 5px;
1873
}
1874
.sortable_items {
1875
  background: #eee;
1876
  border: 1px solid #888;
1877
  width: 400px;
1878
  min-height: 30px;
1879
  margin: 5px;
1880
  padding: 5px;
1881
}
1882
.sortable_items li {
1883
  background: #ffffff;
1884
  border: 1px solid #888;
1885
  margin: 5px;
1886
  padding: 5px;
1887
  list-style-type: none;
1888
  font-size: 1.2em;
1889
}
1890
.not_a_group {
1891
  padding: 5px 27px;
1892
}
1893
.ui-sortable-handle:before {
1894
  content:url('/images/reorder.png');
1895
  margin-right: 5px;
1896
}
1897
.ui-sortable-placeholder {
1898
  background: #8888ff;
1899
  border: 1px solid #888;
1900
  visibility: visible;
1901
}
test/fixtures/attribute_group_fields.yml
1
# Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html
2

  
3
one:
4
  attribute_group_id:
5
  custom_field_id:
6
  position: 1
7

  
8
two:
9
  attribute_group_id:
10
  custom_field_id:
11
  position: 1
test/fixtures/attribute_groups.yml
1
# Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html
2

  
3
one:
4
  project_id:
5
  tracker_id:
6
  name: MyString
7
  position: 1
8

  
9
two:
10
  project_id:
11
  tracker_id:
12
  name: MyString
13
  position: 1
(20-20/24)