Project

General

Profile

Download (4.49 KB)

Defect #33521 » 0001-Fix-status-update-path-on-the-context-menu.patch

Mizuki ISHIKAWA, 2021-08-02 04:34

View differences:

app/views/context_menus/issues.html.erb
21 21 
                  @issue,
22 22 
                  :ids => @issue_ids, :issue => {:status_id => s}, :back_url => @back
23 23 
                ),
24 
                :method => :post,
24 
                :method => :patch,
25 25 
                :selected => (@issue && s == @issue.status), :disabled => !@can[:edit]
26 26 
              ) %>
27 27 
        </li>
test/functional/context_menus_controller_test.rb
52 52 
    assert_select 'a.icon-del[href=?]', '/issues?ids%5B%5D=1', :text => 'Delete'
53 53 

  		




  54
  54
  
    
    # Statuses

  		




  55
  
  
    
    assert_select 'a[href=?]', '/issues/1?ids%5B%5D=1&issue%5Bstatus_id%5D=5', :text => 'Closed'

  		




  56
  
  
    
    assert_select 'a[href=?]', '/issues/1?ids%5B%5D=1&issue%5Bpriority_id%5D=8', :text => 'Immediate'

  		




  
  55
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/1?ids%5B%5D=1&issue%5Bstatus_id%5D=5', :text => 'Closed'

  		




  
  56
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/1?ids%5B%5D=1&issue%5Bpriority_id%5D=8', :text => 'Immediate'

  		




  57
  57
  
    
    # No inactive priorities

  		




  58
  58
  
    
    assert_select 'a', :text => /Inactive Priority/, :count => 0

  		




  59
  59
  
    
    # Versions

  		




  60
  
  
    
    assert_select 'a[href=?]', '/issues/1?ids%5B%5D=1&issue%5Bfixed_version_id%5D=3', :text => '2.0'

  		




  61
  
  
    
    assert_select 'a[href=?]', '/issues/1?ids%5B%5D=1&issue%5Bfixed_version_id%5D=4', :text => 'eCookbook Subproject 1 - 2.0'

  		




  
  60
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/1?ids%5B%5D=1&issue%5Bfixed_version_id%5D=3', :text => '2.0'

  		




  
  61
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/1?ids%5B%5D=1&issue%5Bfixed_version_id%5D=4', :text => 'eCookbook Subproject 1 - 2.0'

  		




  62
  62
  
    
    # Assignees

  		




  63
  
  
    
    assert_select 'a[href=?]', '/issues/1?ids%5B%5D=1&issue%5Bassigned_to_id%5D=3', :text => 'Dave Lopper'

  		




  
  63
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/1?ids%5B%5D=1&issue%5Bassigned_to_id%5D=3', :text => 'Dave Lopper'

  		




  64
  64
  
    
  end

  		




  65
  65
  
    

  		




  66
  66
  
    
  def test_context_menu_multiple_issues_should_link_to_bulk_update_issues_path

  		




  ......




  75
  75
  
    
    assert_select 'a.icon-del[href=?]', '/issues?ids%5B%5D=1&ids%5B%5D=2', :text => 'Delete'

  		




  76
  76
  
    

  		




  77
  77
  
    
    # Statuses

  		




  78
  
  
    
    assert_select 'a[href=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bstatus_id%5D=5', :text => 'Closed'

  		




  79
  
  
    
    assert_select 'a[href=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bpriority_id%5D=8', :text => 'Immediate'

  		




  
  78
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bstatus_id%5D=5', :text => 'Closed'

  		




  
  79
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bpriority_id%5D=8', :text => 'Immediate'

  		




  80
  80
  
    
    # No inactive priorities

  		




  81
  81
  
    
    assert_select 'a', :text => /Inactive Priority/, :count => 0

  		




  82
  82
  
    
    # Versions

  		




  83
  
  
    
    assert_select 'a[href=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bfixed_version_id%5D=3', :text => '2.0'

  		




  84
  
  
    
    assert_select 'a[href=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bfixed_version_id%5D=4', :text => 'eCookbook Subproject 1 - 2.0'

  		




  
  83
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bfixed_version_id%5D=3', :text => '2.0'

  		




  
  84
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bfixed_version_id%5D=4', :text => 'eCookbook Subproject 1 - 2.0'

  		




  85
  85
  
    
    # Assignees

  		




  86
  
  
    
    assert_select 'a[href=?]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bassigned_to_id%5D=3', :text => 'Dave Lopper'

  		




  
  86
  
    
    assert_select 'a[href=?][data-method="patch"]', '/issues/bulk_update?ids%5B%5D=1&ids%5B%5D=2&issue%5Bassigned_to_id%5D=3', :text => 'Dave Lopper'

  		




  87
  87
  
    
  end

  		




  88
  88
  
    

  		




  89
  89
  
    
  def test_context_menu_one_issue_by_anonymous

  		















  (4-4/5)