0001-Setting-to-restrict-adding-editing-deleting-log-time.patch - Redmine

         errors.add :activity_id, :inclusion if activity_id_changed? && project && !project.activities.include?(activity)
         if spent_on_changed? && user
           errors.add :base, I18n.t(:error_spent_on_future_date) if !Setting.timelog_accept_future_dates? && (spent_on > user.today)
           errors.add :base, I18n.t(:error_spent_on_old_date, :days => Setting.timelog_lock_days_older_than.to_i) if date_is_locked_for_user?
         end
       end
-...
       # Returns true if the time entry can be edited by usr, otherwise false
       def editable_by?(usr)
         visible?(usr) && (
         visible?(usr) && !date_is_locked_for_user? && (
           (usr == user && usr.allowed_to?(:edit_own_time_entries, project)) || usr.allowed_to?(:edit_time_entries, project)
+        )
       end
-...
 .0
         end
       end
       # Returns true if time entry is logged on a locked date and the user doesn't have the permission
       # to manage time entries on locked dates
       def date_is_locked_for_user?
         if user && spent_on
           number_of_days = Setting.timelog_lock_days_older_than.to_i
           ((user.today - spent_on).to_i > number_of_days) && !User.current.allowed_to?(:manage_time_entries_on_locked_dates, self.project)
         end
       end
     end

     <p><%= setting_check_box :timelog_accept_0_hours %></p>
     <p><%= setting_check_box :timelog_accept_future_dates %></p>
     <p><%= setting_text_field :timelog_lock_days_older_than, :size => 6 %> <%= l(:label_day_plural) %></p>
     </div>
     <fieldset class="box">

       error_can_not_delete_auth_source: "This authentication mode is in use and cannot be deleted."
       error_spent_on_future_date: "Cannot log time on a future date"
       error_not_allowed_to_log_time_for_other_users: "You are not allowed to log time for other users"
       error_spent_on_old_date: "Cannot log time on a date older than %{days} days"
       mail_subject_lost_password: "Your %{value} password"
       mail_body_lost_password: 'To change your password, click on the following link:'
-...
       setting_timelog_accept_future_dates: Accept time logs on future dates
       setting_show_status_changes_in_mail_subject: Show status changes in issue mail notifications subject
       setting_project_list_defaults: Projects list defaults
       setting_timelog_lock_days_older_than: Lock (add/edit/delete time logs) dates older than
       permission_add_project: Create project
       permission_add_subprojects: Create subprojects

config/settings.yml
337	337	default: 1
338	338	show_status_changes_in_mail_subject:
339	339	default: 1
	340	timelog_lock_days_older_than:
	341	format: int
	342	default: 9999

         map.permission :manage_project_activities, {:projects => :settings, :project_enumerations => [:update, :destroy]}, :require => :member
         map.permission :log_time_for_other_users, :require => :member
         map.permission :import_time_entries, {}
         map.permission :manage_time_entries_on_locked_dates, {}, :require => :loggedin
         map.permission :manage_project_activities, {:project_enumerations => [:update, :destroy]}, :require => :member
       end
       map.project_module :news do |map|

         - :edit_time_entries
         - :delete_time_entries
         - :import_time_entries
         - :manage_time_entries_on_locked_dates
         - :view_news
         - :manage_news
         - :comment_news
-...
         - :log_time
         - :view_time_entries
         - :edit_own_time_entries
         - :manage_time_entries_on_locked_dates
         - :view_news
         - :manage_news
         - :comment_news
-...
         - :view_calendar
         - :log_time
         - :view_time_entries
         - :manage_time_entries_on_locked_dates
         - :view_news
         - :manage_news
         - :comment_news
-...
         - :view_calendar
         - :log_time
         - :view_time_entries
         - :manage_time_entries_on_locked_dates
         - :view_news
         - :comment_news
         - :view_documents
-...
         - :view_gantt
         - :view_calendar
         - :view_time_entries
         - :manage_time_entries_on_locked_dates
         - :view_news
         - :view_documents
         - :view_wiki_pages

       def test_should_accept_future_dates
         entry = TimeEntry.generate
         entry.spent_on = Date.tomorrow
         entry.spent_on = User.current.today + 1
         assert entry.save
-...
       def test_should_not_accept_future_dates_if_disabled
         with_settings :timelog_accept_future_dates => '0' do
           entry = TimeEntry.generate
           entry.spent_on = Date.tomorrow
           entry.spent_on = User.current.today + 1
           assert !entry.save
-...
         end
       end
       def test_should_allow_time_entries_on_locked_dates_for_users_with_permission
         User.current = User.find(2)
         with_settings :timelog_lock_days_older_than => '5' do
           entry = TimeEntry.generate(:project => Project.find(1))
           entry.spent_on = Date.today - 6
           assert entry.save
         end
       end
       def test_should_not_allow_time_entries_on_locked_dates_for_users_without_permission
         User.current = User.find(2)
         Role.find(1).remove_permission!(:manage_time_entries_on_locked_dates)
         with_settings :timelog_lock_days_older_than => '5' do
           entry = TimeEntry.generate(:project => Project.find(1))
           entry.spent_on = Date.today - 6
           assert !entry.save
           assert entry.errors[:base].present?
         end
       end
       def test_editable_by_should_return_true_for_time_entry_on_locked_date_and_user_with_permission
           user = User.find(2)
           User.current = user
           time_entry = TimeEntry.find(1)
           with_settings :timelog_lock_days_older_than => '5' do
             assert time_entry.editable_by?(user)
         end
       end
       def test_editable_by_should_return_false_for_time_entry_on_locked_date_and_user_without_permission
           user = User.find(2)
           User.current = user
           Role.find(1).remove_permission!(:manage_time_entries_on_locked_dates)
           time_entry = TimeEntry.find(1)
           with_settings :timelog_lock_days_older_than => '5' do
             assert !time_entry.editable_by?(user)
         end
       end
       def test_spent_on_with_blank
         c = TimeEntry.new
         c.spent_on = ''

Project

General

Profile

Redmine

Feature #13244 » 0001-Setting-to-restrict-adding-editing-deleting-log-time.patch