Project

General

Profile

Forums » Open discussion »

Refactoring replies

Added by Brad Beattie almost 16 years ago

So I see that there are news comments, forum threads, and issue histories. As far as I can tell, these three all do the same thing, yet are implemented slightly differently. Is there any reason they shouldn't all pull from the same rhtml? I'm willing to do the work myself, I'm just curious if there's reason behind this I'm not seeing.


Replies (2)

RE: Refactoring replies - Added by Jean-Philippe Lang almost 16 years ago

Is there any reason they shouldn't all pull from the same rhtml?

Basically, because the underlying models are different.

RE: Refactoring replies - Added by Anonymous almost 16 years ago

As you talk about refactoring, wouldn't it be a good idea to add versioning in the comments? (See e.g. sample in stackoverflow).

I lost text (comments) already more than once and don't like much that former text disappears without any traces.

Cheers,
Hans-Peter

    (1-2/2)