Redmine

http://redmine.hgftr.ru/projects/contacts-plugin/files

Did not find how to add issue to your tracker...
When I did plugin migration I got error that DB table already exists.

Mysql::Error: Table 'customers' already exists: CREATE TABLE `customers` (`id` int(11) DEFAULT NULL
 auto_increment PRIMARY KEY, `name` varchar(255), `company` varchar(255), `address` text,
 `phone` varchar(255), `email` varchar(255), `website` varchar(255),
 `skype_name` varchar(255), `project_id` int(11)) ENGINE=InnoDB

I think it conflicts with other module - http://github.com/edavis10/redmine-customer-plugin

Yes, it's conflicted with https://github.com/edavis10/redmine-customer-plugin

I've downloaded your Redmine Contacts plugin - it seems like a great idea! However, after giving it a go I found 2 errors when trying to add a new contact. I'm on Redmine 1.0.1, Ruby 1.8.7.

First one is when trying to add a contact with an attached picture:

ContactsController#create (for 10.10.10.10 at 2010-11-17 12:10:32) [POST]
Parameters: {"commit"=>"Save", "project_id"=>"123", "action"=>"create", "authenticity_token"=>"123", "contact"=>{"address"=>"Address", "company"=>"", "is_company"=>"1", "skype_name"=>"123", "job_title"=>"Company", "background"=>"123", "tag_names"=>"123", "website"=>"123", "phone"=>"123", "last_name"=>"", "email"=>"123", "middle_name"=>"", "first_name"=>"123"}, "contact_avatar"=>{"file"=>#<File:/tmp/RackMultipart20101117-11837-do0gdp-0>}, "controller"=>"contacts"}
Rendering template within layouts/base
Rendering contacts/new

ActionView::TemplateError (undefined method `attachments' for nil:NilClass) on line #6 of vendor/plugins/redmine_contacts/app/views/contacts/_form.html.erb:
3:
4:
5: <div class = "box">
6: <p class="avatar"><%= avatar_to(Максим Ковалев, :size => "64") ></p>
7: <p><= file_field_tag 'contact_avatar[file]', :size => 30, :id => nil -> </p>
8: <p><= f.check_box (:is_company, :label=>l(:field_contact_is_company), :onclick => "if (this.checked) {Element.hide('person_data');$('job_title').firstChild.innerHTML='#{l(:field_company_field)}';} else {Element.show('person_data');$('job_title').firstChild.innerHTML='#{l(:field_contact_job_title)}';}" ) ></p>
9: <p><= f.text_field :first_name, :label=> !@contact.is_company ? l(:field_contact_first_name) : l(:field_contact_name), :required => true %></p>

vendor/plugins/redmine_contacts/app/helpers/contacts_helper.rb:29:in `avatar_to'
    vendor/plugins/redmine_contacts/app/views/contacts/_form.html.erb:6
    vendor/plugins/redmine_contacts/app/views/contacts/new.html.erb:4
    app/helpers/application_helper.rb:697:in `labelled_tabular_form_for'
    vendor/plugins/redmine_contacts/app/views/contacts/new.html.erb:3
    vendor/plugins/redmine_contacts/app/controllers/contacts_controller.rb:97:in `create'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/rack/request_handler.rb:92:in `process_request'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_request_handler.rb:207:in `main_loop'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:418:in `start_request_handler'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:358:in `handle_spawn_application'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/utils.rb:184:in `safe_fork'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:354:in `handle_spawn_application'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `__send__'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:163:in `start'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:213:in `start'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:262:in `spawn_rails_application'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server_collection.rb:126:in `lookup_or_add'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:256:in `spawn_rails_application'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server_collection.rb:80:in `synchronize'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:255:in `spawn_rails_application'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:154:in `spawn_application'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:287:in `handle_spawn_application'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `__send__'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
    /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'

Rendering /var/www/redmine-testing/public/500.html (500 Internal Server Error)

Second one when addding contact without a picture:

Processing ContactsController#show (for 10.10.10.10 at 2010-11-17 12:13:45) [GET]
Parameters: {"project_id"=>"123", "action"=>"show", "id"=>"2", "controller"=>"contacts"}

ActiveRecord::StatementInvalid (Mysql::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')) ORDER BY created_on DESC' at line 1: SELECT * FROM `attachments` WHERE ((1=1) and (container_type = 'Note') and container_id in ()) ORDER BY created_on DESC):
vendor/plugins/redmine_contacts/app/controllers/contacts_controller.rb:254:in `find_contact_attachments'
vendor/plugins/redmine_contacts/app/controllers/contacts_controller.rb:16:in `show'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/rack/request_handler.rb:92:in `process_request'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_request_handler.rb:207:in `main_loop'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:418:in `start_request_handler'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:358:in `handle_spawn_application'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/utils.rb:184:in `safe_fork'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:354:in `handle_spawn_application'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `__send__'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:163:in `start'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:213:in `start'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:262:in `spawn_rails_application'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server_collection.rb:126:in `lookup_or_add'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:256:in `spawn_rails_application'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server_collection.rb:80:in `synchronize'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:255:in `spawn_rails_application'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:154:in `spawn_application'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:287:in `handle_spawn_application'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `__send__'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
/usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'

Rendering /var/www/redmine-testing/public/500.html (500 Internal Server Error)

Thanks,
Michal

Here is a new version http://redmine.hgftr.ru/attachments/download/185/redmine_contacts_1-1-1.tar.gz

Thanks Kirill.

Adding a new Contact now works without errors (although you still get an error when trying to add one which already exists).

However, when trying to add a new issue, I'm getting this:

Processing ContactsController#add_task (for 10.10.10.10 at 2010-11-17 13:52:26) [POST]
  Parameters: {"assigned_to"=>"3", "commit"=>"Add", "project_id"=>"test", "action"=>"add_task", "authenticity_token"=>"123", "id"=>"4", "task_subject"=>"test issue", "due_date"=>"2010-11-17", "controller"=>"contacts"}

ActionView::MissingTemplate (Missing template contacts/add_task.erb in view path vendor/plugins/budget_plugin/app/views:vendor/plugins/bulk_time_entry_plugin/app/views:vendor/plugins/codebook/app/views:vendor/plugins/question_plugin/app/views:vendor/plugins/redmine-graphs-plugin/app/views:vendor/plugins/redmine_charts/app/views:vendor/plugins/redmine_contacts/app/views:vendor/plugins/redmine_default_columns/app/views:vendor/plugins/redmine_drafts/app/views:vendor/plugins/redmine_logs/app/views:vendor/plugins/redmine_rate/app/views:vendor/plugins/redmine_schedules/app/views:vendor/plugins/redmine_screenshot_paste/app/views:vendor/plugins/redmine_tab/app/views:vendor/plugins/stuff_to_do_plugin/app/views:vendor/plugins/timesheet_plugin/app/views:app/views):
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/rack/request_handler.rb:92:in `process_request'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_request_handler.rb:207:in `main_loop'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:418:in `start_request_handler'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:358:in `handle_spawn_application'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/utils.rb:184:in `safe_fork'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:354:in `handle_spawn_application'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `__send__'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:163:in `start'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/railz/application_spawner.rb:213:in `start'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:262:in `spawn_rails_application'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server_collection.rb:126:in `lookup_or_add'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:256:in `spawn_rails_application'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server_collection.rb:80:in `synchronize'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:255:in `spawn_rails_application'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:154:in `spawn_application'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/spawn_manager.rb:287:in `handle_spawn_application'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `__send__'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
  /usr/lib64/ruby/gems/1.8/gems/passenger-2.2.10/lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'

Rendering /var/www/redmine-testing/public/500.html (500 Internal Server Error)

Also, is there a way of assigning existing issues to a contact?

Thanks,
Michal

I can't repeat the error, please write steps and version of redmine and plugin

Also, is there a way of assigning existing issues to a contact?

Yes ver 1.1.2 (take from svn)

I can't repeat the error, please write steps and version of redmine and plugin

Also, is there a way of assigning existing issues to a contact?

Yes ver 1.1.2 (take from svn)

The problem is that we have a custom required field that has to be assigned during issue creation. When creating an issue through Contact, it's not possible to assign any field besides Subject, Assigned To and Due Date.

Because the issue is not saved, Redmine fails to redirect to action 'show' here:

def add_task
    issue = Issue.new
    issue.subject = params[:task_subject]
    issue.project = @project
    issue.tracker = @project.trackers.find(:first)
    issue.author = User.current
    issue.due_date = params[:due_date]
    issue.assigned_to_id = params[:assigned_to]
    issue.description = issue.subject
    issue.status = IssueStatus.default
    if issue.save
      flash[:notice] = l(:notice_successful_add)
      @contact.issues << issue
      @contact.save
      redirect_to :action => 'show', :id =>  params[:id], :project_id => params[:project_id]
      return
    end
  end 

What do you think about adding a feature to assign existing issues to a Contact? For us that would be much more useful than creating new issues.

What do you think about adding a feature to assign existing issues to a Contact? For us that would be much more useful than creating new issues.

This feature present in 1.1.2

Michal Slazak wrote:

The problem is that we have a custom required field that has to be assigned during issue creation. When creating an issue through Contact, it's not possible to assign any field besides Subject, Assigned To and Due Date.

That sux. I don't know how to resolve it.
May be create setting witch type os issue can be created from contact page.

And create issue from contact useful because we have such process:
1) support receive call or mail
2) they search for contact in redmine
3) if no contact they add it to redmine and create issue from contact page. After if need, they add additional info to issue

I've added tracker selection to create issue form from contact page

Could you please give me access to SVN or create package with version 1.1.2? I can't register on you Redmine page: http://redmine.hgftr.ru/

Another feature that I think would be useful would be ability to create global Contacts unrelated to any particular project in case you needed to assign issues from different projects to the same Contact.

Michal Slazak wrote:

Could you please give me access to SVN or create package with version 1.1.2? I can't register on you Redmine page: http://redmine.hgftr.ru/

http://hgftr.ru/svn/repository/redmine/redmine_contacts/trunk/

Another feature that I think would be useful would be ability to create global Contacts unrelated to any particular project in case you needed to assign issues from different projects to the same Contact.

I've planned this feature

That's great. Cheers!

It would be nice if you could select contact from the list instead of typing the number when adding it to an issue, but it's not a big deal.

Michal Slazak wrote:

It would be nice if you could select contact from the list instead of typing the number when adding it to an issue, but it's not a big deal.

Passed

New version released http://redmine.hgftr.ru/attachments/download/190/redmine_contacts_1-1-2.tar.gz

the plugins contacts and knowledgebase conficts in using the same table names 'taggings' and 'tags' where only the plugin installed first will work;

I think this problem will be with all plugins witch have save features. And have no idea how to solve it properly. May be rename tables with plugin name prefix, like "contacts_tags" and etc. But it's not solve problem with already present migrations.

Kirill Bezrukov wrote:

I think this problem will be with all plugins witch have save features. And have no idea how to solve it properly. May be rename tables with plugin name prefix, like "contacts_tags" and etc.

Clearly, some kind of namespace convention—preferably an agreed-upon one, such as prefixing with the plugin name and an underscore—is the way to go.

But it's not solve problem with already present migrations.

I'm not sure I understand the problem here. Since the two conflicting plugins can't have been installed together, shouldn't it be easy to decide which one gets to rename "its" table?

But it's not solve problem with already present migrations.

I'm not sure I understand the problem here. Since the two conflicting plugins can't have been installed together, shouldn't it be easy to decide which one gets to rename "its" table?

The case:
You have plugin knowledgebase with tables tags and etc.
You installing plugin contacts, which changes that tables to contacts_tags but not in first migration file, and thats a problem, because migrations don't applies. To solve this I need to change old migrations files, but this will be a problem for current users

I'll try to do something in future.

PS: I think tags it't very useful feature for whole redmine and it must be in core classes

Kirill Bezrukov wrote:

But it's not solve problem with already present migrations.

I'm not sure I understand the problem here. Since the two conflicting plugins can't have been installed together, shouldn't it be easy to decide which one gets to rename "its" table?

The case:
You have plugin knowledgebase with tables tags and etc.
You installing plugin contacts, which changes that tables to contacts_tags

No, my point is that it wouldn't do that. The plugin would see if its other tables were already installed before making such a change. If they weren't, it would create a new contacts_tags table.

I'll try to do something in future.

Looks like the knowledgebase guy has already worked around it on his end.

PS: I think tags it't very useful feature for whole redmine and it must be in core classes

Sure, but let's not have that stand in the way of a fix for the more localized issue :-)

Hi, this plugin is very useful. We would like to use the same Contact information across multiple projects, is this possible? Thanks

We installed 1.1.3 on redmine 1.0.1. We get Internal error when trying to add comment on contacts:

ActionView::MissingTemplate (Missing template mailer/note_added.text.plain.rhtml in view path app/views):
/app/models/mailer.rb:393:in `render_multipart'
vendor/plugins/redmine_contacts/app/models/note.rb:40:in `send_mails'
vendor/plugins/redmine_contacts/app/controllers/contacts_controller.rb:186:in `add_note'
passenger (2.2.14) lib/phusion_passenger/rack/request_handler.rb:92:in `process_request'
passenger (2.2.14) lib/phusion_passenger/abstract_request_handler.rb:207:in `main_loop'
passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:441:in `start_request_handler'
passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:381:in `handle_spawn_application'
passenger (2.2.14) lib/phusion_passenger/utils.rb:252:in `safe_fork'
passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:377:in `handle_spawn_application'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `__send__'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:163:in `start'
passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:222:in `start'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:262:in `spawn_rails_application'
passenger (2.2.14) lib/phusion_passenger/abstract_server_collection.rb:126:in `lookup_or_add'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:256:in `spawn_rails_application'
passenger (2.2.14) lib/phusion_passenger/abstract_server_collection.rb:80:in `synchronize'
passenger (2.2.14) lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:255:in `spawn_rails_application'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:154:in `spawn_application'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:287:in `handle_spawn_application'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `__send__'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'

Terence Mill wrote:

We installed 1.1.3 on redmine 1.0.1. We get Internal error when trying to add comment on contacts:

ActionView::MissingTemplate (Missing template mailer/note_added.text.plain.rhtml in view path app/views):

Do you have such file app/views/mailer/note_added.text.plain.rhtml in plugin dir?