Project

General

Profile

Actions
Copy link

Feature #10293

open

improve readability of subject changed message

Added by Gerry Hawkins over 12 years ago. Updated 7 days ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Email notifications
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

Currently the subject change message has no punctuation nor different font or styling. I think this makes it hard to parse at a quick glance.

Changing it slightly to something like:
Subject changed from 'this is a bug' to 'this is a really bad bug!'

I don't find the formatting of other change notices to be as problematic most likely since the before and after values are typically short and fit into a normal sentence structure.
e.g. Assignee changed from Bob McKenzie to Doug McKenzie

Files

Download all files
clipboard-202411151734-pnoyj.png (42 KB) clipboard-202411151734-pnoyj.png Go MAEDA, 2024-11-15 09:34
clipboard-202411151739-we2pk.png (64.5 KB) clipboard-202411151739-we2pk.png Go MAEDA, 2024-11-15 09:39
Actions
Copy link
 #1

Updated by Jean-Philippe Lang over 12 years ago

  • Tracker changed from Defect to Feature
Actions
Copy link
 #2

Updated by Go MAEDA 7 days ago

In GitHub Issues, when a title is changed, the previous title is displayed with a strikethrough (see the screenshot below).

Similarly, in Redmine, displaying previous values with a strikethrough would make it easier to visually distinguish past values. This functionality is consistent with the existing behavior of displaying deleted values, such as showing a strikethrough on the original assignee when the assignee is changed to none, making it a natural extension of the current feature.

This can be achieved with minimal code changes as shown below.

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index dc5b894e5..85781fa3d 100644
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -609,7 +609,7 @@ module IssuesHelper
     unless no_html
       label = content_tag('strong', label)
       old_value = content_tag("i", h(old_value)) if detail.old_value
-      if detail.old_value && detail.value.blank? && detail.property != 'relation'
+      if detail.old_value && detail.property != 'relation'
         old_value = content_tag("del", old_value)
       end
       if detail.property == 'attachment' && value.present? &&

Actions
Copy link

Also available in: Atom PDF