Defect #11325

Unified diff link broken on specific file/revision diff view

Added by Etienne Massip over 8 years ago. Updated almost 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:2.0.4
Resolution:Fixed Affected version:2.0.3

Description

Clicking on the "Unified diff" linkt at the bottom of a diff page of a specific file for a specific revision doesn't work anymore.

For a SVN revision, it simply produces a 404 error page.

The unified diff link is badly formatted; instead of adding a format query parameter, it seems that source:/tags/2.0.3/lib/redmine/views/other_formats_builder.rb#L26 format value is now appended at the end of the URI like a file extension.

Associated revisions

Revision 9909
Added by Jean-Philippe Lang over 8 years ago

Fixed: unified diff link broken on specific file/revision diff (#11325).

History

#1 Updated by Jean-Philippe Lang over 8 years ago

  • Subject changed from Unified diff returns a HTML 404 error page to Unified diff link broken on specific file/revision diff view
  • Status changed from Confirmed to Resolved
  • Resolution set to Fixed

Fixed in r9909.

#2 Updated by Jean-Philippe Lang over 8 years ago

  • Target version changed from Candidate for next minor release to 2.0.4

#3 Updated by Jean-Philippe Lang over 8 years ago

  • Status changed from Resolved to Closed

Merged.

#4 Updated by Anthony Mallet almost 2 years ago

Hi,

This seems broken again with 4.0.1 :)

#5 Updated by Go MAEDA almost 2 years ago

Anthony Mallet wrote:

This seems broken again with 4.0.1 :)

Please open a new issue and describe the details. Since this issue is closed and the fix was already released, we cannot discuss here.

Also available in: Atom PDF