Defect #12981
closed
Wiki self-link with anchor looks strange in "preview" section.
0%
Description
My page named Wiki contains link [[Wiki#Section]]. It produces this HTML: <a href="#Section">Wiki</a> that looks great on the page, but look strange in preview section, while editing this page. In that case it directs me to /projects/project1/wiki/Wiki/edit#Section that is obviously wrong.
Self-link is considered like special case by this piece of code (app/helpers/application_helper.rb):
def parse_wiki_links
# ...
url = if anchor.present? && wiki_page.present? && (obj.is_a?(WikiContent) || obj.is_a?(WikiContent::Version)) && obj.page == wiki_page
"##{anchor}"
else
As you can see, obj.page == wiki_page is not enough to make link local.
Files
Related issues
Updated by Etienne Massip almost 12 years ago
Yes and no, links generated in preview are not really supposed to be functional so the case is not taken into account.
Updated by wei hui almost 12 years ago
- File Screenshot_2013-01-21-09-14-40.png added
Updated by Jean-Philippe Lang almost 12 years ago
- File deleted (
Screenshot_2013-01-21-09-14-40.png)
Updated by Vadim Pushtaev almost 12 years ago
Is it really necessary to make link local? I mean, my browser doesn't refresh page anyway, even if full link to the same page is provided.
Updated by Vadim Pushtaev about 11 years ago
- File 12981.diff 12981.diff added
I believe the appropriate strategy here is to never use local links in preview sections, it's pointless.
app/views/common/_preview.html.erb:
-<%= textilizable @text, :attachments => @attachments, :object => @previewed %>
+<%= textilizable @text, :attachments => @attachments, :object => @previewed, :wiki_links => :full %>
Patch with tests included.
Updated by Vadim Pushtaev about 11 years ago
- Status changed from New to Resolved
Updated by Go MAEDA over 3 years ago
- Status changed from Resolved to Closed
- Resolution set to Wont fix
Please use [[#Section]] instead of [[Wiki#Section]] when you want to make a link to an anchor on the current page. The syntax is allowed since Redmine 4.0.0 (#16313). It should work as you expect.
Updated by Go MAEDA over 3 years ago
- Related to Patch #16313: Allow to link to an anchor of the current wikipage added